Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2415981rdb; Fri, 8 Dec 2023 07:33:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiO+mHaYXZqIG4bdjJykKTX35X9oaEbcRU1PHZktlPZVhpGbsq7yQzHijT/ooSH485ITBm X-Received: by 2002:a05:6512:ea3:b0:50b:fc06:7a2b with SMTP id bi35-20020a0565120ea300b0050bfc067a2bmr30310lfb.110.1702049587420; Fri, 08 Dec 2023 07:33:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702049586; cv=none; d=google.com; s=arc-20160816; b=0vBMw49zlxbwCCWPjr7+n7QE27tM2xZrreu2Lj7MSl23gXFdKMfMQEDF4cCKP4gOjT gmLSPRqagnBCj6lHIGSIVwOSe5EVL6wRgzZFEunutzrs/j0KF1Rb5nzH9nOATXiz2ibB eLFAvGPqt7rJw53jrQ5hb77a0N5FqmyFS1RTc7LLuA3T6RhY0VSBtEoTZt1Hsyg9ni/P X5KhMQj0bzERdjXYsHwb7cHQD3fA7rbOM8cmMUkv5X9ivDPv12MkOTgLj3hFJTYA5ltJ gG/N7g1Hlyi5xthL0uBRb4UJfZAVJrS1D2a2Gs7hYEOmR5wOpLA1GJ0UXYUMnOH6W9bm Rs3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=LT7fRfs8KC9k+kjaUKEuNtxWzom/y9E6tDR7zotRLtA=; fh=WZGjAHbGg538ZOmzRG19w/5QYPk9QMdQGI5nqGmeF5c=; b=go5F+lbc+zrNhoe4jbu6AjEGgV+Y6Fgd0ov/kMPq7CFJO0Yo3YnYtrjzSFhEJF+IrA 1DmeiGNhCuvzWEmAnzSWmPhmxHN0QJuPGk9Umsa99Tt1IJVfWxE2S1ocJMDD+/bJE67V 94ZgJE9sRBkd0mbWDh7rGdT4TyZjFm3n+3Mf8ZNiLhpcseNMgI77rftWEvpWBwjrGk5G BZKYCNe0a1lLViCWI3HP1/vYi/gTGHUdtJ+h52Gql0/F65Urdk9NVPTKiuSo6ATlkqQ7 U4bd82fXda7bX/oJ4pLScHqu8dbE5q1Y/7UtMGbqN4igjW7h+DoqxDH5Ak1o3h6D/kw4 XzVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=p3HSOpTU; spf=pass (google.com: domain of linux-wireless+bounces-580-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-580-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h11-20020a170906718b00b00a1f61e2fa2esi855846ejk.1032.2023.12.08.07.33.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 07:33:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-580-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=p3HSOpTU; spf=pass (google.com: domain of linux-wireless+bounces-580-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-580-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5AAA91F213F1 for ; Fri, 8 Dec 2023 15:33:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D21A5315B3; Fri, 8 Dec 2023 15:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b="p3HSOpTU" X-Original-To: linux-wireless@vger.kernel.org Received: from forward101b.mail.yandex.net (forward101b.mail.yandex.net [178.154.239.148]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06850173F for ; Fri, 8 Dec 2023 07:32:53 -0800 (PST) Received: from mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:d315:0:640:bb64:0]) by forward101b.mail.yandex.net (Yandex) with ESMTP id 16E8F608F1; Fri, 8 Dec 2023 18:32:50 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id nWgXPLCcs4Y0-J9Gpg8T3; Fri, 08 Dec 2023 18:32:49 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1702049569; bh=LT7fRfs8KC9k+kjaUKEuNtxWzom/y9E6tDR7zotRLtA=; h=Message-ID:Date:Cc:Subject:To:From; b=p3HSOpTUdiiujr1/6ojxEYgHwAXsFbSLZ+7UTr7jcsFcfbOlHruL3PE/gsy8Nxq43 T+dCkGf9KRfthwzWJi4wtHQBbOpAnyFO6acdJNPkJ51RkVjQccVrI1mTV1bZeyfnS2 nD2ExQcxTW+Yo8K5uS8+b48flJXPNqk0mpkypemQ= Authentication-Results: mail-nwsmtp-smtp-production-main-31.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Dmitry Antipov To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Dmitry Antipov Subject: [PATCH] wifi: mac80211: drop spurious WARN_ON() in ieee80211_ibss_csa_beacon() Date: Fri, 8 Dec 2023 18:31:25 +0300 Message-ID: <20231208153130.107409-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The WARN_ON() in subject was actually seen only once, with 5.10.200 under syzkaller. It looks like a weird artifact of (ab?)using the syzkaller itself [1], and hopefully may be safely removed. [1] https://lore.kernel.org/linux-wireless/1bd8f266-dee0-4d4e-9b50-e22546b55763@yandex.ru/T/#u Signed-off-by: Dmitry Antipov --- net/mac80211/ibss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c index 8b1e02f2f9ae..8f2b445a5ec3 100644 --- a/net/mac80211/ibss.c +++ b/net/mac80211/ibss.c @@ -485,7 +485,7 @@ int ieee80211_ibss_csa_beacon(struct ieee80211_sub_if_data *sdata, ifibss->ssid_len, IEEE80211_BSS_TYPE_IBSS, IEEE80211_PRIVACY(ifibss->privacy)); - if (WARN_ON(!cbss)) + if (unlikely(!cbss)) return -EINVAL; rcu_read_lock(); -- 2.43.0