Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3958569rdb; Mon, 11 Dec 2023 05:13:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMPgD2ckVdGaAesr1GYSecuP+NHbG6WuD6cAnTx2tQlBNuTyKlStI4Mm+2eD17LlsTAqpa X-Received: by 2002:a05:6358:915:b0:170:6ed7:3915 with SMTP id r21-20020a056358091500b001706ed73915mr6389864rwi.57.1702300430929; Mon, 11 Dec 2023 05:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702300430; cv=none; d=google.com; s=arc-20160816; b=NKtcOslt+QfHjUJKlL/u5cD05sxVMlE5fhHYiMY3/or1h1N8lB8Iyp1fOrmAa/Ugcr R01MWJIC53KRCparK0YfRYmbBT51rgA1mo3JcGGdrVxMY0mchrdFGAqQ0YrHpmtqU1Kj Fexiz1Bc71M8cqkquRtCd0t6L+MyIqroM8htn4zRzEcyXA8TayX2MoE9Prn7mIyMQ5GO YnNzk86+azIq0AdmvT8NJoII8sCnGQoTBJKlDnAn5uivJkMzlUY6oJWHjPJywPEH7E68 pJCKQ5Z1mExqMqeqW9p8zRyPK+UGZI6mBud4gVSA5Pe6sGjts1XV4WEu4GHx5MPdsZ2B 3YVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:user-agent:references:in-reply-to:subject:cc:to :from:dkim-signature; bh=HL1SQAjMk7kizDWMuI1ZeskLsrs19eXltXOKdu3ujEA=; fh=y9DisEIiZ6HbZo/5fGsfqsR4yeQ1LozvgKAEv23TjJ0=; b=dseV4p+z5477TW05DpVkeUcodnb0LDmUY8LD/HrmEBtoy/bLMZbk5bCwsGKlym+bac yaOHy05KTE99Ixf0JdIIh4tDtl19q2LGSQWTXJzTA6DBWRaLAUg4KMKpfQ40yYAmTQTS whc12JxqEiizsWc++BzDE/DwpTdFIr5XsQ2ba8WExYwiKSYwglSCsoh9K4dxSRnhJ45i c7Lv+hYIqkGUexjk4RJRCnSmpxlWOnsC499F1EYiGXTxqkHG1itq+2KK7FDTG+s9kP3G hXAiZGOf/6VH4Qb+JGL3vncPQ3lib00StFdRn7V2c3ZSj7B5EPYsQY3gj1uNHnfAaD93 bnVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tmfEW9Ne; spf=pass (google.com: domain of linux-wireless+bounces-660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id by26-20020a056a02059a00b005c65defc400si6314001pgb.624.2023.12.11.05.13.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:13:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tmfEW9Ne; spf=pass (google.com: domain of linux-wireless+bounces-660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E4370B20DB6 for ; Mon, 11 Dec 2023 13:13:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9FD6A3D96C; Mon, 11 Dec 2023 13:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tmfEW9Ne" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DFB3D96A for ; Mon, 11 Dec 2023 13:13:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E3B5C433C8; Mon, 11 Dec 2023 13:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702300423; bh=pIf8sTQFJFxaM5nVWsgit4VElj+tGJc5xIdKyuuHP6c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tmfEW9Ne+b+WNl+TG6pecbHskdM+si2/LfkeC1bUwFW2vOBTXbYr/36SdgQz66X6V D3GgunjTBiZlzB4ILMWYy2B2Q0JGX2nUk8aGbe2B7ZpY0MiU6+seI8PtB5foa6l9Xl FRDU1pctgbeXWzSGZlcfSt4YF/Zq8TkSrI0+HNVEK0A2hoOF0oVlHDDc8Fsx/SWZpG fGq1VdzIotkwwvdk1VsLMylZdnBhgIP2xO5a3HhKVJ5iwK2irDmhY4rz2v+rjvBakE oo5385YsVgWLXmqLQmIUsrTBOc9lTuCPHm6ws/erkd+7uB8WORHXsdFNv5RYdFpScW ZuZObrqmxdzjg== From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH wireless] wifi: mt76: fix crash with WED rx support enabled In-Reply-To: <20231208075004.69843-1-nbd@nbd.name> (Felix Fietkau's message of "Fri, 8 Dec 2023 08:50:04 +0100") References: <20231208075004.69843-1-nbd@nbd.name> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Date: Mon, 11 Dec 2023 15:13:40 +0200 Message-ID: <87edfsq3uj.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Felix Fietkau writes: > If WED rx is enabled, rx buffers are added to a buffer pool that can be > filled from multiple page pools. Because buffers freed from rx poll are > not guaranteed to belong to the processed queue's page pool, lockless > caching must not be used in this case. > > Cc: stable@vger.kernel.org > Fixes: 2f5c3c77fc9b ("wifi: mt76: switch to page_pool allocator") > Signed-off-by: Felix Fietkau I assigned this to me on patchwork and will apply to wireless later. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches