Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4526051rdb; Tue, 12 Dec 2023 01:54:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/IMpkot1jZ6oic7cvRzRRhzHUCqiiXttZEXkARxn/OXOWvuHGKSgrLajwDDww6+eTKOc8 X-Received: by 2002:a05:6a00:244a:b0:6ce:7ef2:40a2 with SMTP id d10-20020a056a00244a00b006ce7ef240a2mr6230049pfj.42.1702374886054; Tue, 12 Dec 2023 01:54:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702374886; cv=none; d=google.com; s=arc-20160816; b=b3IjpgKSRjU66HohfQoK6q96Qs/9tMeGxsuLZ9x5yJldG95Y4wMm4yaNGsRjxHJw9I Sevav6dxgP43FjGv+o2a8lX0P3p6mU151qnFeO1jZp9wB94vspZUAx9IoDfADaGOAljp 12otOg0sdpj1F7Jyso4nDUIq/ZkVFvhbt3z8/QFy8Cae+NO1Jso93gleC3ksm/blP060 CQMyDVGYyX2PGoSxF1rgm2ENuhfTr6ixsHqgw6WR1Qn7sDJlBHFmiG6n8CrXS+47gNvT PZ83mQFmc5VUBnMVNTSYu2mmwzqX0tW2+0SZ9VH1nRq7XNNCw7dGiI3opd8QBt13/Wy0 oWrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=btXgKtem807PqADR0Pf8T8yPpIyP4FhIA9j9YJN9QMM=; fh=6vInW2bJsrdKv5OTKeSObHrg4qHKTIVHSLhY9DqrLK4=; b=qAkLaHi8abcxc0qvzHDnNk+L7ijtTqQr47vXai0AF3hXy2tepwszcfT0iO5iFjB5Z5 2ve4XbkZz+MkHh7b7NcTO2LuLmkbNuF9aaFI07/M/k7Y5NK4SZDzLNLs20lpK64MGmA7 a1zdZnuR6AWRqLZCgVhyGamKoYmR5bxFBL898ptgJ52CPqI/cyj+soCUIDEACTQx1EmK zb9Bs7t6fYScw6q8HfDM+fedphzg7dOuibyXpmy35Pl5sAzqW+OVfIJSvxMjzUupLpcS D8zjHfILz3LunUIv88T1/ch9tWL6/xEzr4fuf2T9hATDN03QDD/xxGi97yS14lAvgDEs n7CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BFs0Vsbj; spf=pass (google.com: domain of linux-wireless+bounces-694-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-694-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w63-20020a638242000000b005c200c132ddsi6935801pgd.601.2023.12.12.01.54.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 01:54:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-694-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BFs0Vsbj; spf=pass (google.com: domain of linux-wireless+bounces-694-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-694-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D6731281256 for ; Tue, 12 Dec 2023 09:54:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 40F3359143; Tue, 12 Dec 2023 09:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BFs0Vsbj" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AB9D58ADA; Tue, 12 Dec 2023 09:54:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D57EDC433C7; Tue, 12 Dec 2023 09:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702374881; bh=g44so0aXENb1ZbYVlFiZWeI/HIvhAHxzBBi5p4XGpb8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BFs0VsbjwcxWVEkl3pXaSvyYM4X2Whkvb6oF9daOqpon9n89n7CCqsti8gUebdR2R +clPMLnHbXFu+jQwf8uQvDs/tq+mKSCExqEkGkjpIROV45xBnjwYIh5V0qlIfRkyq5 bx6Ythe77BYpy+bOer+3uX6ncBG4HON8uowwMv5zNo6O2J5PwNjmk85saMFDiez1o8 4S1rKVJcYFWQ99fbKhm4DQgjhg2+U0ShImfMsXbYl+PZ6fq7zAxmg489KMVIr+m9DO o3s0GpVg9aia5ugwjeKG33JFwAKTK+j0i5mIPiwMhmqIk8reskp5bMzQA7zDFmjEJW iucHoZIM+mC+w== Date: Tue, 12 Dec 2023 09:54:35 +0000 From: Simon Horman To: Rouven Czerwinski Cc: Johannes Berg , Josua Mayer , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pza@pengutronix.de, stable@vger.kernel.org, Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH v2] net: rfkill: gpio: set GPIO direction Message-ID: <20231212095435.GT5817@kernel.org> References: <20231206131336.3099727-1-r.czerwinski@pengutronix.de> <20231207075835.3091694-1-r.czerwinski@pengutronix.de> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207075835.3091694-1-r.czerwinski@pengutronix.de> On Thu, Dec 07, 2023 at 08:58:36AM +0100, Rouven Czerwinski wrote: > Fix the undefined usage of the GPIO consumer API after retrieving the > GPIO description with GPIO_ASIS. The API documentation mentions that > GPIO_ASIS won't set a GPIO direction and requires the user to set a > direction before using the GPIO. > > This can be confirmed on i.MX6 hardware, where rfkill-gpio is no longer > able to enabled/disable a device, presumably because the GPIO controller > was never configured for the output direction. > > Fixes: b2f750c3a80b ("net: rfkill: gpio: prevent value glitch during probe") > Cc: stable@vger.kernel.org > Signed-off-by: Rouven Czerwinski Reviewed-by: Simon Horman