Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4673822rdb; Tue, 12 Dec 2023 06:26:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGjYbW4RyzdRWfh0JjfbYayavA/Sy1ZjZgax39pYqlyygF/C2gweyZ+2ytsan+L4oUth6O X-Received: by 2002:a17:906:3559:b0:a19:a19b:c727 with SMTP id s25-20020a170906355900b00a19a19bc727mr2665991eja.119.1702391179407; Tue, 12 Dec 2023 06:26:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702391179; cv=none; d=google.com; s=arc-20160816; b=eu4JuuyxXUTnPsFi+NOHugFOGFocFuydIMIl7Qe9Q3CqUxz2Y9ZVAUy3Guy7cSQgOV hrjKUL7isVImdM+sTmFhqxJprwkvONEkgfByX/W17c0UyV6LM0JYXAQANCjphe5wRgD3 Zjxomtdldil97dUe+vTDmnQeBYbHsLFzg2PS5UqrEztSr/2O1UZgDwWtJ9CmvBm8FfKC 9Iz4lAunEwfByhtxFsDKGL4C+w6N8dehijGRordBY3VKFTaSE0DnrDT5EZLIGUUwLTsf diHAUjgCzmId6p+dThcOXHXTw0FVtTqzkD7ZLhSw0+gysAZi4OFTgOLLeY7LiVivj/cH e9MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=ZBJSDAB01VFRnzcyaxlcSg8FuiPUW05TASuS0jlzHoA=; fh=y9DisEIiZ6HbZo/5fGsfqsR4yeQ1LozvgKAEv23TjJ0=; b=xysrnERzPpBint8Jufcani54PpvCO7a/YTjBSvAKvVaCZpjZILbBbDSxsRBWS7yNQr Zx+GibLJ6k8OMiibwcsZVuKYhjNI7dLADKe9q1kdJ/8/wnb1dHz7sF5TvmUdcd/jpyvv yoNGbDPxcTRg7fX9SqF5RLx2qfITV6WhG7dNgo6j8vGNQVPEURtK3i9G1+72TNRCrxbu bZ8wOGCEP9lg9hUgZUkRuFH4MfbXaz0wTViIiYEwlwmVFsg44Cu6FK0HGaAjNAGINMei DFYxindlRq5+O2iYj9MnNXI7MDM3I0+vkfoxEvDQ9GwIOfhlglFE94cCHet+HWOJ8bty jlOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qK8sHZ8t; spf=pass (google.com: domain of linux-wireless+bounces-697-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-697-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y27-20020a17090629db00b0099207b3bc46si4543051eje.322.2023.12.12.06.26.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 06:26:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-697-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qK8sHZ8t; spf=pass (google.com: domain of linux-wireless+bounces-697-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-697-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BA5FD1F21151 for ; Tue, 12 Dec 2023 14:26:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C552373177; Tue, 12 Dec 2023 14:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qK8sHZ8t" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA3C36F62E for ; Tue, 12 Dec 2023 14:25:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8686C433C7; Tue, 12 Dec 2023 14:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702391157; bh=3yoY6ZENbVsfyH/ugD0vmo9/2n+g85FXdsmcJYy0V0U=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=qK8sHZ8tBPSAAcQINegEqfs/2ZhplJlwK9y+SkLh3Ym0OxVAH5unGsCxcjY9eyA4u PIRQOQUBvy4o1c9p5Ujy4R7Ix40bGqITgGuVYcsniRpLmNa4CSuUAMk8SEmOtk4RQE Clma7/CrDsbelKlJMCqaP/VnWaZ5LrbQPV99+kHDopVntJt8OHv0y24nhFPWr0AVhz WH1DdRXhEGJ/ppLB21/2Rq7W9Uq9PDol6k76jcvbjnCaJuPyqsz1atwBDZvwFCZ/YE sAZSlFyFi861EoBOhiaGbgszeLNsz+2IUgfAfa3crZR3l4ixfe1Duhlb7Wtw0ALg5O e9Dq4LITChmqg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH wireless] wifi: mt76: fix crash with WED rx support enabled From: Kalle Valo In-Reply-To: <20231208075004.69843-1-nbd@nbd.name> References: <20231208075004.69843-1-nbd@nbd.name> To: Felix Fietkau Cc: linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170239115444.238941.12599442147553247928.kvalo@kernel.org> Date: Tue, 12 Dec 2023 14:25:56 +0000 (UTC) Felix Fietkau wrote: > If WED rx is enabled, rx buffers are added to a buffer pool that can be > filled from multiple page pools. Because buffers freed from rx poll are > not guaranteed to belong to the processed queue's page pool, lockless > caching must not be used in this case. > > Cc: stable@vger.kernel.org > Fixes: 2f5c3c77fc9b ("wifi: mt76: switch to page_pool allocator") > Signed-off-by: Felix Fietkau > Acked-by: Lorenzo Bianconi Patch applied to wireless.git, thanks. cd607f2cbbbe wifi: mt76: fix crash with WED rx support enabled -- https://patchwork.kernel.org/project/linux-wireless/patch/20231208075004.69843-1-nbd@nbd.name/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches