Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4719653rdb; Tue, 12 Dec 2023 07:34:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUx+PjkRmUN1xKeJA2ObtMqha1SM3Ru1RrVFqfR+PgM6xupHaV301/unWNEwecXlzSOkwC X-Received: by 2002:a50:f60d:0:b0:551:d47f:9b17 with SMTP id c13-20020a50f60d000000b00551d47f9b17mr179526edn.114.1702395242805; Tue, 12 Dec 2023 07:34:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702395242; cv=none; d=google.com; s=arc-20160816; b=iGNhjDL/XOMth0Pzz99ebf08/+RLwdYkdCnbSmWjIvmwlgxINLl0SFyYeUCA/odHzm Si2xDox0OayR/AQ96LF5CrbeoznUsHvWEpdLD/c/705FLhBQxiwkOmljn5USKFGDWAJN tsyZ1oLoq/j3ailmF1YSjN3sPsnBfX20MF8Q0jkdKqehaklFgcQ13UN2xEbAU/HJ2zHC +IvCK8cFEY/a0xwtjviiSaF3d/gDXW1flavIyfJEu9UZAWwWbLSpCawYRKhw5trl3Zlv C/skq6pzF3Bhkzbt7KAD3wW1dT40mg0+Pawnd/Nweb8InIa15TVXOBQJXHbQiFr60yN8 zeHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=INvyJSa7kpQrS2qXuPbr83CRLbqWi8DM89e19kHiYmk=; fh=nvwTCHrAx5Ltu4No0Zr23VweInP1MfU5v8e+FgT4j4Q=; b=PQ1hJiWqRbA27oiPKiPsrBpFSrdzfZri4j5wyr1XDL06Fg6WLBcpQEUZzJsjcuCbnZ 6eNsaIlVEuDde1f4apOBS/PHNOKEguUv2Mh+QY253e7mSeh3W4DKcn0wJTpoTeRsrpeS eKJL/U0MERee3ylMWb3uAYx9KJZV6B81e4CaltOlqheK9qe7AtjVQTMd3qaaUs/gJ2j5 G6nUTBjU58YGrWxjGkq/dTtgXmqzPJRGb8oZ+TjKMm5Eo9qshrcbKM04KzODznHKALm9 s5gJyE7qzJs1Hl1QP+hExJ++E2uSwQeS2jGadevDpLD4PPVlwNuA1SCI6xQxEG83eTSI iX2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rlewShFq; spf=pass (google.com: domain of linux-wireless+bounces-702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-702-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id h14-20020a05640250ce00b0054b126c8d00si4656717edb.59.2023.12.12.07.34.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 07:34:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rlewShFq; spf=pass (google.com: domain of linux-wireless+bounces-702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-702-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8C66C1F2107D for ; Tue, 12 Dec 2023 15:34:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3E16975424; Tue, 12 Dec 2023 15:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rlewShFq" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23875745E7 for ; Tue, 12 Dec 2023 15:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 947BFC433C8; Tue, 12 Dec 2023 15:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702395237; bh=SmtuEPtz2gzeGWshtG4uyVitXKymgOX+I4Y5KbfxugY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=rlewShFqcuUl6vDGpo3zWkQ7SBnDE5lCbYdC7i2VNcygpJjq0aHvF6ZhnKu54uz3m OjD0cq/NZ2Ogknuk26z7NB559boqbVAwrNRRz1LYZIXaLDOv5GOoGwMVepFM65Q2Gf olf39Qh/K/raIGyWG5FfBzhorsycp0xTgWw2x6EO7wn7ziCF0G/I6/sD+J0hpDw/pr SUzySXvY/eBRBWqxUq+PLMtoUP8jz6KBiyx3q7J1pm/6zZtBqdds3f2zVb05DasPXX L+BiD+TnVM4yaBzxKyXShsXoVE67q4Kni5mkSONf4nwfEIzWg+kxffa7Gcvsn9fSf2 Ziqz3wKZX7Omw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] [v2] wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap() From: Kalle Valo In-Reply-To: <20231204171130.141394-1-dmantipov@yandex.ru> References: <20231204171130.141394-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170239523486.306086.11081054761735542992.kvalo@kernel.org> Date: Tue, 12 Dec 2023 15:33:56 +0000 (UTC) Dmitry Antipov wrote: > Since 'ieee80211_beacon_get()' can return NULL, 'wfx_set_mfp_ap()' > should check the return value before examining skb data. So convert > the latter to return an appropriate error code and propagate it to > return from 'wfx_start_ap()' as well. Compile tested only. > > Signed-off-by: Dmitry Antipov > Tested-by: Jérôme Pouiller > Acked-by: Jérôme Pouiller Patch applied to wireless-next.git, thanks. fe0a7776d4d1 wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231204171130.141394-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches