Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4720412rdb; Tue, 12 Dec 2023 07:35:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaiiAI7/ahC+hk/SuoAEejSIU69t0ztZ0EXPDUpCIvzEGhZsnDfCvr9k4cloMgTrGub84k X-Received: by 2002:a50:cdd5:0:b0:551:6509:a340 with SMTP id h21-20020a50cdd5000000b005516509a340mr459622edj.83.1702395301196; Tue, 12 Dec 2023 07:35:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702395301; cv=none; d=google.com; s=arc-20160816; b=WP2dzqSM7f9niMgEt2KcbFxgocy6O9wQCAde4ftXMpik65P3znGOSoj/RKQ6AXiedD MqYAATUTdKd1xZiOaHQBWtKPJhTBFpRhX3Pdj/H557zIT4/oyW526ZKv8t4Zcp/5ypSy CAQzwIDWFFYJkEhILl2WVS062LL11leAuOox78uj3m6zEztQai6VZ2RMPW8Rd5zruABC N5AYpRpyTtCm708FpiPu4zOLa1gbzSIsb8GayNE8AZJ59powtpODmgA/XbVhojy9R9y8 8cy2zkBxLnTt9VgMNqATwToPv3Fa1eJp7/CEidjt3Dn8BbO9+qqpQlcBa+wyuyEKvrNp clpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=+MQKy7qxUZGQU9M5NVDZhqkKdrxVkznY2sNOEWhWIlE=; fh=NLIxLoYvyMClkIB5sV+XaiChDTp6U1DbguXHc/QMQaA=; b=l2LKxmHut2jsYu2WhmpEU53YaOwAndyFi+B6WfrKU32iFYacfI3JL94KjSLZY59cR8 doUCE048SjeZwNnJYKiN210JidzuVrgcX59bIR75wI6beon/0OF/tCb0cEM3XmN1OLv8 jSx7IIJ8pu9D6zxrmqibiM9KQH1kGV1a9o/UrtjoKp8bveA1btD/INDkT1GUYqy6IKUI 4XgaFqJdFG+Ygfa8er9jXPuRyBLf3dW6oeFKjlm0P01+3oOvfw90Js/N9XESwDpxKGoT 1Q9o7EBZDHYwV2B3rDc/FFppG0uQmCAEAdeQMgsGpANtAU/SMVKL4MrGfNWK1N04gK+9 X30A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDV+WqqN; spf=pass (google.com: domain of linux-wireless+bounces-703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id s20-20020a056402521400b00551dbe0834asi124920edd.161.2023.12.12.07.35.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 07:35:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aDV+WqqN; spf=pass (google.com: domain of linux-wireless+bounces-703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EC8591F2107B for ; Tue, 12 Dec 2023 15:35:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B25575424; Tue, 12 Dec 2023 15:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aDV+WqqN" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E16E1745E7 for ; Tue, 12 Dec 2023 15:34:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6170EC433C7; Tue, 12 Dec 2023 15:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702395296; bh=Ti5TJsZx7dm3iX20ybxRIThKjHbWp8O0xyOh1hZro7w=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=aDV+WqqN0zbJkd1YtJQWITVzTd7tpcw4zeSxSk7KAMuu+cjWyxpaLb/hsdK3S2a8E Qt9Olz7o4KsaF/nz6Nl3+yiT66AUhjZsrCzfgjuj2VgY/bkcIe6ApPB9yqiLC3F6mJ 52xOaWBqoVYohk0BJ8pya/gn15V1FfUuC3v6IWK/JmHVISAjQcT0lp0yDTUO0Z+X5a Me0QNPPhm6fpoq4ROhzkWl7sRHy2Wjr2Zxr4fH6f1pJh/MYTa7qAgR3R1EgTETRL/t FpQlcV2JMmz7+vjOgRVZOMU61Vbb/tfc0UsnhuE4tLZsJSCXnV9uiIWSNVS7OLuRS7 kXil5ZIc+JPcw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: Use random MAC when efuse MAC invalid From: Kalle Valo In-Reply-To: <20231208150739.129753-1-macroalpha82@gmail.com> References: <20231208150739.129753-1-macroalpha82@gmail.com> To: Chris Morgan Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com, Chris Morgan User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170239529317.306086.14094133972122975560.kvalo@kernel.org> Date: Tue, 12 Dec 2023 15:34:55 +0000 (UTC) Chris Morgan wrote: > From: Chris Morgan > > When the MAC address read from the efuse data is invalid, warn the > user and use a random MAC address instead. > > On a device I am currently using (Anbernic RG-ARC) with a rtw8821cs > the efuse appears to be incompletely/improperly programmed. The MAC > address reads as ff:ff:ff:ff:ff:ff. When networkmanager attempts to > initiate a connection (and I haven't hard-coded a MAC address or > set it to random) it fails to establish a connection. > > Signed-off-by: Chris Morgan > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 0a999d82b782 wifi: rtw88: Use random MAC when efuse MAC invalid -- https://patchwork.kernel.org/project/linux-wireless/patch/20231208150739.129753-1-macroalpha82@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches