Received-SPF: pass (google.com: domain of linux-wireless+bounces-737-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 13 Dec 2023 14:26:39 +0100
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	Felix Fietkau <nbd@nbd.name>, Ryder Lee <ryder.lee@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
	Deren Wu <deren.wu@mediatek.com>,
	Ming Yen Hsieh <mingyen.hsieh@mediatek.com>,
	Ben Greear <greearb@candelatech.com>,
	"open list:MEDIATEK MT76 WIRELESS LAN DRIVER" <linux-wireless@vger.kernel.org>,
	"open list:ARM/Mediatek SoC support" <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>,
	Sultan Alsawaf <sultan@kerneltoast.com>
Subject: Re: [PATCH 1/2] wifi: mt76: mt7921: Disable powersaving by default
Message-ID: <ZXmxD1foASMaCDIe@lore-desk>
References: <20231212090852.162787-1-mario.limonciello@amd.com>
 <874jgmnud8.fsf@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9uLM4Nq5uaqfA0yL"
Content-Disposition: inline
In-Reply-To: <874jgmnud8.fsf@kernel.org>


--9uLM4Nq5uaqfA0yL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Mario Limonciello <mario.limonciello@amd.com> writes:
>=20
> > Several users have reported awful latency when powersaving is enabled
> > with certain access point combinations.
>=20
> What APs are these exactly? In the past 802.11 Power Save Mode was
> challenging due to badly behaving APs. But nowadays with so many mobile
> devices in the market I would assume that APs work a lot better. It
> would be best to investigate the issues in detail and try to fix them in
> mt76, assuming the bugs are in mt76 driver or firmware.
>=20
> > It's also reported that the powersaving feature doesn't provide an
> > ample enough savings to justify being enabled by default with these
> > issues.
>=20
> Any numbers or how was this concluded?
>=20
> > Introduce a module parameter that would control the power saving
> > behavior.  Set it to default as disabled. This mirrors what some other
> > WLAN drivers like iwlwifi do.
>=20
> We have already several ways to control 802.11 power save mode:
>=20
> * NL80211_CMD_SET_POWER_SAVE (for example used by 'iw set power_save')
>=20
> * CONFIG_CFG80211_DEFAULT_PS (for kernel level default)
>=20
> * WIPHY_FLAG_PS_ON_BY_DEFAULT (for the driver to control the default sett=
ing)
>=20
> Adding module parameters as a fourth method sounds confusing so not
> really a fan of this. And the bar is quite high for adding new module
> parameters anyway.

agree, I think we do not need a new parameter for this, just use the current
APIs.

Regards,
Lorenzo

>=20
> --=20
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches

--9uLM4Nq5uaqfA0yL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZXmxDwAKCRA6cBh0uS2t
rMk4AP4meRcee0zlYRgossoI8og7N/lRVYrPEbK9Pvu+GoHvbwD9H342JwJu5cTO
ESqtC33FKLmyM0+wXLDJ/KpvDg+gNQQ=
=O53f
-----END PGP SIGNATURE-----

--9uLM4Nq5uaqfA0yL--