Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5362771rdb; Wed, 13 Dec 2023 06:45:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHunZuY/+GhEIiIw0Ap3sJkiUi+vfDexkLzbmfu9k2BkGYS5YdYgPP3bTwokkknPN2MlFEK X-Received: by 2002:a17:907:7ba0:b0:a1a:c370:2218 with SMTP id ne32-20020a1709077ba000b00a1ac3702218mr3349063ejc.83.1702478742512; Wed, 13 Dec 2023 06:45:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702478742; cv=none; d=google.com; s=arc-20160816; b=ZWizVIKcyLfJhgoC3WXXQS6lARw6FvAi4XTwXskUeBKxHGxpSf5ayrE+fjcoI+OYli Ve6zPkmAx/n8f/qQUTc30K8x/dJAliHABr/ZeGVPbZqVSv42KviKosrPlES3YE06qMS4 l3wPnxI6/Lu8C10LxSwA2MIiCtIKUgvNVhTrgFl2uJVuXVXrCveIOasXiE9bTFSalTqq pSqcEFl1X8mMIQXQ7pCmHw6E5lbEyaH4eS+RyElw/zS3Jbl5scsstuYMJ0E0qkdoATdJ doabeOiPu6XA5jxmh4depln+FYlRYlhdYcC6vVZy5YRyQZRD7FWJ6yS1N1a7NVqFg9Xs qpoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:dkim-filter; bh=CBlRrUoOIRVJYNC6cQSzrC9BYSjs+oqsdU7/6hMHQp0=; fh=z1/WXPDkbUNxAPautodaSu3pNKcOH0rNjWJF7xixJsw=; b=JrKZhoP/6lufRAX6UPd/JNPD5kmri0zCrOF5cb0SB0Q3OWoDQdPPVo9ztApRTuXVn0 LuxgvDWFvOgY/ExNTCoUkW/Kx/KX+xRvAEUE9LqHDd6asJyanUuXX5mSpKgUqhoov2r6 masTTcbFRv4o/KJD4683128KxpPzHHtptobWuSrCMT+BEggXI4droQLC4rAMm0T1rR8v 4GFwavlw0jO/B69RfV/9/X8eCVc+7lSNgMtWENiQ1KbpVG8P7IfdRmQVqL1jrAnH0UH9 UG3mR5iD6fEzmpCC0KK7PEAggvppvME4uzr911hcANf3JqqDgKZ2PL+SIzNcYKDVAlkn mYqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=FtctL3Xf; spf=pass (google.com: domain of linux-wireless+bounces-740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-740-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id xa23-20020a170907b9d700b00a1f653abf40si5568348ejc.1038.2023.12.13.06.45.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 06:45:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=FtctL3Xf; spf=pass (google.com: domain of linux-wireless+bounces-740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-740-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 20ABF1F217D3 for ; Wed, 13 Dec 2023 14:45:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE22026AC7; Wed, 13 Dec 2023 14:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="FtctL3Xf" X-Original-To: linux-wireless@vger.kernel.org Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599631BFE; Wed, 13 Dec 2023 06:45:32 -0800 (PST) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 25BDF3C0063; Wed, 13 Dec 2023 14:45:27 +0000 (UTC) Received: from [192.168.1.115] (unknown [98.97.113.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 5A6FA13C2B0; Wed, 13 Dec 2023 06:45:23 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 5A6FA13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1702478724; bh=CyzNsGLkg4WlGdYLD0CORyHCimqERrevF4Jayf7AZrI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FtctL3XfK12CbRTl5KHhn9cT9j3FXr5yCvhS9Xeakwq9IcOq7UGhZok9Zp5wfhEBH /iRLEzUwz012MLtiuCU3BMuCtLx75xTl22OG5aq3TxxGAvt3BOSitdlbPoGODFuQwW YVntLFUGLNlf+XLJAtZ7c8uNqHUPgHSp8a9lhY3Y= Subject: Re: [PATCH 1/2] wifi: mt76: mt7921: Disable powersaving by default To: Lorenzo Bianconi , Kalle Valo Cc: Mario Limonciello , Felix Fietkau , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Deren Wu , Ming Yen Hsieh , "open list:MEDIATEK MT76 WIRELESS LAN DRIVER" , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Sultan Alsawaf References: <20231212090852.162787-1-mario.limonciello@amd.com> <874jgmnud8.fsf@kernel.org> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Wed, 13 Dec 2023 06:45:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit X-MDID: 1702478729-Q2nO4rVjVD1u X-MDID-O: us5;at1;1702478729;Q2nO4rVjVD1u;;0636e1de1030682809d49efeedd0cda8 On 12/13/23 5:26 AM, Lorenzo Bianconi wrote: >> Mario Limonciello writes: >> >>> Several users have reported awful latency when powersaving is enabled >>> with certain access point combinations. >> >> What APs are these exactly? In the past 802.11 Power Save Mode was >> challenging due to badly behaving APs. But nowadays with so many mobile >> devices in the market I would assume that APs work a lot better. It >> would be best to investigate the issues in detail and try to fix them in >> mt76, assuming the bugs are in mt76 driver or firmware. >> >>> It's also reported that the powersaving feature doesn't provide an >>> ample enough savings to justify being enabled by default with these >>> issues. >> >> Any numbers or how was this concluded? >> >>> Introduce a module parameter that would control the power saving >>> behavior. Set it to default as disabled. This mirrors what some other >>> WLAN drivers like iwlwifi do. >> >> We have already several ways to control 802.11 power save mode: >> >> * NL80211_CMD_SET_POWER_SAVE (for example used by 'iw set power_save') >> >> * CONFIG_CFG80211_DEFAULT_PS (for kernel level default) >> >> * WIPHY_FLAG_PS_ON_BY_DEFAULT (for the driver to control the default setting) >> >> Adding module parameters as a fourth method sounds confusing so not >> really a fan of this. And the bar is quite high for adding new module >> parameters anyway. > > agree, I think we do not need a new parameter for this, just use the current > APIs. Is there a convenient way for a user to make any of those options above stick through reboots? To me, the ability to set system defaults through reboots is a nice feature of module options. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com