Received-SPF: pass (google.com: domain of linux-wireless+bounces-761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <dfc24ec8-4741-4c11-bd50-d5cc8d60447e@amd.com>
Date: Wed, 13 Dec 2023 13:28:01 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] wifi: mt76: mt7921: Disable powersaving by default
Content-Language: en-US
To: Felix Fietkau <nbd@nbd.name>, Lorenzo Bianconi <lorenzo@kernel.org>,
 Ryder Lee <ryder.lee@mediatek.com>
Cc: Shayne Chen <shayne.chen@mediatek.com>, Sean Wang
 <sean.wang@mediatek.com>, Kalle Valo <kvalo@kernel.org>,
 Matthias Brugger <matthias.bgg@gmail.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Deren Wu <deren.wu@mediatek.com>, Ming Yen Hsieh
 <mingyen.hsieh@mediatek.com>, Ben Greear <greearb@candelatech.com>,
 "open list:MEDIATEK MT76 WIRELESS LAN DRIVER"
 <linux-wireless@vger.kernel.org>,
 "open list:ARM/Mediatek SoC support" <linux-kernel@vger.kernel.org>,
 "moderated list:ARM/Mediatek SoC support"
 <linux-mediatek@lists.infradead.org>, Sultan Alsawaf <sultan@kerneltoast.com>
References: <20231212090852.162787-1-mario.limonciello@amd.com>
 <9da16cfc-d0e4-4e9f-91b0-42b0bf4141cc@nbd.name>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <9da16cfc-d0e4-4e9f-91b0-42b0bf4141cc@nbd.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cDcrYXZiaTdmZGNQUjJveWgySzNQd1Z3MC9wYmtzK3BwYUhLMytnRHRVWHhr?=
 =?utf-8?B?ZVhWZ0JncktUSStRSjc3UzZRL0hpUWZtYW5JcTBodFNvNHpyaE95Wit3STZY?=
 =?utf-8?B?NFl4dXd6QmdObHYySTNzLzcrNThJcy9ENVQ2ckpJTXhhekR2YmhQblBYYWJi?=
 =?utf-8?B?WXJQbjNqNEMyZ01xdURUc0Y4MlRiTXRiOUZjcXhITERRUEtLT3JoR2Nrckhp?=
 =?utf-8?B?TnZzTG5UOEJwTTBwT0E5NHhBU21mQitIcmxEdXp6RU4yRDZiZ3NIVExJNzVp?=
 =?utf-8?B?TkxPbm9SQWY1Vmh0T1JwRzBneVNwYUFadGtLZzB6dTA1TmIvWmQ5TmxOS2Na?=
 =?utf-8?B?M2JJNnYySFFNbll2QWNKRWt6eDN3V3o4SzRsZmpPTEpvUG1PS3IxaVhWUnha?=
 =?utf-8?B?Qk1OL3lVbjlMYUVFZ014bjZWQUE1YW1lelRNVklleUU0TStLN0FlQ0FlY2g1?=
 =?utf-8?B?RVZ6a2g1emYxT09kazgrQkU3WHZpWG1BVEhjVU1JSkNUU1hFWlBsN0hVbDdH?=
 =?utf-8?B?WFBjMGF2Y0FLTUVkVERlbGZBMjF3a3o1NVVFK3Z4T1FBMVZKMUtYeVNYSXUz?=
 =?utf-8?B?MVhBVHZqd2pmd2dqKzZwWXJ3U2R2QStRa3lQOE95NDVTWkRFUnY2OGVOdTVP?=
 =?utf-8?B?RlhIZmI5RXpGU2hiZ2VhYjJVUkdheklGYmZ2cmtiWWVkT1dBQ0hVNDNlSk5X?=
 =?utf-8?B?aEFpN0YydEJDeCt4b0VtM21HTnR2ZjZIa1pESk4rYjZXRGdWN0w5a0RpZjcv?=
 =?utf-8?B?YjZRRGFkRnkrMlEvK3dYbFEwYVYrWks1TUtFL3F1MEhJeisyWmwzektoZEM0?=
 =?utf-8?B?eVpJcVlRa2NhOThlaElRSHVBL0o3Z1ZOOHFBejVibDZaaEUzWjBKY2VMdnBG?=
 =?utf-8?B?MHg2Uk1sNGRySjZLUVdwVzAyK1ZmSjgwVkxQYnVjTnVYcEt6dGJHT1JRU3RQ?=
 =?utf-8?B?UlNJMVNITTdiQTl6VXFCMlZUdVN5RXNBMUJhQkZrNWNDK2UzZytLdlNCc0JH?=
 =?utf-8?B?S2R1SEUxdDJjTDRwd3IxWXpOSHZsYWh2Y0k4L0xldk1WRXM0czFQeU1SdjdK?=
 =?utf-8?B?THhGeWdOZmxsKzdNLzBjWmlDWkFxWFhFMkJsNnh4RWRHaWdRS0hQTVRnOWpI?=
 =?utf-8?B?Q29FSFdxNWMwd05saXRlVUZ2R2ZmSUVtU3MwYytPR1FGL20yTjJZcURGQndV?=
 =?utf-8?B?OHRZODN6ZnRsOHA5amxJUmFwT1Z1S2FhZzR6TllNOW56czJIb0thSGZZbjlS?=
 =?utf-8?B?aEltVWVMSmR2UzN6d0RqNVZPc3IvMTdJMkNsMlZmQXhvdW45SkFyRUJJdEFI?=
 =?utf-8?B?U3VOd25oWTBlaXJVWVJFdHdHYnJTMlBpRnVpR2dtMExoVjNwUDFsUzdaRncw?=
 =?utf-8?B?UGZMTENUc1orZjJSWnN2bFN6T0RrWUxFMVo3SnhpOVljSXJ1aVR4QUxxY2lj?=
 =?utf-8?B?dFVSSlFiWkcxVzNrdlVUUzVpblRoSnhVWHZUeW5DWStnQmk3OG1OK1ZpRnp0?=
 =?utf-8?B?eEF1YzFqSnlreEYxY2xxS3BKeDZ1WHRvNWJ5UUhZckVmRkJLOGthS0JiMWlL?=
 =?utf-8?B?cmFKSHlzRWYzckxQWVNTa0tFak4rWVhVbWViTDBqeFovTjk3QzFBbDRGZWRW?=
 =?utf-8?B?cTk5aW95am12bGNTS3pTNi84a2hmNWVvajVEdWtuZk9yd0lBOVlsSUV4TERL?=
 =?utf-8?B?bk5IUE5pYzltdGVscG1JTnJZcTZuaU8vY3Y4elpUWGtvZVErbzU2WjVDU2cr?=
 =?utf-8?B?YW5oR0hIRkN0SG8ydXZsZDVsR0ozRGpOUHpFeHcybSs2RS9pNDY5MnZPZUMv?=
 =?utf-8?B?d1lYTm1ZaVoyT2tnVUtsOU1NaTVVdWNIaW1yU2xZV0RMck5jMExxWjhkeFZ3?=
 =?utf-8?B?ejlzZVlxYXlTN3VEMDRJT0xvK3JFL015NjUzcW5JWjExNS8xUkdzZGJ2dnp3?=
 =?utf-8?B?U0krQ0RKem82L0RlajI3VjJZTUs4WURtY2tGOGN3NGt5L3RhQWVSU3BlNDNt?=
 =?utf-8?B?OVd1U0JmMEVKaWo5KzlOb0NqeWlQQ04xRk05alVXS2FPOCtqYkhkdlk2L0Jo?=
 =?utf-8?B?dlFDei9uZzZNekE4eXdnUXhSZnM4aGJtSkNlSjQ1NnlxcENJSXhRdmh4Qndp?=
 =?utf-8?Q?88HBSoxF2HcUqBdj64sf1j4uc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e67b802-7339-4350-85d8-08dbfc119f70
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 19:28:02.5196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f5Fu3llq+HexAjaxzS4K19e16aLj8zuzTlqUCBKnbvBCYstRPlbrGobhQ3r5P2f/DnPeZiUOQEnl2Y32Zn5GoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5966

On 12/13/2023 07:35, Felix Fietkau wrote:
> On 12.12.23 10:08, Mario Limonciello wrote:
>> Several users have reported awful latency when powersaving is enabled
>> with certain access point combinations. It's also reported that the
>> powersaving feature doesn't provide an ample enough savings to justify
>> being enabled by default with these issues.
>>
>> Introduce a module parameter that would control the power saving
>> behavior.  Set it to default as disabled. This mirrors what some other
>> WLAN drivers like iwlwifi do.
>>
>> Suggested-by: Sultan Alsawaf <sultan@kerneltoast.com>
>> Link: 
>> https://codeberg.org/Hybrid-Project-Developers/linux-tkg/blame/branch/master/mt76:-mt7921:-Disable-powersave-features-by-default.mypatch
>> Link: 
>> https://aur.archlinux.org/cgit/aur.git/tree/0027-mt76_-mt7921_-Disable-powersave-features-by-default.patch?h=linux-g14
>> Link: 
>> https://community.frame.work/t/responded-strange-wlan-problems-with-kernel-branch-6-2/41868/4
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> This patch is disabling two different things at the same time:
> - Wifi powersaving
> - Device hardware powersaving
> 
> Have you tried simply disabling 802.11 powersave via nl80211 to mitigate 
> the issues with affected APs?
> 
> - Felix

Kalle suggested this as well, I will experiment, thanks.