Received-SPF: pass (google.com: domain of linux-wireless+bounces-776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: David Lin <yu-hao.lin@nxp.com>
To: Brian Norris <briannorris@chromium.org>
CC: Francesco Dolcini <francesco@dolcini.it>, "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kvalo@kernel.org" <kvalo@kernel.org>, Pete
 Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: RE: [EXT] Re: [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE
 for assoc req.
Thread-Topic: [EXT] Re: [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE
 for assoc req.
Thread-Index: AQHaIdVYu6BJedWzZkuajUNTuEil2bCUO9iAgADQvWCAExa5gIAAAKJg
Date: Thu, 14 Dec 2023 02:20:47 +0000
Message-ID:
 <PA4PR04MB963845409055281417132AA3D18CA@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20231128083115.613235-1-yu-hao.lin@nxp.com>
 <20231128083115.613235-5-yu-hao.lin@nxp.com>
 <ZWmzAWlh7o4bLZB8@francesco-nb.int.toradex.com>
 <PA4PR04MB963816B99845D943B4D061E2D181A@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZXplY3Gi6Fv19Y_t@google.com>
In-Reply-To: <ZXplY3Gi6Fv19Y_t@google.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?aTmQJrFgKPYrAl/GxskwDSTrClN0mw0K8D5wPw6toxOI9dX24F4sl+ObZpHP?=
 =?us-ascii?Q?H72x9x6/yIyVa4wN0+H/ymxhIR90wpiwkrva8w1aUZMm02FmgEW+F3zP7bxi?=
 =?us-ascii?Q?yvOl73k0Rh0Vus/Bopp24MCU46lkS+tx6EOI+9Xc0vJY86+s34CkhInyfAI3?=
 =?us-ascii?Q?pxdXuCHv/mS/7SVheRxRVaH1gfMkdhUB7BflyeQdm2tRYX+apzQqA9LcHY+u?=
 =?us-ascii?Q?9DZLpdSGnHn6jkJG5pLj9K7x6+eTUWovtx5V9OdVGO4rkwgbe1QpLXC6gbBU?=
 =?us-ascii?Q?8IW9E3aKZAWrUekkQreE1j3luxC0Fey2HSY9ZOkvjVOQU58HbzfFWMTTuH6y?=
 =?us-ascii?Q?hPIisIhBmtbTHgrTXexZEAcjqFgtxk3KjkXdLLsG79ilx0UR8YZxOjB4TAbY?=
 =?us-ascii?Q?kVaFsAPUExcUcGS5/zYlFkVZfFBoxVITRn7YTdmx+w8QLKplthyamIXWbgtI?=
 =?us-ascii?Q?4v7IKUxJbAauOlI4M+rn/GHrkNCz7iVXCoSufFlbqEXgqwDpxs5EzsbnaQCn?=
 =?us-ascii?Q?5yqO23ZI7czSozJaGR3lCiU/jgfJKMH5KSC2tebEYKdIicixbZDQ1s70xJwF?=
 =?us-ascii?Q?iZ+1edtlOCMHu2nf6LkflFQCYhQX6QGuiV2Ww4QuQUhizaqSG0CkgELVIwSn?=
 =?us-ascii?Q?LP1y9JprcW/7gZjEubEoCiHNa4tt/QVq8ENVABO07vU5k72WXenE3B3KJpu3?=
 =?us-ascii?Q?cdUcdBaQasl4dmNNYXWPBFoBIEsIqsuXmyg0K+/ZDDTUuRUNTaJmJGCjy9mY?=
 =?us-ascii?Q?+o4Vvi3gHKdqTUC1Ijw6NvAxKNHfY8sodNHrW8CA6yHZp95Vm6Iy2y/vFOr7?=
 =?us-ascii?Q?KyJw4bxujUrTMKyNlrj/nduhK1XvHHz6UsuwSGi9aW1ZdwQPIJBCHnoLbtyp?=
 =?us-ascii?Q?UE3T/6aXeg++zwPoyH5zTeEsvL0tuIr0w0jaojV5Augn6DDV9kkKzBGMJFJl?=
 =?us-ascii?Q?uSaQ+fEZnQaIab3Va7tHuWBEOJo25eE4+JNZtK3w4LYcfOzM6SMWSserVUbL?=
 =?us-ascii?Q?VQk3q4onxH8t385UfhgGxyXU4BShMGbWK3ftoP8ZkLqweoqaD5WlrztYQXet?=
 =?us-ascii?Q?Y8zhAx49eovFr+P+MMSEDIU/rN/v3tsHp2RmLgHcKSvGtonZ6x/Ljkn7Dx9w?=
 =?us-ascii?Q?Uh8IWPRNtpKeUXv5LPLkPWadC0EjGz6v3bapLvHn+MVOfrcEs2dh2OvAryic?=
 =?us-ascii?Q?QwA+PdveetT2P1hS3gKvlm1SuYHpM4WHD/UkAP3RCIj49p17IiFPCZI2oXbj?=
 =?us-ascii?Q?2+lfuttxZM46R2tZ05nyfdwNjpceDNTaUjtGhlacH9yc1I6OCH3p65TEfnAU?=
 =?us-ascii?Q?+3GIGupYcI1Pqrht/Ggx4MuGa+y0O/h0s8fUtFAiknQlyiMnCmRDVqIWdwtM?=
 =?us-ascii?Q?0Azn/kBo3mHh8PZAonWnex2ApsphBS1b3QzBhSCDoFSHTVoYbLvsR5HU7+BY?=
 =?us-ascii?Q?PICAAVGbwrbeEvhdSxb+yl+VnCmpQJiEEmOvFjZ6XeDGfUctLhOaowf6rMIF?=
 =?us-ascii?Q?cVbV6EbygtKY7l3FFj+KTkX3PyBnlNmkWLAMhfLe/D/1aDM2URVwxUb4/Sv+?=
 =?us-ascii?Q?PEH+21oZOPvNBmC/XHrjU6SeDx+QGn30E9SWcrCC?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3e7503-371a-4a21-ec7f-08dbfc4b4873
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 02:20:47.1020
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CYWa6tDUT6VcMkSt+a53wa+Kv9FgDKP8Qt+1p0vmvoEcbwObE4WZBZk4jEdGtGM+a1jwRK9rRx0C+bcqBk552Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7775

> From: Brian Norris <briannorris@chromium.org>
> Sent: Thursday, December 14, 2023 10:16 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; linux-wireless@vger.kernel.=
org;
> linux-kernel@vger.kernel.org; kvalo@kernel.org; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM =
IE
> for assoc req.
>
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Fri, Dec 01, 2023 at 10:47:41PM +0000, David Lin wrote:
> > > From: Francesco Dolcini <francesco@dolcini.it>
> > > Sent: Friday, December 1, 2023 6:19 PM
>
> > > On Tue, Nov 28, 2023 at 04:31:07PM +0800, David Lin wrote:
> > > > Remain on channel must be removed after authentication is done.
> > > > Otherwise WMM setting for assoiation request will be removed.
> > >
> > > Same comment as patch 2, this seems a fixup of commit 1, you should
> > > fix that patch, not add a followup fixup commit.
> >
> > So you think patch 1 to 4 should be merged as a single patch? In fact,
> > patch 2 to 4 is issues reported by our QA for patch 1. If you insisted
> > merge all of them, I can do this for patch v8.
>
> In case you didn't get a sufficient answer elsewhere: yes, probably? We d=
on't
> care to see:
>
>   patch 1: introduce feature
>   patch 2: fix bug in patch 1
>   patch 3: fix bug in patch 1 and 2
>   patch 4: ...
>
>
> Just ... actually fix patch 1, and send 1 patch. (Or more, if you have se=
veral
> logical changes. Be sure to read [1].)
>
> In case you're used to GitHub: we don't work like GitHub, where people te=
nd
> to stack a bunch of incremental changes during review, and then the
> changes get squashed together before committing. We expect each patch to
> be a good commit, and that it will get committed as-is.
>
> If we're interested in the history and evolution of your changes, we can =
look
> at the mailing list archives.
>
> Brian

Thanks for your information. In fact Patch v8 is almost ready and it only i=
ncludes two patches: one for client mode and one for AP mode.

David

>
> [1]
> https://docs.ke/
> rnel.org%2Fprocess%2Fsubmitting-patches.html%23separate-your-changes&
> data=3D05%7C02%7Cyu-hao.lin%40nxp.com%7Cc031726831234d8efdf108dbfc4
> aa160%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638381169686
> 467616%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l
> uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dfg0y2
> dg6hCyUyHyDnBQS3PmMQqJD5n1h2lpq0ea9tys%3D&reserved=3D0