Received-SPF: pass (google.com: domain of linux-wireless+bounces-789-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: David Lin <yu-hao.lin@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: Brian Norris <briannorris@chromium.org>, "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kvalo@kernel.org" <kvalo@kernel.org>, Pete
 Hsieh <tsung-hsien.hsieh@nxp.com>, "stable@vger.kernel.org"
	<stable@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2] wifi: mwifiex: fix STA cannot connect to AP
Thread-Topic: [EXT] Re: [PATCH v2] wifi: mwifiex: fix STA cannot connect to AP
Thread-Index: AQHaKjAcb/i+pQpnHEy+2M8UmgtSVbCoEGkAgAADiBCAAFflgIAAQzrA
Date: Thu, 14 Dec 2023 11:38:45 +0000
Message-ID:
 <PA4PR04MB96380AA7B60AFD73491FF53BD18CA@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20231208234127.2251-1-yu-hao.lin@nxp.com>
 <ZXpjjmD5Se7axJju@google.com>
 <PA4PR04MB96383A106724AC1CE683112BD18CA@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <ZXqwP7NscRtE1uGL@francesco-nb.int.toradex.com>
In-Reply-To: <ZXqwP7NscRtE1uGL@francesco-nb.int.toradex.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?BRn0fX+i7bXuK1gUfXUbA3liIVzELld83YiMYcmUuaWE91dCSmiFCqklRxYi?=
 =?us-ascii?Q?b92UdezvnLCHIBAp5fTDeA9TJLdA2sjJ0Q8VRc1DTY0yPB31+oYtFP4RK3RA?=
 =?us-ascii?Q?wv0NKltzIzLXDrwQnwOTNKRLcX5q16yfLysrIH4W+C1Zq04rVumzisgHo+dx?=
 =?us-ascii?Q?eQHnIgYeRxouEbwed5SVARbOBh0nf4LyE30oiMDkUOnZKtf/rHyBLv+hQNLn?=
 =?us-ascii?Q?pfIVrIjfEX/yc3BFF7NrumcuB3tHyonujNSbuyHA/iIS4Eej0JVP4suKKLDD?=
 =?us-ascii?Q?AqljCM5cYa+esc74mPtxCEnht3SmSXDM2JEo2Ul6rL4Nqi/55b/A9MZDMNe4?=
 =?us-ascii?Q?apwyZVVnc6QRTzv6lm9mF2NbqKPNV5vC4dXbu6Zeym4jGzBVlvRSSxM3s/fW?=
 =?us-ascii?Q?hVuV8opT5jLLi4TEfdflaQNGMdnK/ESTl0PjIWsLO3zLR+AhmkA04e76l7k3?=
 =?us-ascii?Q?VzC5hpFldj74csT985gnA7z92sPyOVjE4SchPy0vgh+V7/Akcgy+jz4w9QBz?=
 =?us-ascii?Q?Ua5PTzOczSiOh1b6it/jbtE27XfM76hggxxAOA1b1h1hi6RH2xFVa7pTVqL+?=
 =?us-ascii?Q?K9UKyFOB2ziEPrtw4dKx1NPHOgNgQBxdq0Y/8IcUTbaQSggUSZd43WnWK8ty?=
 =?us-ascii?Q?8i00NgfypAnRgjwLerRxuShrcS/84OZxu4z66i0Zsie3b/AFWJYdUHDrqrBo?=
 =?us-ascii?Q?gLzTVIW8yKHUvpTWW3qMCz7sKA82cJmO/xSqq3/zMj829tf5H1/RGvcpWBKX?=
 =?us-ascii?Q?0PbgJy1WUpeGclKxsByJBJfchn/SNOV++8fMN29cUch9pEzbgv1ZEXdbzoJO?=
 =?us-ascii?Q?xhZiFHDcalQpTDC1zW98TaugYdS81VxyZGxXBl6mjW9JMtL0g0p8pB/dEapn?=
 =?us-ascii?Q?HxIg0FNSfugSfHfnN78PZUlWg6Gv/A+PBpwfoJ+Bmp53Y02n5LCUn3otkJFv?=
 =?us-ascii?Q?7BPBKNcKf6fp9yGjR+krVWK4zHxwWRpp7ilYB0PNiUivyzBOhJqv+Ir+I5Cg?=
 =?us-ascii?Q?3WPqNARdp1rme1ko+MvPsMuSp557jDAi676RSq9aNkZYrgXoV5r1K2qIs7mu?=
 =?us-ascii?Q?Fa50XQciqofjx1vhj5326yAVYchQ7zHU2eSuq/K38MrDkn6ViqNQBHKxJ+F2?=
 =?us-ascii?Q?gLVRFY7/c7+AegATLPKYmOPnSPpimZQVQPkPTjYONFJTEMQSnO3suLJmztzj?=
 =?us-ascii?Q?8WJOEcYANoCSTu936JgIPvPrbbEk3eGWY0SXPVEWnwx9oq/GWVYvKxDV61zY?=
 =?us-ascii?Q?ZtzDO7f8nylTrX3Kp3WwhyvqyHvk4zPEiNUirvEPbhWLSHUu+eE0VRyzynx6?=
 =?us-ascii?Q?CgmuNrN435f7w9nN4Gq/T+MJYt4/FKvYln273KCTqy2Iz5oha8hDqd3HAACH?=
 =?us-ascii?Q?nvf4ia5KafPFmS80tDoOa5gu4tQ2MYFVa5e+zYRbB+PGxRJbIj1N2oZdPTML?=
 =?us-ascii?Q?1Rvlm9dRdNfr7WUx4Mjno1EUPoifLyRILJjZgwuSIpiXD8xmlbo8EvTJkfMb?=
 =?us-ascii?Q?gEhskCD5X6VHCHDMkiE+pQvwtOrop6eb4cj4xg0PdDC500jgmk3XkL7+ndEd?=
 =?us-ascii?Q?2BxwkdkJ1pY3O8ODZEuXWzi3A5z3HW7lluErGjXj?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5770426a-dd88-4bcc-5b15-08dbfc993b44
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 11:38:45.6988
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bFKIfzrY/616/86l9FFiph0MWfvis8XDwAak1qxh8buz+iRWCaYcttJQIagNn8QOXIpzX6n86nAsQeiV2nK60g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7704

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Thursday, December 14, 2023 3:35 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Brian Norris <briannorris@chromium.org>;
> linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; stable@vger.kernel.org
> Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: fix STA cannot connect t=
o AP
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> Hello David,
>=20
> On Thu, Dec 14, 2023 at 02:22:57AM +0000, David Lin wrote:
> > > From: Brian Norris <briannorris@chromium.org>
> ...
> > > Nitpick: "fix STA cannot connect to AP" isn't the best commit
> > > message; that could describe an enormous number of fixes. Maybe
> > > something more like "Configure BSSID consistently when starting AP"?
> >
> > Thanks for your suggestion. I will change commit message as you
> > suggested. Does it mean I should create another patch from v1?
>=20
> Just create `[PATCH v3] wifi: mwifiex: fix STA cannot connect to AP`
>=20
> Add the change suggested by Brian and the tags you received on this v2:
>=20
>  - Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>  - Tested-by: Rafael Beims <rafael.beims@toradex.com> # Verdin iMX8MP /
> SD8997 SD
>  - Acked-by: Brian Norris <briannorris@chromium.org>
>=20

O.K. Thanks.

> > > Not directly related to this patch, but while you're expanding the
> > > size of this command buffer: it always felt like a
> > > security-hole-in-waiting that none of these command producers do any
> kinds of bounds checking.
> > > We're just "lucky" that these function only generate contents of
> > > ~100 bytes at max, while MWIFIEX_SIZE_OF_CMD_BUFFER=3D2048. But, just
> > > add a few more user-space controlled TLV params, and boom, we'll
> > > have ourselves a nice little CVE.
> > >
> > > It probably wouldn't hurt to significantly write much of this
> > > driver, but at a minimum, we could probably use a few checks like thi=
s:
> > >
> > >         cmd_size +=3D sizeof(struct host_cmd_tlv_mac_addr);
> > >         if (cmd_size > MWIFIEX_SIZE_OF_CMD_BUFFER)
> > >                 return -1;
> > >         // Only touch tlv *after* the bounds check.
> > >
> > > That doesn't need to block this patch, of course.
> > >
> > > Brian
> > >
> >
> > I will modify the code for next patch.
>=20
> I would suggest not modify this in this patch, we should fix all the code=
 that
> is subjected to this potential issue.
>=20
> I would personally do a follow-up patch just to add the check to avoid
> overflowing the cmd buffer everywhere it is used.
>=20
> Francesco


O.K. I will only change commit message. In fact, this TLV command is added =
as the first one command.