Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6059698rdb; Thu, 14 Dec 2023 07:21:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IELPjEnwOjNCCBbDnbMgHX4aqiztzobgw3IpnAX73Cl64hPwsiSWUtIfGb5orK1YtiRvQLG X-Received: by 2002:a05:6a20:7344:b0:186:de7:e803 with SMTP id v4-20020a056a20734400b001860de7e803mr6210598pzc.53.1702567290156; Thu, 14 Dec 2023 07:21:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702567290; cv=none; d=google.com; s=arc-20160816; b=SJNUMouMAqN2NBaqNQvc9JeC7kyfcRh01n5SZ9fZv929lZzMaridGqaHyomzo2PGi2 hBMEK4DQMrBH4ObYCh6zvqoBXJB9+17+tCPq4zoYnPI9K9/wg7XPEaRQY6A5yww0YDfb Vs4GLJV7gw5+DKYdmLGeKd1MrpDrDs4ZRT6v4XiRgH+SFzSa62jVoTuYo4RhLZH7TOb2 12I5XtMLu12nrvvtTg5h8xHKmJDTKeqvynGDCvLg2GYQgY+0/jXw66n66pF+d/hJorvV q1R5YhQmD5zAAuxq3Zadf0cDFRCaLOMuNIXUTxGNuB+v1MIcWirrk/r+jLqZppWo02RV ulJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=jo3YGN2wzRBUBERtmt498R+zQNaBT81vstNT133eb04=; fh=IxgvRNpKG8FWcoJerC1OC5rB80mfw0+edpsV+xglmEY=; b=yYhnVcPu/T5TgXgQFOATuWTMkGiNu49tF0UkxPvyhn2VFL43aZEo1Y4fvM3ijebCiY 3k8y9aoanwfsp/YJwKlhUlwGzG14KZR3q2nwtY+bPlpBKST2WIY7e7edrl9ZErZk0QFq lT9MrFM1NF2EiqpBdAP68uISJSCBUAAq+juPgr0FYVMFHosy8Vs0+pdm6BZFU1eypnf3 LuCAro3tENHpQLbYfQWIBoewwYTGe/2cekqu1tXcLP3+tLYqxPWs+6QmJJNfUQxVW03+ 6rgzjQbUacG/OE6r9YvIZm9xUyuFOjpkepRPqBxeC9ii5HAtu1SJjGzkf7lIM/DDGBko zvEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=gChCwOIS; spf=pass (google.com: domain of linux-wireless+bounces-801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-801-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c23-20020a63d517000000b00577e00c5ffasi11504005pgg.867.2023.12.14.07.21.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 07:21:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=gChCwOIS; spf=pass (google.com: domain of linux-wireless+bounces-801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-801-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CFDC2281D65 for ; Thu, 14 Dec 2023 15:21:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 998585C909; Thu, 14 Dec 2023 15:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="gChCwOIS" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08815126 for ; Thu, 14 Dec 2023 07:21:24 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BEC9hYR018841; Thu, 14 Dec 2023 15:21:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=jo3YGN2wzRBUBERtmt498R+zQNaBT81vstNT133eb04=; b=gC hCwOIS7wuVdOIh0zlEWEPSczD6jR8vd2cBBFOeCk7dclZKmEFaA7ipLovjUZsS21 ehUwM0V4Rc2fmumdWf9TgHf+YIXILhh5NsKkWooYkuYwF9A3GhfEat3eunGq7PVh uuNfpZdis340JvbZoeBM1fsXpfr7z6eQWQjSTpcq4ybT0kGmd9O4JnFVDXUaRpO2 eVjZJ1sWYA54kIoTfFwDJMaPQdEyFUhh8DSnsRSFV4HSmh10/m0NJAntorcbBKvS T5mPn8fNOuXctt90m/iZwPX4McqHSqPcxWBH/h2WniErgonxkLJdN0u8/Rfn+8qv 1RQZLobSya+WMdpuyDiw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uysrpsctu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 15:21:19 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BEFLIha030564 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 15:21:18 GMT Received: from [10.110.36.237] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 14 Dec 2023 07:21:18 -0800 Message-ID: Date: Thu, 14 Dec 2023 07:21:17 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "wifi: ath12k: use ATH12K_PCI_IRQ_DP_OFFSET for DP IRQ" Content-Language: en-US To: Karthikeyan Periyasamy , CC: , References: <20231214053215.2087308-1-quic_periyasa@quicinc.com> From: Jeff Johnson In-Reply-To: <20231214053215.2087308-1-quic_periyasa@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Y69y6GJpB0Z93GqwrkAbMJ1hg1YsoNMo X-Proofpoint-GUID: Y69y6GJpB0Z93GqwrkAbMJ1hg1YsoNMo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312140107 On 12/13/2023 9:32 PM, Karthikeyan Periyasamy wrote: > This reverts commit 1f1f7d548a00ebe50808cb1f580df9693e194a7c. The commit > caused bootup failure on QCN9274 hw2.0 platform. Incorrect hardcode DP > irq offset overwrite the CE irq, which caused the driver to miss the > mandatory bootup message from the firmware through the CE interrupt. This > occurs because the CE count differs between platforms. The revert has no > impact since the original change was based on an incorrect assumption. > > Log: > > ath12k_pci 0000:06:00.0: fw_version 0x1011001d fw_build_timestamp 2022-12-02 01:16 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > ath12k_pci 0000:06:00.0: failed to receive control response completion, polling.. > ath12k_pci 0000:06:00.0: Service connect timeout > ath12k_pci 0000:06:00.0: failed to connect to HTT: -110 > ath12k_pci 0000:06:00.0: failed to start core: -110 > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Karthikeyan Periyasamy Acked-by: Jeff Johnson