Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6115435rdb; Thu, 14 Dec 2023 08:40:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFgLDoK7lU7d5AZ4alem1VJ2wCiCgCwIyttRE3i5uJcYnsAliW9wEgY+pNk3Zl4QZIxvUC X-Received: by 2002:a05:6870:8901:b0:203:4e2:21e3 with SMTP id i1-20020a056870890100b0020304e221e3mr3305175oao.5.1702572051494; Thu, 14 Dec 2023 08:40:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702572051; cv=none; d=google.com; s=arc-20160816; b=DHz8HHTVgLEvZ27xndtbqWS1SBBvH63AQSGeeV9dONScpWkmQFY0+X+IxDqlqkovc8 wjEhDzvj5p9Hjy2ygPyj6FgWnkz1/ZZcFTaBov/R2DUH2vmJV/WhnEHoSUmAI+MQldiy cwtJj2NBmpLXE9MIcoItrwpLTUdErujVWoj5sOAwn9Wh6mKStDne0f04Hf1ZceKMHLoL wKVnUOYzxo+BKMkzYpROQ9Lusy6Rv62sWYm88YM8e6R9RDlgkpyP6QtjFe9gwc4dzLMm 1x9SS9eh1lE5tM3FCt4wk7PWutkS4D/AdXjZQKx5HOpbKgu5stGRIMtIgnzXZLLu/D8O omEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=inz7hgruWKT/m0gVs399XfijN1O1Msuzz1I4VVSggLA=; fh=2zkGCGfEjT4uIJnqb9sstY/pd3iBk163rhUGmr28RJ4=; b=fj4rXclGaxja1G8Agcdr3WDTrzx2r3QCmIPGZxfxTDSBWvJgrCabovDbw6tbfvcGSC Y2jcoLA1wy/VkKoslqnZ//959dYAjZsCZk7MFjRbOXLserPLMPLK1AkQ+uoUUjXAaHbf D1dgET/JnibZc79O85k4Gu4H/SXx+x85YMXTzbqFaE4MMyFbtSlHIrzFIdbT4Y5o3vd8 Cxr26qQ/tFVqUaK+v3iioLB5clnhOzda1bJ5EMHAg1Q2yxdG+83gKeHCRUNO40bcjQIc hdnxpkOWjfhi5YdjgsiUP/yAQiQinU7sog0OZxmyjSoFqPrq+QPt5Znt7hfrajq9wbif Bnxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WTv3fVXj; spf=pass (google.com: domain of linux-wireless+bounces-805-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-805-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bx9-20020a05622a090900b004237c5fa00csi16148320qtb.329.2023.12.14.08.40.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:40:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-805-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WTv3fVXj; spf=pass (google.com: domain of linux-wireless+bounces-805-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-805-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3EBDE1C20C34 for ; Thu, 14 Dec 2023 16:40:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD10160BA9; Thu, 14 Dec 2023 16:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WTv3fVXj" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D97D60BA6 for ; Thu, 14 Dec 2023 16:40:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34495C433C8; Thu, 14 Dec 2023 16:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702572043; bh=7q4xziHGQZPDQMbjsW2etL7QNNmAAzU2B1pJxrK6e9U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WTv3fVXjIgFvGu1uedym2kbxmcukkRvuBgsdXQTg1ZeOWfiQM6AnWogT8AtbWMdXW 1W/bqxkYc+ixqbsVPUjPPMG88tKGOcK02WhUqzuvU9BVCrQWdw/NU1lExdMim2WrqW eIF91R+a2Lba91Mm3ERSN4DM6yuomlcNjZyvYy/LuHFwq7E4eGcGGZuGSTWLYqI+At u8iGMqVCugdDaR5L1bE8KlBUrEz7oAZF+l4GTLmn7p8F76MO4eftL5SCsHE7pJH4CD AYvZBKveayrKsGFXMyoWJxzjvzl8Cd2HHeAyim7VNMjUpeTBNfhWgIk3Qd2qeEkyNU CkUA0zweHLYNg== From: Kalle Valo To: Dmitry Antipov Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH] wifi: ath11k: refactor ath11k_wmi_tlv_parse_alloc() References: <20231214161117.75145-1-dmantipov@yandex.ru> Date: Thu, 14 Dec 2023 18:40:38 +0200 In-Reply-To: <20231214161117.75145-1-dmantipov@yandex.ru> (Dmitry Antipov's message of "Thu, 14 Dec 2023 19:11:14 +0300") Message-ID: <87fs04n3eh.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Antipov writes: > Since 'ath11k_wmi_tlv_parse_alloc()' always operates on > 'skb->data, skb->len' tuple, it may be simplified to pass > the only 'skb' argument instead (which also implies > refactoring of 'ath11k_pull_bcn_tx_status_ev()' and > 'ath11k_pull_chan_info_ev()' in the same way). Compile > tested only. > > Signed-off-by: Dmitry Antipov > --- > drivers/net/wireless/ath/ath11k/testmode.c | 2 +- > drivers/net/wireless/ath/ath11k/wmi.c | 73 +++++++++++----------- > drivers/net/wireless/ath/ath11k/wmi.h | 4 +- > 3 files changed, 39 insertions(+), 40 deletions(-) Please Cc ath11k list for all ath11k patches, added it now. No need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches