Received-SPF: pass (google.com: domain of linux-wireless+bounces-820-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: David Lin <yu-hao.lin@nxp.com>
To: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	briannorris@chromium.org,
	kvalo@kernel.org,
	francesco@dolcini.it,
	tsung-hsien.hsieh@nxp.com,
	David Lin <yu-hao.lin@nxp.com>,
	stable@vger.kernel.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Rafael Beims <rafael.beims@toradex.com>
Subject: [PATCH v3] wifi: mwifiex: configure BSSID consistently when starting AP
Date: Fri, 15 Dec 2023 08:51:18 +0800
Message-Id: <20231215005118.17031-1-yu-hao.lin@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?us-ascii?Q?8/bUv8rgDpVHAnfiEzzZVzRlnDO5ovMKhlzyhp/VmnZLqn3ojQPUd79zjEt4?=
 =?us-ascii?Q?VsmxZagzTax78ijjZF3ewUXuVGGIUZG05M3yUB0txI+RvQgTGKryrjZsyBay?=
 =?us-ascii?Q?p9EmGPJNhz8uiMt6mRlFkdW8XIGKuZemzRzk/E0hMSMWcv59burTAmdiO74C?=
 =?us-ascii?Q?vnx244rR7YPtC2/CGGRAZlFQ0/FTHEjwwNIxtp0B6dJVal2v0AA793PgjDkS?=
 =?us-ascii?Q?PsOv4Fxdg++C2qHMH3sEcx14JGQewkr/L5em6B6G9MxFqurueGg471BGQcB3?=
 =?us-ascii?Q?JavHuVVwJJh3daRVPi+yk59H4YxwPhQalZOwWNPcYnxjud7CIyyCt1SH/pF/?=
 =?us-ascii?Q?Qsc+oZtdudhv2XNJydybABqmOM+Jz2f79JwtMQZTNYrW2GmplfeXCoGrlLBG?=
 =?us-ascii?Q?dGwOmFPx+Wb4Lh+ZeM0kDTzdT03b41TGKoLwayh2BFhl4qlPqcExffVt5375?=
 =?us-ascii?Q?cWmyzka4tqsVPFYp+D5yC5ZGc3hFLNrkHstLFTmUGF74QpFcwxyom7yEUfi9?=
 =?us-ascii?Q?Mf2mY189D4CUkoi4jn0+pvnd4HKCjMc2qweVcoXxg8NxWZsqxVMyPvi1AZ/t?=
 =?us-ascii?Q?GNnE5/WydjPPiPVEicol2LxPtkwwspg18EARF7BiVaKNgapK28pv7K5xiwYW?=
 =?us-ascii?Q?K/52lBwALQwFZatBI6hi8XnWE4Ujb53nBYyyslmUU1Qe+VAr8vbi/8BhVfN4?=
 =?us-ascii?Q?lzdXY32hAe+FIaq3x6V5w3JgoRwYMEX1I/qxrgeeTvZJGYOqxBXAQIryZGUF?=
 =?us-ascii?Q?SdIevc3aeh5EGRkkgeZWr4FxKjPyBhoi010zcFxUjXiHO4/HfnYe3cjYqp0P?=
 =?us-ascii?Q?sBTx+pEUDQDst8KI5PpKXLuo7VsQB5oKilR/UG7h90UaNf94lbkLqj29aBeb?=
 =?us-ascii?Q?36MT/kmqwGNmIt1NR3QXESSmzriisrANkUtc1El5xrZ+gQGxdIrAJ4nYHwGH?=
 =?us-ascii?Q?GnFarJ3mS13KIgWy5HgvO7aWKZhFy6OAlqAPDYjYk0f3vE+i2NjMBWAVR4Ze?=
 =?us-ascii?Q?+Em+aFt1APJXxx1eLYFL27Px4mO48sFtNQ9riMaak/RWxzaE/eB0AZoEaUmi?=
 =?us-ascii?Q?2U6rEwt6lz0n1r34CrvTly5mLXqEOgciA0+ooJ9NQlaie15aNts9o6y5sMrP?=
 =?us-ascii?Q?9ypdXAqjOYssZIxUm4f7zkYS0fU5xYnmIFlc3PKX7FxiVfDbv3jKThGk7AA2?=
 =?us-ascii?Q?dtLxZMb3pDhYgeh62nrHcmBgmJjiKP3dM9m0LgP+w1T5W7sCCBbRPXf+FkNS?=
 =?us-ascii?Q?+gLk356IO0/LiU2VQKC3dt454yF85/ovxLRy259O5qjv32Zrd+ZyF+VGj5p7?=
 =?us-ascii?Q?gBUmjyXg17uylvkQYnuoTzn+2uWXirQgjRM80JwvEr6U7AgBH1CjGfzPsyDO?=
 =?us-ascii?Q?byIok/Ynfy+O8LNqgSnXQgsrH6OEI66ivvvCxs1uaXeeYlq8kvwPoAAuusz7?=
 =?us-ascii?Q?5BCxF0/0I+xoT2fzRG1CTyQNoT9kyDMHPHZsQ06/6jd90bHqV0t4XR0Ai16O?=
 =?us-ascii?Q?8CX5CT1kkOiussSds7aAbGu6g0FEUdUOWVlMsJuINLKoytbEvtyzqlteS4e4?=
 =?us-ascii?Q?EZrqzFny3XqWhOVKQjxHRNEiuYxR7Ehna8FLsRW9aB5hEzrA7nmepnV3VCLa?=
 =?us-ascii?Q?hvBx95n2y8+be1vroyWzsiliAGlta7Gxte08e0FW1+lI?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81bb39ab-956c-4938-c58e-08dbfd080edf
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 00:52:05.5517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G2NXeVyV9DaCzYFxg3CSPYEIjMjM+H9M2qnjILvb4KUCoMNksSHjSrlnmpdVssXxHxLScCHVSOII4iY7mMT4pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8176

AP BSSID configuration is missing at AP start.
Without this fix, FW returns STA interface MAC address after first init.
When hostapd restarts, it gets MAC address from netdev before driver
sets STA MAC to netdev again. Now MAC address between hostapd and net
interface are different causes STA cannot connect to AP.
After that MAC address of uap0 mlan0 become the same. And issue
disappears after following hostapd restart (another issue is AP/STA MAC
address become the same).
This patch fixes the issue cleanly.

Signed-off-by: David Lin <yu-hao.lin@nxp.com>
Fixes: 12190c5d80bd ("mwifiex: add cfg80211 start_ap and stop_ap handlers")
Cc: stable@vger.kernel.org
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Tested-by: Rafael Beims <rafael.beims@toradex.com> # Verdin iMX8MP/SD8997 SD
Acked-by: Brian Norris <briannorris@chromium.org>

---

v3:
   - patch title change from "wifi: mwifiex: fix STA cannot connect to AP"
     to "wifi: mwifiex: configure BSSID consistently when starting AP".

v2:
   - v1 was a not finished patch that was send to the LKML by mistake.
---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 ++
 drivers/net/wireless/marvell/mwifiex/fw.h       | 1 +
 drivers/net/wireless/marvell/mwifiex/ioctl.h    | 1 +
 drivers/net/wireless/marvell/mwifiex/uap_cmd.c  | 8 ++++++++
 4 files changed, 12 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 7a15ea8072e6..3604abcbcff9 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -2047,6 +2047,8 @@ static int mwifiex_cfg80211_start_ap(struct wiphy *wiphy,
 
 	mwifiex_set_sys_config_invalid_data(bss_cfg);
 
+	memcpy(bss_cfg->mac_addr, priv->curr_addr, ETH_ALEN);
+
 	if (params->beacon_interval)
 		bss_cfg->beacon_period = params->beacon_interval;
 	if (params->dtim_period)
diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
index 8e6db904e5b2..62f3c9a52a1d 100644
--- a/drivers/net/wireless/marvell/mwifiex/fw.h
+++ b/drivers/net/wireless/marvell/mwifiex/fw.h
@@ -165,6 +165,7 @@ enum MWIFIEX_802_11_PRIVACY_FILTER {
 #define TLV_TYPE_STA_MAC_ADDR       (PROPRIETARY_TLV_BASE_ID + 32)
 #define TLV_TYPE_BSSID              (PROPRIETARY_TLV_BASE_ID + 35)
 #define TLV_TYPE_CHANNELBANDLIST    (PROPRIETARY_TLV_BASE_ID + 42)
+#define TLV_TYPE_UAP_MAC_ADDRESS    (PROPRIETARY_TLV_BASE_ID + 43)
 #define TLV_TYPE_UAP_BEACON_PERIOD  (PROPRIETARY_TLV_BASE_ID + 44)
 #define TLV_TYPE_UAP_DTIM_PERIOD    (PROPRIETARY_TLV_BASE_ID + 45)
 #define TLV_TYPE_UAP_BCAST_SSID     (PROPRIETARY_TLV_BASE_ID + 48)
diff --git a/drivers/net/wireless/marvell/mwifiex/ioctl.h b/drivers/net/wireless/marvell/mwifiex/ioctl.h
index 091e7ca79376..e8825f302de8 100644
--- a/drivers/net/wireless/marvell/mwifiex/ioctl.h
+++ b/drivers/net/wireless/marvell/mwifiex/ioctl.h
@@ -107,6 +107,7 @@ struct mwifiex_uap_bss_param {
 	u8 qos_info;
 	u8 power_constraint;
 	struct mwifiex_types_wmm_info wmm_info;
+	u8 mac_addr[ETH_ALEN];
 };
 
 enum {
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
index e78a201cd150..491e36611909 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
@@ -468,6 +468,7 @@ void mwifiex_config_uap_11d(struct mwifiex_private *priv,
 static int
 mwifiex_uap_bss_param_prepare(u8 *tlv, void *cmd_buf, u16 *param_size)
 {
+	struct host_cmd_tlv_mac_addr *mac_tlv;
 	struct host_cmd_tlv_dtim_period *dtim_period;
 	struct host_cmd_tlv_beacon_period *beacon_period;
 	struct host_cmd_tlv_ssid *ssid;
@@ -487,6 +488,13 @@ mwifiex_uap_bss_param_prepare(u8 *tlv, void *cmd_buf, u16 *param_size)
 	int i;
 	u16 cmd_size = *param_size;
 
+	mac_tlv = (struct host_cmd_tlv_mac_addr *)tlv;
+	mac_tlv->header.type = cpu_to_le16(TLV_TYPE_UAP_MAC_ADDRESS);
+	mac_tlv->header.len = cpu_to_le16(ETH_ALEN);
+	memcpy(mac_tlv->mac_addr, bss_cfg->mac_addr, ETH_ALEN);
+	cmd_size += sizeof(struct host_cmd_tlv_mac_addr);
+	tlv += sizeof(struct host_cmd_tlv_mac_addr);
+
 	if (bss_cfg->ssid.ssid_len) {
 		ssid = (struct host_cmd_tlv_ssid *)tlv;
 		ssid->header.type = cpu_to_le16(TLV_TYPE_UAP_SSID);

base-commit: 783004b6dbda2cfe9a552a4cc9c1d168a2068f6c
-- 
2.25.1