Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6669950rdb; Fri, 15 Dec 2023 05:25:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGAsfxbg8LmlPnGKabqRIJTNQcQRwIOKqgEFJZ9EOUYs1AX6KDTaOKx4rTSuoXkRgtgUTF X-Received: by 2002:a2e:a789:0:b0:2cc:3f55:a4be with SMTP id c9-20020a2ea789000000b002cc3f55a4bemr2368455ljf.53.1702646748629; Fri, 15 Dec 2023 05:25:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702646748; cv=none; d=google.com; s=arc-20160816; b=UwfuLByiXRF3kRd/lKsOYfEr45o5/dFIrE7kIpfskj96NcBI1x9mn1plb57EHtNnaR 2R+SVDzmHkRbgJ2lewj1lsKjCuzipSQiKSdPqbd2+C0UapbHL0VPvV5Jrj+zcFd4Djg2 9vlJA28ej10knwqzjIFV7NgFUik9fU1kodKJNErW8gZkTiMKAFumI9p9yc1/b+BcrGHM 27B/6tU2fIPYxFdWYXB7PzE5GQtFEvjA+BSe+9OWd53hr9z7gN7zrtXUixioavCzAUVH YOUB3Lkp7E5K3KnTy+tv1ZUKo3iGDiPhUVsRXDdC03z/PKOpahCzg0PBOMeiouvdIQ0T WCVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=ARKPMELK17awQbm6IUsifotpVoTvjFddUxm3NtQvhN0=; fh=mdMxdmDBjQIgJexwX6Iqr42fsEVHSTpj+Fy8yUJjRtc=; b=HNP3WB1Dn0ahWkLGtPZ21y4b//5E8YTC6MRa5uaSikQQ3ONQ3wufL9dmHdUwVNeosL qObL4BEq5m0sSYny+Ei5ngYamf6Gqpg6nIk9cr8Y+SAb4wcSnx1pCRWZ0mzcqYoZ0v8i 4/W2VRs4nbqU+1Q3KBa8phmes2+Sx/psQnc4/Gy7puSpXPiFmdXlnNuCFOe75yGUWkAh jmGT49izVdHaWZS30ExSyJixzeAUfIZ46y2z732C67HeeGJFyv1AG0p5+eE4zUkZzhde S7eo/jATTtxcNWq61/VD3Pq9yQbwJBzV6CqTlAIFcOZh0P/q/lKhJHpuhJdtnt1WAytM z94Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LawAyRwb; spf=pass (google.com: domain of linux-wireless+bounces-835-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-835-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id j17-20020a05640211d100b005525fbdec31si1828654edw.85.2023.12.15.05.25.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 05:25:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-835-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LawAyRwb; spf=pass (google.com: domain of linux-wireless+bounces-835-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-835-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 627921F2103D for ; Fri, 15 Dec 2023 13:25:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E156C2DB7F; Fri, 15 Dec 2023 13:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LawAyRwb" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8022E416; Fri, 15 Dec 2023 13:25:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3086AC433C8; Fri, 15 Dec 2023 13:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702646702; bh=B5mkdMwDaQnB5bTZYj5vwz6563xv3c52j7DWyphB6cs=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=LawAyRwbtZyiJinItWdg5oqA+kTvzO/zDaHNJlTc2h3afd9+46Mc3U1lhG3esm6Ju mVUKEN/6aWhESjTIytVCyFK5FrRHhowwfbiZUC8E4+P4yn7pVgzziNPvyXQtiU/cs7 7ts539n6An9ir5y5jObk8x2tm6WwSxvy4OwKCjQeKRQhKh+x5OTdmpntrntBQoMABU ETAHDbbdiEF1JLngVJnkSz/cKAPJItYWOEP1+Sv1fL3qwWVcO97svD+PESMsdj0PHu bRjS1NiVKJE2lVPrypIm0jKIxwMfleDx7zH3cBX2S/4fdXZwc7H/L3hdkPPzZBR1C9 hkRFdQZo8drPw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v3] wifi: mwifiex: configure BSSID consistently when starting AP From: Kalle Valo In-Reply-To: <20231215005118.17031-1-yu-hao.lin@nxp.com> References: <20231215005118.17031-1-yu-hao.lin@nxp.com> To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com, David Lin , stable@vger.kernel.org, Francesco Dolcini , Rafael Beims User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170264669803.1759617.3948805099666949892.kvalo@kernel.org> Date: Fri, 15 Dec 2023 13:25:00 +0000 (UTC) David Lin wrote: > AP BSSID configuration is missing at AP start. Without this fix, FW returns > STA interface MAC address after first init. When hostapd restarts, it gets MAC > address from netdev before driver sets STA MAC to netdev again. Now MAC address > between hostapd and net interface are different causes STA cannot connect to > AP. After that MAC address of uap0 mlan0 become the same. And issue disappears > after following hostapd restart (another issue is AP/STA MAC address become the > same). > > This patch fixes the issue cleanly. > > Signed-off-by: David Lin > Fixes: 12190c5d80bd ("mwifiex: add cfg80211 start_ap and stop_ap handlers") > Cc: stable@vger.kernel.org > Reviewed-by: Francesco Dolcini > Tested-by: Rafael Beims # Verdin iMX8MP/SD8997 SD > Acked-by: Brian Norris Patch applied to wireless-next.git, thanks. f0dd488e11e7 wifi: mwifiex: configure BSSID consistently when starting AP -- https://patchwork.kernel.org/project/linux-wireless/patch/20231215005118.17031-1-yu-hao.lin@nxp.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches