Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6678618rdb; Fri, 15 Dec 2023 05:40:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgoU7zgrcse9hJGtg7pEaNtwBqETATzKgFcU0fT0HWXqrUPAXHq4kq+MaLrmvxg1GKwpKG X-Received: by 2002:a05:6102:b13:b0:464:9074:f6fa with SMTP id b19-20020a0561020b1300b004649074f6famr10974341vst.12.1702647646157; Fri, 15 Dec 2023 05:40:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702647646; cv=none; d=google.com; s=arc-20160816; b=KW0RcIOxeHsqRJdJbW82kwKdFbklvczyzvLpm/BSor57BEw543QIfao80gHg+TvWkm dZEXS0YoJ91ptcMhiSLsavwjVzdy9rVrr01p3Eh1j3zbL0K484mambf9JnpQ1CR4l+uH Y5p2e9/UB44dK/YMIKzFLn2jddQucKmnEPb7vFeQbzXbIZOhGg8Ci577yUjxxnezwGtc 02C6AbDUkuttJUQ2nCZYYDWLSZ0+p6vaoKFqzPNRLsHAbK3l30raCoLJrpJBvDqzWc5X XR5OyEtm9e6/NCP2QkRgJYToySAsH7RXah5X0lWmxIelL5irAHf1AmnpktoQ+5pRIMZg K2JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=NqEG+kXXZdb4PQdfmizHjswsWffI77WCfM9QeV+lwfA=; fh=KNByskz0BEMSELJIHxq/bpn198O+eBxxlMxwAyir1kM=; b=Vml/9I3xXSNNuRNymDQRJ6jch146Jzl7cZaHNiR+SqiOumI19u8xRWvOOCmYHIxzvV GKm54YTfxA+mX6+8vJlXP9BuwiK5ArXD0WIcnX6eKvbeC7GuTKxRFlLTEVfcKTfgGje6 ugAEz/0YlozkxNG99ZmnsJTPJSdNlhkY6KeBxMuPsJj+LHUl+9NgljwYGrdbJFvCIwIL uqXSU+MM9EYQgDZQm40zP4jDXITgatzA4iIGElqdj0zKFIpmBg62iDqP5ZSd6FH4uH1N EVEPSlRSwtbmxOiq2dPFcj/mZ4+Gd1DFgUc+49A4mQznSq/83FbwDLi15PC+2fd1l+0D VSlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IGGCUMWw; spf=pass (google.com: domain of linux-wireless+bounces-839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-839-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m27-20020a056102053b00b004647e240de2si2992527vsa.154.2023.12.15.05.40.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 05:40:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IGGCUMWw; spf=pass (google.com: domain of linux-wireless+bounces-839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-839-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C7A2E1C23384 for ; Fri, 15 Dec 2023 13:40:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D64092DB8B; Fri, 15 Dec 2023 13:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IGGCUMWw" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3972D7B7 for ; Fri, 15 Dec 2023 13:40:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B684C433C8; Fri, 15 Dec 2023 13:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702647642; bh=rGXhACWnvWZKELA2A2+uXVV/y/a4lDqndImovMajIqA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=IGGCUMWw0MiteM/Qd4XVfmdoWtFM+Ez1qXnkI4w7oXx4QqTIrN2bsTxYzHwU5T8r4 oR98S8bvZOLhc3ZISvZvEyjCcenIO5XXZD1p2NlgrfgV2SfzD/tjcOO7ECL2Ogxvv3 B02+m34IHw+jeWXOE7YeF5iWs2KfiBKLxdeT+scUJKCUgBOU4QGvLXnfFTbHmBEyGj vkBzjQKgcVJzD5lzn3Zsxt7zzC3bI8eey7ZfHgOmKaDIjsadedlDIf4xHIBppXuTVj q4wUc+zSFRBxOm29Qmvd1I2HRj+K4G7TrQEvTtLczbOD3UF8RS6lEUO2MvqSdI4vuu 0jZYjWUvsPBTQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] [v2] wifi: rt2x00: remove useless code in rt2x00queue_create_tx_descriptor() From: Kalle Valo In-Reply-To: <20231213051449.126963-1-dmantipov@yandex.ru> References: <20231213051449.126963-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Stanislaw Gruszka , lvc-project@linuxtesting.org, linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170264763943.1759617.7972468780385237703.kvalo@kernel.org> Date: Fri, 15 Dec 2023 13:40:40 +0000 (UTC) Dmitry Antipov wrote: > In 'rt2x00queue_create_tx_descriptor()', there is no need to call > 'ieee80211_get_rts_cts_rate()' while checking for RTS/CTS frame > since this function returns NULL or pointer to internal bitrate > table entry, and the return value is not actually used. Compile > tested only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov > Acked-by: Stanislaw Gruszka Patch applied to wireless-next.git, thanks. 5a1745807580 wifi: rt2x00: remove useless code in rt2x00queue_create_tx_descriptor() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231213051449.126963-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches