Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6771036rdb; Fri, 15 Dec 2023 07:59:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlEEV39z5FwjNDOIUkiDOmbyOOMF3isb4ii+6uien3knBcIla1Toe2HuE1BXTR5m8lk7cy X-Received: by 2002:a05:6a20:12c5:b0:18f:cc3c:be54 with SMTP id v5-20020a056a2012c500b0018fcc3cbe54mr7521965pzg.16.1702655960589; Fri, 15 Dec 2023 07:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702655960; cv=none; d=google.com; s=arc-20160816; b=XcRr3b+E2NxiBsH/ilvPZg/d2bfGk0IJ+hETvyFpSFYmyh4GzXtxdknsltTBJiYTzB PFkkv7U/0cPI7BkLVDTXvu0Z4wbemMO/KsvXEsECqcCmGqbPazuPEPGiVNQpo49AdEWe 5F8csBWj/ONueVOg1rBeYRRx5s7k7/a/TggDm5xoJ5U50fLmJx5WHcWheKDA/wd+ZuSl fqmyU3RyB9h5Xm9Apk4/gnn5pi3vn3loia++akHSGlYhRg+NnEHcZtYUlRL0MV67e31J 80aP57Y9gST15BRNc67SBvJNNErvZj/0FUlfqcRbZs+yTtRTFkb70WkzRUgu7ysWWXNe RUgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=1jA7kr4VhjG0pv0BPt4d10eeQToLYzy58gQ2rjyi0wY=; fh=zLVo77eW1dcO3ZoPVZkz0WBqBvPCOzSbzBFLHpxu4xg=; b=YfwGFNJbGnFVLm/0LpQNZSWvVRhpYm1xkabUOhqNM3eIyA8KCexk+OI4CvXjog2Qj9 fNSnWfKTu5EpKSJyHXOz0FAbI89n0JqBpLWrDOtqNjv8n8X0hvJCfZthnTiaFH8rFvTn eSgfztQa+9eOG9AH9SXUjms0x+ymKtAZm/WbZSPFW8A2K+/LF9jM6cwfaOv/rjsYyyHZ ygjBn9a2RzcnJyYLHFibEEY140lmsZdPxumDTrb1I2VGEejZUrH0OV0c8Nm2CMgAzDrh DqE4vQFcOpEU8jsAdeLkAVDw8HR5CEjqH40dnwbjP8099xT0Wiiup7ByXDyXNFMCGN9Q w0rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TRnyJeQ0; spf=pass (google.com: domain of linux-wireless+bounces-843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-843-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s6-20020a62e706000000b006cd853221easi13093985pfh.362.2023.12.15.07.59.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 07:59:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TRnyJeQ0; spf=pass (google.com: domain of linux-wireless+bounces-843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-843-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 091F9283B74 for ; Fri, 15 Dec 2023 15:59:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA6573A8EB; Fri, 15 Dec 2023 15:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TRnyJeQ0" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6F03A8E9 for ; Fri, 15 Dec 2023 15:59:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BF6EC433C8; Fri, 15 Dec 2023 15:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702655943; bh=GhGX6p5fY5yn/kiJvEGNAHpMjIe44xbBAOgiPpDCRdg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=TRnyJeQ0lT7YobcnukUhEnB5maG3BUEl8ROLNCmhuEGPHTP0E3/a6vY3wSUffKwd6 m3WNlSDnpwS0CLENNjWbWK2kDWfkE0OoAeZEH0TvNGg04h4IdBkkCZGkafehIkXeDn OTmjs7hDJ8xNugW4rMDwDj29EFJlcNb48N4m2p0H51CaFUZ9MFmi+6LeqHJoP74VYo NT9vL3z/FT0+5kf/CXE0KdSoDNKgY1UyCLgH27jLh1gXbNkRUzyN+JHkzaMGHpa7p7 IeQonlmKKvWpoCRBanB7MMm+bitAMaCYH93RViT3aHvM2phb0wAjvOTO85STEfuJbm 0ZcOvYLwcwVuA== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: workaround too long expansion sparse warnings From: Kalle Valo In-Reply-To: <20231214161740.1582340-1-kvalo@kernel.org> References: <20231214161740.1582340-1-kvalo@kernel.org> To: Kalle Valo Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170265593947.1834402.14524206742930296560.kvalo@kernel.org> Date: Fri, 15 Dec 2023 15:59:02 +0000 (UTC) Kalle Valo wrote: > In v6.7-rc1 sparse warns: > > drivers/net/wireless/ath/ath11k/mac.c:4702:15: error: too long token expansion > drivers/net/wireless/ath/ath11k/mac.c:4702:15: error: too long token expansion > drivers/net/wireless/ath/ath11k/mac.c:8393:23: error: too long token expansion > drivers/net/wireless/ath/ath11k/mac.c:8393:23: error: too long token expansion > > Workaround the warnings by refactoring the code to a new function, which also > reduces code duplication. And in the new function use max3() to make the code > more readable. > > No functional changes, compile tested only. > > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. fd6ed1772b2c wifi: ath11k: workaround too long expansion sparse warnings -- https://patchwork.kernel.org/project/linux-wireless/patch/20231214161740.1582340-1-kvalo@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches