Received-SPF: pass (google.com: domain of linux-wireless+bounces-860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <c1d61da8-3aba-4d4a-a852-3e743666da11@lwfinger.net>
Date: Sat, 16 Dec 2023 12:35:29 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add additional USB IDs for RTL8192EU
 devices
Content-Language: en-US
To: Zenm Chen <zenmchen@gmail.com>, Jes.Sorensen@gmail.com
Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org,
 linux-kernel@vger.kernel.org, pkshih@realtek.com, rtl8821cerfe2@gmail.com
References: <20231216165259.5389-1-zenmchen@gmail.com>
From: Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20231216165259.5389-1-zenmchen@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/16/23 10:52, Zenm Chen wrote:
> Add additional USB IDs found in the vendor driver from
> https://github.com/Mange/rtl8192eu-linux-driver to support more
> RTL8192EU devices.
> 
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
> ---
> v2:
>   - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED

Have you tested all modes including STA, AP, P2P, etc? If not, then your devices 
belong in the CONFIG_RTL8XXXU_UNTESTED section.

I am also not fond of splitting the rtl8192eu devices into several different 
spots in the table. That only makes it harder to see what devices are supported.

NACKed by Larry Finger <Larry.Finger@lwfinger.net>

Larry