Received-SPF: pass (google.com: domain of linux-wireless+bounces-931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,  =?utf-8?Q?Rafa=C5=82_Mi?=
 =?utf-8?Q?=C5=82ecki?=
 <zajec5@gmail.com>,  "David S . Miller" <davem@davemloft.net>,  Eric
 Dumazet <edumazet@google.com>,  Jakub Kicinski <kuba@kernel.org>,  Paolo
 Abeni <pabeni@redhat.com>,  Larry Finger <Larry.Finger@lwfinger.net>,
  Arend van Spriel <aspriel@gmail.com>,  Franky Lin
 <franky.lin@broadcom.com>,  Hante Meuleman <hante.meuleman@broadcom.com>,
  Michael Buesch <m@bues.ch>,  linux-wireless@vger.kernel.org,
  netdev@vger.kernel.org,  b43-dev@lists.infradead.org,
  brcm80211-dev-list.pdl@broadcom.com,  SHA-cyfmac-dev-list@infineon.com,
  kernel-janitors@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcma,ssb: simplify dependency handling for bcma and ssb
 drivers
References: <20231218115802.15859-1-lukas.bulwahn@gmail.com>
	<26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net>
Date: Mon, 18 Dec 2023 16:59:00 +0200
In-Reply-To: <26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net>
	(Johannes Berg's message of "Mon, 18 Dec 2023 14:17:59 +0100")
Message-ID: <87o7ensgjv.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Johannes Berg <johannes@sipsolutions.net> writes:

> On Mon, 2023-12-18 at 12:58 +0100, Lukas Bulwahn wrote:
>
> Dunno, I'm not super involved with this but ...
>
>> +++ b/drivers/bcma/Kconfig
>> @@ -1,12 +1,7 @@
>>  # SPDX-License-Identifier: GPL-2.0
>> -config BCMA_POSSIBLE
>> -	bool
>> -	depends on HAS_IOMEM && HAS_DMA
>> -	default y
>> -
>>  menuconfig BCMA
>>  	tristate "Broadcom specific AMBA"
>> -	depends on BCMA_POSSIBLE
>> +	depends on HAS_IOMEM && HAS_DMA
>
> [...]
>>  config BRCMSMAC
>>  	tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver"
>> -	depends on MAC80211
>> -	depends on BCMA_POSSIBLE
>> +	depends on HAS_IOMEM && HAS_DMA && MAC80211
>>  	select BCMA
>
> to me it kind of seems more obvious for example in this case to say
> "depend on BCMA_POSSIBLE and select BCMA" rather than open-coding the
> BCMA dependencies both here and in BCMA? Now granted, they're rather
> unlikely to _change_, but it still seems more obvious?

I was thinking the same. Lukas, is there a specific reason why you want
to change this or this just something you noticed by chance?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches