Received-SPF: pass (google.com: domain of linux-wireless+bounces-932-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231218115802.15859-1-lukas.bulwahn@gmail.com> <26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net>
In-Reply-To: <26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net>
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: Mon, 18 Dec 2023 15:59:49 +0100
Message-ID: <CAKXUXMyiMMOF79Wbe+xcL2yAXM8+9j_qJhCM0tn-o-hYeY=-ZQ@mail.gmail.com>
Subject: Re: [PATCH] bcma,ssb: simplify dependency handling for bcma and ssb drivers
To: Johannes Berg <johannes@sipsolutions.net>
Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>, 
	"David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Kalle Valo <kvalo@kernel.org>, 
	Larry Finger <Larry.Finger@lwfinger.net>, Arend van Spriel <aspriel@gmail.com>, 
	Franky Lin <franky.lin@broadcom.com>, Hante Meuleman <hante.meuleman@broadcom.com>, 
	Michael Buesch <m@bues.ch>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, 
	b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, 
	SHA-cyfmac-dev-list@infineon.com, kernel-janitors@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 18, 2023 at 2:18=E2=80=AFPM Johannes Berg <johannes@sipsolution=
s.net> wrote:
>
> On Mon, 2023-12-18 at 12:58 +0100, Lukas Bulwahn wrote:
>
> Dunno, I'm not super involved with this but ...
>
> > +++ b/drivers/bcma/Kconfig
> > @@ -1,12 +1,7 @@
> >  # SPDX-License-Identifier: GPL-2.0
> > -config BCMA_POSSIBLE
> > -     bool
> > -     depends on HAS_IOMEM && HAS_DMA
> > -     default y
> > -
> >  menuconfig BCMA
> >       tristate "Broadcom specific AMBA"
> > -     depends on BCMA_POSSIBLE
> > +     depends on HAS_IOMEM && HAS_DMA
>
> [...]
> >  config BRCMSMAC
> >       tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver"
> > -     depends on MAC80211
> > -     depends on BCMA_POSSIBLE
> > +     depends on HAS_IOMEM && HAS_DMA && MAC80211
> >       select BCMA
>
> to me it kind of seems more obvious for example in this case to say
> "depend on BCMA_POSSIBLE and select BCMA" rather than open-coding the
> BCMA dependencies both here and in BCMA? Now granted, they're rather
> unlikely to _change_, but it still seems more obvious?
>

Okay, I see. Well, if that kind of pattern is the preference, then the
code as-is makes sense. The pattern just starts to become obscure when
the dependencies of multiple drivers are the same and we start writing
"BCMA_POSSIBLE || SSB_POSSIBLE", but the dependencies are the same
anyway.

Let us see what others think.

Lukas