Received-SPF: pass (google.com: domain of linux-wireless+bounces-939-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: iwlwifi: pcie: don't synchronize IRQs from IRQ
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: 
 <20231215111335.59aab00baed7.Iadfe154d6248e7f9dfd69522e5429dbbd72925d7@changeid>
References: 
 <20231215111335.59aab00baed7.Iadfe154d6248e7f9dfd69522e5429dbbd72925d7@changeid>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
 Miri Korenblit <miriam.rachel.korenblit@intel.com>,
 Emmanuel Grumbach <emmanuel.grumbach@intel.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <170291772631.360676.241613506722082972.kvalo@kernel.org>
Date: Mon, 18 Dec 2023 16:42:08 +0000 (UTC)

Johannes Berg <johannes@sipsolutions.net> wrote:

> From: Johannes Berg <johannes.berg@intel.com>
> 
> On older devices (before unified image!) we can end up calling
> stop_device from an rfkill interrupt. However, in stop_device
> we attempt to synchronize IRQs, which then of course deadlocks.
> 
> Avoid this by checking the context, if running from the IRQ
> thread then don't synchronize. This wouldn't be correct on a
> new device since RSS is supported, but older devices only have
> a single interrupt/queue.
> 
> Fixes: 37fb29bd1f90 ("wifi: iwlwifi: pcie: synchronize IRQs before NAPI")
> Reviewed-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Patch applied to wireless.git, thanks.

400f6ebbc175 wifi: iwlwifi: pcie: don't synchronize IRQs from IRQ

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231215111335.59aab00baed7.Iadfe154d6248e7f9dfd69522e5429dbbd72925d7@changeid/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches