Received-SPF: pass (google.com: domain of linux-wireless+bounces-1048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a817504ee11fd9bca316312b40218f82c56ec7b7.camel@sipsolutions.net>
Subject: Re: [PATCH v2 06/13] wifi: mac80211: rework RX timestamp flags
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Miri Korenblit
	 <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, Gregory Greenman
	 <gregory.greenman@intel.com>, Benjamin Berg <benjamin.berg@intel.com>
Date: Tue, 19 Dec 2023 23:43:01 +0100
In-Reply-To: <69e18f8e-0157-43db-bd11-78ee945d9912@quicinc.com>
References: 
	<20231220133549.bdfb8a9c7c54.I973563562969a27fea8ec5685b96a3a47afe142f@changeid>
	 <20231220133549.d0e664832d14.I20c8900106f9bf81316bed778b1e3ce145785274@changeid>
	 <69e18f8e-0157-43db-bd11-78ee945d9912@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2023-12-19 at 14:41 -0800, Jeff Johnson wrote:
>=20
> >  static inline bool
> >  ieee80211_have_rx_timestamp(struct ieee80211_rx_status *status)
> >  {
> > -	WARN_ON_ONCE(status->flag & RX_FLAG_MACTIME_START &&
> > -		     status->flag & RX_FLAG_MACTIME_END);
> > -	return !!(status->flag & (RX_FLAG_MACTIME_START | RX_FLAG_MACTIME_END=
 |
> > -				  RX_FLAG_MACTIME_PLCP_START));
> > +	return status->flag & RX_FLAG_MACTIME;
>=20
> curious why you dropped the !!

Just a general cleanup I guess.

> now the code can return a value that doesn't map to the true/false bool
> enums

No, it cannot, at least not if 'bool' is implemented in a C99-compliant
way :) It's not actually an enum, it will return 0/1 in the machine
register even with this code.

johannes