Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp222905rdb; Tue, 19 Dec 2023 14:48:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IF47unBwN6m17Hf5AIG6BzfIvw0FsOaXjX2mTaoRWiYzSO0KUYXM9eW6dhZXPmlqIhnznNS X-Received: by 2002:a92:c268:0:b0:35f:b286:99bc with SMTP id h8-20020a92c268000000b0035fb28699bcmr6264508ild.17.1703026126758; Tue, 19 Dec 2023 14:48:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703026126; cv=none; d=google.com; s=arc-20160816; b=M+vyJAYcBMNy2PPjZQdpR8uXKbiwSksbYpSFymJTd8Xlhx5M+RPYOkVpCl2F3mdpkC jPslTpcQF329njjMdZ3loVgS15jKbZ5bde4i1RtC942KkriIb40/xZxs4zJG4lbeBoCc 84HKrwTmpgkv+wVhK1KME5UKMcAt6TlltPzDU9PmcjlRL5sO32eBUuPklS7O3Wb1zmdg X+rrg6OSed6IX0EXz27wrXfzrZ1WMP6YEzXTr51FCgmYUMkpkoP5XGAG7KL51ub1xM7+ quVL9buVGpl2c1QqaLiin8CAuGZQACk8+FXt0e/cv3IrM4DaBng8z4bezJt5tvKO4boc UWGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=dF+rvLwTnrcu7MGaXdXhsAxsk1RV9+jU362RTIzh/+0=; fh=bNe6zX6RxvYoRdPsky4hXVbzbAyS7ak5CHMatbWUJGQ=; b=Wrf5RolsBks/mpblvW55+js6DIGZITOxe0LQtTkQcuHC7V6ojBvSbGsrvOgqsqzp4R XqJsyuP7TSIECLeA+N2HD9m8CeZ4YfZRZ8udZeL9wo8atNlQ4cLXB1Ek52tXCaEUypz8 r1iQDeDvDHhGSnPnX79L/+NkLz5vcwCjN4SgAU+lYsMU6d+scd0RXiosWHrI043wN5gt tlgeWPrBwefIR7/Ur6ZPzObvmEqu2l1ArY/4tMaZ085FTOFoXAeYwRPVZgMBJt839A0S i7zyo1swhxPmDNPE3qKJ3067YLICDLuW6p8GU6sZaDusI4uUAipY/7IgypyJc8Ttmqdx 66NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=buSkWV5u; spf=pass (google.com: domain of linux-wireless+bounces-1049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bk6-20020a056a02028600b00577616e3ad9si20595863pgb.871.2023.12.19.14.48.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 14:48:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=buSkWV5u; spf=pass (google.com: domain of linux-wireless+bounces-1049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 29A00B230DB for ; Tue, 19 Dec 2023 22:48:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A07CF3EA7F; Tue, 19 Dec 2023 22:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="buSkWV5u" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179C33DBAA for ; Tue, 19 Dec 2023 22:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BJLEMZd014589; Tue, 19 Dec 2023 22:48:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=dF+rvLwTnrcu7MGaXdXhsAxsk1RV9+jU362RTIzh/+0=; b=bu SkWV5uJjxIJ07Yx63jE+2lWHpwmzTICiLb/5VkLNlLcl22lILHtOoKTNoSAKHglY VzgnQTdRaWTBHilsVZEhh6vdluQTiAu6MM7r2wUswMZjf4f3phRlE/JYK5wfxK9k +4gKDQSOX6BxkPHW41tAIZe3BQGsDPBU7uKCHCuuWUznza/gfkMqmKYKSAM8ZLrq H4WTvCGKB6MCU58VJSkWK4XU8lNPsQSONYDhOF9CWJiSRVQEsDSqXisQPB675erT zgRin1RU5CRTifNrULmbIhjvuiC8jNPvBk/3xOfBKxi6GQrxYKPiyfjeOfsTqYK6 SHtZ/a7TlnViEMxkmgZg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v38qssspg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Dec 2023 22:48:23 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BJMmMff000653 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Dec 2023 22:48:22 GMT Received: from [10.110.4.21] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 19 Dec 2023 14:48:22 -0800 Message-ID: Date: Tue, 19 Dec 2023 14:48:21 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/13] wifi: mac80211_hwsim: support HE 40MHz in 2.4Ghz band Content-Language: en-US To: Miri Korenblit , CC: , Gregory Greenman References: <20231220133549.bdfb8a9c7c54.I973563562969a27fea8ec5685b96a3a47afe142f@changeid> <20231220133549.82d9666abb5b.I1ba6905c806be6e0548ed15130c0bbb2ee04c9fd@changeid> From: Jeff Johnson In-Reply-To: <20231220133549.82d9666abb5b.I1ba6905c806be6e0548ed15130c0bbb2ee04c9fd@changeid> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: DqlhFEG9jb7L57sDjCZN-Caz-90eYj_A X-Proofpoint-ORIG-GUID: DqlhFEG9jb7L57sDjCZN-Caz-90eYj_A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 mlxlogscore=473 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312190169 On 12/20/2023 3:41 AM, Miri Korenblit wrote: > We are missing the flag that indicates that capability > of 40MHz bandwidth support in HE on the LB. Subject nit: s/Ghz/GHz/ Also consider adding a space between value and units of all frequency references to conform to SI naming (which is also the format used by the 802.11 specifications).