Received-SPF: pass (google.com: domain of linux-wireless+bounces-1066-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Martin Kaistra <martin.kaistra@linutronix.de>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC: Jes Sorensen <Jes.Sorensen@gmail.com>, Kalle Valo <kvalo@kernel.org>,
        Bitterblue Smith <rtl8821cerfe2@gmail.com>,
        Sebastian Andrzej Siewior
	<bigeasy@linutronix.de>
Subject: RE: [PATCH 19/20] wifi: rtl8xxxu: make supporting AP mode only on port 0 transparent
Thread-Topic: [PATCH 19/20] wifi: rtl8xxxu: make supporting AP mode only on
 port 0 transparent
Thread-Index: AQHaMb/t7UraxeutE0+U7Z3itK4it7Cxt0zA
Date: Wed, 20 Dec 2023 06:28:21 +0000
Message-ID: <56eed6a3e237435f9d21082ca12eeaec@realtek.com>
References: <20231218143645.433356-1-martin.kaistra@linutronix.de>
 <20231218143645.433356-20-martin.kaistra@linutronix.de>
In-Reply-To: <20231218143645.433356-20-martin.kaistra@linutronix.de>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Martin Kaistra <martin.kaistra@linutronix.de>
> Sent: Monday, December 18, 2023 10:37 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>;=
 Ping-Ke Shih
> <pkshih@realtek.com>; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Sebasti=
an Andrzej Siewior
> <bigeasy@linutronix.de>
> Subject: [PATCH 19/20] wifi: rtl8xxxu: make supporting AP mode only on po=
rt 0 transparent
>=20
> When the driver is used for concurrent mode, both virtual interfaces can
> be set to station or AP mode, though only one can be in AP mode at the
> same time.
>=20
> In order to keep the code simple, use only hw port 0 for AP mode. When
> an interface is added in AP mode which would be assigned to port 1, use
> a switch_port function to transparently swap the mapping between virtual
> interface and hw port.
>=20
> Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
> ---
>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 84 ++++++++++++++++++-
>  1 file changed, 82 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 88730791091a7..595f447874f4d 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -6613,6 +6613,84 @@ static int rtl8xxxu_submit_int_urb(struct ieee8021=
1_hw *hw)
>         return ret;
>  }
>=20
> +static void rtl8xxxu_switch_ports(struct rtl8xxxu_priv *priv)
> +{

[...]

> +
> +       vif =3D priv->vifs[0];
> +       priv->vifs[0] =3D priv->vifs[1];
> +       priv->vifs[1] =3D vif;
> +       rtlvif =3D (struct rtl8xxxu_vif *)priv->vifs[1]->drv_priv;
> +       rtlvif->port_num =3D 1;

nit: Would it be better to swap port_num as well? Currently, port_num of vi=
fs[0]
will be set to 0 by caller, but not sure if further people could misuse thi=
s
function.


> +}
> +
>  static int rtl8xxxu_add_interface(struct ieee80211_hw *hw,
>                                   struct ieee80211_vif *vif)
>  {
> @@ -6640,8 +6718,10 @@ static int rtl8xxxu_add_interface(struct ieee80211=
_hw *hw,
>                 }
>                 break;
>         case NL80211_IFTYPE_AP:
> -               if (port_num =3D=3D 1)
> -                       return -EOPNOTSUPP;
> +               if (port_num =3D=3D 1) {
> +                       rtl8xxxu_switch_ports(priv);
> +                       port_num =3D 0;
> +               }
>=20
>                 rtl8xxxu_write8(priv, REG_BEACON_CTRL,
>                                 BEACON_DISABLE_TSF_UPDATE | BEACON_CTRL_M=
BSSID);
> --
> 2.39.2