Received: by 2002:a05:7412:d008:b0:f9:6acb:47ec with SMTP id bd8csp438709rdb; Wed, 20 Dec 2023 01:22:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYF8W/hB8kTAoZXvcMGpIs6SlXqEHtxmbV42tqqXQ6NLou1T/5WeYV7OYT1DagCaWhFtEk X-Received: by 2002:a05:6a00:4e4e:b0:6d9:2e73:64b4 with SMTP id gu14-20020a056a004e4e00b006d92e7364b4mr2954950pfb.45.1703064132000; Wed, 20 Dec 2023 01:22:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703064131; cv=none; d=google.com; s=arc-20160816; b=tMw6DbvNHGZv7cZhi/8lM8WkPFRzu98unojJUfgGMLz0Lq62up4XeqKoiAkmGzlsuQ VpnVQJ4PmtZnt2WUmKA9d0p0enZ742LNnbEcDMKEpnkL9cyscnIR2RKg0TegS1qHgD9u 8EIDSvf6ZQ4djvDcdIlzcwMt60Li9+UtNsBUS+q4WwkDAoHO32iU0iM1V1tcsRMBqGN2 a82HCJQUliW2ohZzQcykMG549GZc8I72wPIArvDJJmXTPSYVGzaAP+fXKEjRiMg8YrUk o+s83OUFlBzgecSBofR9z70M/8T6PlwjjuGE9wKQquZ14udihZ7Jb5+WpsWaIdsUfaJh KN8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FcIFo+aNsT1Q+vI57pGRLbrLSQ3ZffHYOwRJxMZ6moI=; fh=jlecVeJ1zmiUcWLoYt7W352gNllWYkqAa/aIazCPBg4=; b=SYGVzlj8fdCa9oNdinGk2sBbHmNoNjSgJaCoRyoS23bQo2uHvSx5S4kjiR26O+Khpo 5/C2qB9oX/+eSFalwVh5Cw5LGx63uPqc0zATxi9xDzeJD+8tS4bygyPI6uRCVrc56Wgq G4XYAYH7SXjJpXKFZ/24og6b6Q5zmPEKi3+p6KVgLcyIxAVOd2HzilHra5IUF141XVEf g8/XXYfps4FOkQONQPRjSvoQMRatIU2mrYG6X+mGWSBTNjI1huIv/uve2EiUVz4CAOi7 qF7nnXYg3VHdGxsgR8smXBOfzLGWP24M0gTZG/WxGd+NbXfUQDAGIazNJE1dCsDXfL7Z G46w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=qLceEiSG; spf=pass (google.com: domain of linux-wireless+bounces-1077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1077-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id by27-20020a056a02059b00b005b8ef498e2bsi4765188pgb.461.2023.12.20.01.22.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 01:22:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=qLceEiSG; spf=pass (google.com: domain of linux-wireless+bounces-1077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1077-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E676DB20A89 for ; Wed, 20 Dec 2023 09:22:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 274FA1F191; Wed, 20 Dec 2023 09:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="qLceEiSG" X-Original-To: linux-wireless@vger.kernel.org Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 765E11DDFA for ; Wed, 20 Dec 2023 09:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com X-UUID: 31c5494e9f1911eeba30773df0976c77-20231220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=FcIFo+aNsT1Q+vI57pGRLbrLSQ3ZffHYOwRJxMZ6moI=; b=qLceEiSGv93L/AoEjNcgWjpcGQZ0CguyvBMiQUvavI6XlpSkUxXhf6OHT5/pb4TKEfVsx3rCkJaRAi8icw2GZajOh6l0qufXoU30d9IUm/QDjNLiHwVt+8W1T/Sab5BdLT8zABSpYpayQVGRofRMNgulI2XclVX4Ih3+vX12svI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:596c1817-123e-497f-825f-4f059644b585,IP:0,U RL:0,TC:0,Content:100,EDM:-30,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:70 X-CID-META: VersionHash:5d391d7,CLOUDID:59514b2e-1ab8-4133-9780-81938111c800,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:801|102,TC:nil,Content:3,EDM:2,IP:ni l,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 31c5494e9f1911eeba30773df0976c77-20231220 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 104990926; Wed, 20 Dec 2023 17:21:45 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 20 Dec 2023 17:21:44 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 20 Dec 2023 17:21:44 +0800 From: Mingyen Hsieh To: , CC: , , , , , , , , , , , , , , Ming Yen Hsieh , Leon Yen Subject: [PATCH 2/4] wifi: mt76: mt7921: fix potential command timeout issues when suspend Date: Wed, 20 Dec 2023 17:21:36 +0800 Message-ID: <20231220092138.12830-3-mingyen.hsieh@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20231220092138.12830-1-mingyen.hsieh@mediatek.com> References: <20231220092138.12830-1-mingyen.hsieh@mediatek.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain From: Ming Yen Hsieh An ongoing command may be interrupted if suspended, leading to a command timeout. Add a lock to the suspend function in order to protect the ongoing command from being interrupted. Signed-off-by: Leon Yen Signed-off-by: Ming Yen Hsieh --- drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c index 57903c6e4f11..e1c53f18abdc 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c @@ -409,7 +409,9 @@ static int mt7921_pci_suspend(struct device *device) if (err < 0) goto restore_suspend; + mt792x_mutex_acquire(dev); err = mt76_connac_mcu_set_hif_suspend(mdev, true); + mt792x_mutex_release(dev); if (err) goto restore_suspend; -- 2.18.0