Received: by 2002:a05:7412:d024:b0:f9:90c9:de9f with SMTP id bd36csp53169rdb; Wed, 20 Dec 2023 06:11:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhqtweJNTyo27SSy3oxgbMBP8j9n3wDSQgAsBxL1asuwvipaeRyd5CAF1T33AC4bO7VidY X-Received: by 2002:a05:6830:6e18:b0:6d6:53f8:882 with SMTP id ec24-20020a0568306e1800b006d653f80882mr28145760otb.20.1703081505649; Wed, 20 Dec 2023 06:11:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703081505; cv=none; d=google.com; s=arc-20160816; b=ycOp5zxvb3aGOfrlq3HfPCi2/H6p/dlgud4BWm1Oz4crt9Nz/FrQQYdR8S81LYStCS rXTl0wD6cVI0D2hOUiYNHrNNgJTWOIYvBUhp0aRC1VpNeUPbeEEf6UQ0q5fKGYXOr+j9 dpvzuaijCAJZ3lYXYq3oZUew5S21MvtLHC4mxU0pM0SFznIOdegEfbni4oSaB+bgVbPq xZ2xOZRjBC5Qoi2pDQwPbh9PzhzEx9drpGFLPWG+58E9IyQTWTCcdt0G6npAem+IpDSa 541XDkAQYKn3En27yDEPxBWOM+Z3IMcUIWG0mWNA2o4gfsbhQy7bNvvDcOYjtaoPokKO 0wvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=aPPMmIO4lfCoRN+5B+VD7O6TWTXph/PhYWRgz0pngwI=; fh=caIDB4vuAtY7vDXqa3Kh1Wba3cCXc8BpAOnz5znjpmU=; b=Ca+G1fbA7bgwEPYVk7g6GwmI9OlvmdoYi8EpC4c8FUvv1Vvh7xY2O8hgTox95CRUzl FNsbZXoze21tHumNfgV08uzk6/vt3Ci1JRmjAFJH1c7vBelQClgzMN0aw09CbGMmye3t qEPb6B6Bcmp4WNOlR/MrfoAbq30l4iOJKz7tH5XkNllF0RxBL9+C+ipduS7cbZgjo4Np MyJfYP+q1KGlpzGNHywn3om6NAG4TfFCVUDWArujOmsOwrivr7Bh7NMvy1To/5boo3U2 HphxT0WQI7lgSxHuGskc2VZ9Mkvc0xiZxznPYRfjbH/qamaOhTSBiyXEOzTDWKRwAX9o s6Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="LdyuB/Wi"; spf=pass (google.com: domain of linux-wireless+bounces-1090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d27-20020ab07c5b000000b007cbfbcce3efsi654659uaw.121.2023.12.20.06.11.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 06:11:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="LdyuB/Wi"; spf=pass (google.com: domain of linux-wireless+bounces-1090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5D59D1C20905 for ; Wed, 20 Dec 2023 14:11:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 96D5C25768; Wed, 20 Dec 2023 14:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LdyuB/Wi" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7202739841; Wed, 20 Dec 2023 14:11:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF06DC433C8; Wed, 20 Dec 2023 14:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703081500; bh=i1vREzGg9L6c6Fd8geHXkYfzZq5y9cqUrhAh22X+8L4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LdyuB/WixkJS74JDO3vKkJPH9rsRhrjL1Qgcvgw92zCcahIvro7KgaBubxblZ1RYM x63JAQINmM9i5f/3Kqowbai95TRZiTOCn56jT3Im2mpLt0wANGKugvr2FpDJlREcVc QkJRNknVEZkEvRPFexrVy0mqw5uVkzIKly+fPbkiZ6Z/t5+TA4KTdJ1lYYvee1Dcru 1ws/fyi8jNL3kswkqKRoLadxVSOKGYJg3PRUqFwH2WXS6ahNhSq3G78CjCpFQDG7e4 ee+tyoWwTw22R/Qls9zMPjNkqdjRg1cLA0VeNauyaktDeZszzi41IuSAcU4W/SD2ii IrbXeiwE9gTGQ== From: Kalle Valo To: Mathias Krause Cc: Bjorn Helgaas , Arend van Spriel , Franky Lin , Hante Meuleman , linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH] PCI: Remove unused 'node' member from struct pci_driver References: <20231220133505.8798-1-minipli@grsecurity.net> Date: Wed, 20 Dec 2023 16:11:37 +0200 In-Reply-To: <20231220133505.8798-1-minipli@grsecurity.net> (Mathias Krause's message of "Wed, 20 Dec 2023 14:35:05 +0100") Message-ID: <87cyv12cbq.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Mathias Krause writes: > Remove the unused 'node' member. It got replaced by device_driver > chaining more than 20 years ago in commit 4b4a837f2b57 ("PCI: start to > use common fields of struct device_driver more...") of the history.git > tree. > > Signed-off-by: Mathias Krause > --- > There is only one "user" that makes use of the 'node' member, which is > the brcm80211 driver. However, its "use" is clearly wrong (a list head > cannot be initialized this way) and, obviously, not needed. > > If netdev folks instead want to split this off into a separate commit, I > can do that. However, I don't expect any cross-tree conflicts regarding > this change. > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 - > include/linux/pci.h | 2 -- > 2 files changed, 3 deletions(-) No need to split anything, feel free to take this via PCI tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches