Received-SPF: pass (google.com: domain of linux-wireless+bounces-1090-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Mathias Krause <minipli@grsecurity.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,  Arend van Spriel
 <arend.vanspriel@broadcom.com>,  Franky Lin <franky.lin@broadcom.com>,
  Hante Meuleman <hante.meuleman@broadcom.com>,  linux-pci@vger.kernel.org,
  linux-wireless@vger.kernel.org,  linux-kernel@vger.kernel.org,
  SHA-cyfmac-dev-list@infineon.com,  brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] PCI: Remove unused 'node' member from struct pci_driver
References: <20231220133505.8798-1-minipli@grsecurity.net>
Date: Wed, 20 Dec 2023 16:11:37 +0200
In-Reply-To: <20231220133505.8798-1-minipli@grsecurity.net> (Mathias Krause's
	message of "Wed, 20 Dec 2023 14:35:05 +0100")
Message-ID: <87cyv12cbq.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Mathias Krause <minipli@grsecurity.net> writes:

> Remove the unused 'node' member. It got replaced by device_driver
> chaining more than 20 years ago in commit 4b4a837f2b57 ("PCI: start to
> use common fields of struct device_driver more...") of the history.git
> tree.
>
> Signed-off-by: Mathias Krause <minipli@grsecurity.net>
> ---
> There is only one "user" that makes use of the 'node' member, which is
> the brcm80211 driver. However, its "use" is clearly wrong (a list head
> cannot be initialized this way) and, obviously, not needed.
>
> If netdev folks instead want to split this off into a separate commit, I
> can do that. However, I don't expect any cross-tree conflicts regarding
> this change.
>
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 -
>  include/linux/pci.h                                     | 2 --
>  2 files changed, 3 deletions(-)

No need to split anything, feel free to take this via PCI tree:

Acked-by: Kalle Valo <kvalo@kernel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches