Received-SPF: pass (google.com: domain of linux-wireless+bounces-1138-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6cd6ff5b-3308-444b-bc68-62b85cfabd4b@linutronix.de>
Date: Thu, 21 Dec 2023 09:24:11 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH 14/20] wifi: rtl8xxxu: support multiple interfaces in
 bss_info_changed()
Content-Language: de-DE
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>, Kalle Valo <kvalo@kernel.org>,
 Bitterblue Smith <rtl8821cerfe2@gmail.com>,
 Sebastian Andrzej Siewior <bigeasy@linutronix.de>
References: <20231218143645.433356-1-martin.kaistra@linutronix.de>
 <20231218143645.433356-15-martin.kaistra@linutronix.de>
 <32b2f2efe2834578809303c9960fba6d@realtek.com>
From: Martin Kaistra <martin.kaistra@linutronix.de>
In-Reply-To: <32b2f2efe2834578809303c9960fba6d@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Am 20.12.23 um 07:09 schrieb Ping-Ke Shih:
> 
> 
>> -----Original Message-----
>> From: Martin Kaistra <martin.kaistra@linutronix.de>
>> Sent: Monday, December 18, 2023 10:37 PM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih
>> <pkshih@realtek.com>; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Sebastian Andrzej Siewior
>> <bigeasy@linutronix.de>
>> Subject: [PATCH 14/20] wifi: rtl8xxxu: support multiple interfaces in bss_info_changed()
>>
>> Call set_linktype now with correct port_num. Only react to beacon
>> changes if port_num == 0, as we only support AP mode on this port.
>>
>> Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
>> ---
>>   .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 26 +++++++++++--------
>>   1 file changed, 15 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> index 59dd50844f1ae..f929b01615d00 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> 
> [...]
> 
>> @@ -5090,16 +5092,18 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
>>                  rtl8xxxu_set_basic_rates(priv, bss_conf->basic_rates);
>>          }
>>
>> -       if (changed & BSS_CHANGED_BEACON_ENABLED) {
>> -               if (bss_conf->enable_beacon)
>> -                       rtl8xxxu_start_tx_beacon(priv);
>> -               else
>> -                       rtl8xxxu_stop_tx_beacon(priv);
>> +       /* beacon only supported for port_num = 0 */
>> +       if (rtlvif->port_num == 0) {
> 
> As your design, AP mode must play on port 0. Could mac80211 notify driver BEACON
> changed on port 1?

Looking at mac80211 code, there is an explicit check for vif.type when changed 
contains BSS_CHANGED_BEACON or BSS_CHANGED_BEACON_ENABLED. As rtl8xxxu driver 
only allows to add NL80211_IFTYPE_AP on port_num = 0, a notification on port 1 
will never happen. I will remove this check for v2.


> 
>> +               if (changed & BSS_CHANGED_BEACON_ENABLED) {
>> +                       if (bss_conf->enable_beacon)
>> +                               rtl8xxxu_start_tx_beacon(priv);
>> +                       else
>> +                               rtl8xxxu_stop_tx_beacon(priv);
>> +               }
>> +               if (changed & BSS_CHANGED_BEACON)
>> +                       schedule_work(&priv->update_beacon_work);
>>          }
>>
>> -       if (changed & BSS_CHANGED_BEACON)
>> -               schedule_work(&priv->update_beacon_work);
>> -
>>   error:
>>          return;
>>   }
> 
> Ping-Ke
>