Received-SPF: pass (google.com: domain of linux-wireless+bounces-1176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <0500067b5d2722f0546ae588934de18aa28b09b0.camel@sipsolutions.net>
Subject: Re: [PATCH v2 06/13] wifi: mac80211: rework RX timestamp flags
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Miri Korenblit
	 <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, Gregory Greenman
	 <gregory.greenman@intel.com>, Benjamin Berg <benjamin.berg@intel.com>
Date: Thu, 21 Dec 2023 20:13:40 +0100
In-Reply-To: <05944e81-3c1b-485b-82f8-15b8cb991a4b@quicinc.com>
References: 
	<20231220133549.bdfb8a9c7c54.I973563562969a27fea8ec5685b96a3a47afe142f@changeid>
	 <20231220133549.d0e664832d14.I20c8900106f9bf81316bed778b1e3ce145785274@changeid>
	 <69e18f8e-0157-43db-bd11-78ee945d9912@quicinc.com>
	 <a817504ee11fd9bca316312b40218f82c56ec7b7.camel@sipsolutions.net>
	 <05944e81-3c1b-485b-82f8-15b8cb991a4b@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2023-12-19 at 15:16 -0800, Jeff Johnson wrote:
> On 12/19/2023 2:43 PM, Johannes Berg wrote:
> > On Tue, 2023-12-19 at 14:41 -0800, Jeff Johnson wrote:
> > > now the code can return a value that doesn't map to the true/false bo=
ol
> > > enums
> >=20
> > No, it cannot, at least not if 'bool' is implemented in a C99-compliant
> > way :) It's not actually an enum, it will return 0/1 in the machine
> > register even with this code.
>=20
> Today I learned something new. Guess I'm still carrying baggage from
> pre-C99.

Which is not necessarily bad - there are to this day compilers that
implement bool as if it was an enum, and then it can hold values other
than 0/1 ... but at least for kernel work we can assume bool is
implemented as specified :)

johannes