Received-SPF: pass (google.com: domain of linux-wireless+bounces-1191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Martin Kaistra <martin.kaistra@linutronix.de>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC: Jes Sorensen <Jes.Sorensen@gmail.com>, Kalle Valo <kvalo@kernel.org>,
        Bitterblue Smith <rtl8821cerfe2@gmail.com>,
        Sebastian Andrzej Siewior
	<bigeasy@linutronix.de>
Subject: RE: [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on port 0 transparent
Thread-Topic: [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on
 port 0 transparent
Thread-Index: AQHaNC0oaJY+qGCnXUKN9G8m+k3jo7C0ikyQ
Date: Fri, 22 Dec 2023 01:54:27 +0000
Message-ID: <7bbb0d0b803d49088957b47ad716e99b@realtek.com>
References: <20231221164353.603258-1-martin.kaistra@linutronix.de>
 <20231221164353.603258-21-martin.kaistra@linutronix.de>
In-Reply-To: <20231221164353.603258-21-martin.kaistra@linutronix.de>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Martin Kaistra <martin.kaistra@linutronix.de>
> Sent: Friday, December 22, 2023 12:44 AM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>;=
 Ping-Ke Shih
> <pkshih@realtek.com>; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Sebasti=
an Andrzej Siewior
> <bigeasy@linutronix.de>
> Subject: [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on=
 port 0 transparent
>=20

[...]

> +
> +       /*
> +        * priv->vifs[0] is NULL here, based on how this function is curr=
ently
> +        * called from rtl8xxxu_add_interface().
> +        * When this function will be used in the future for a different
> +        * scenario, please check whether vifs[0] or vifs[1] can be NULL =
and if
> +        * necessary add code to set port_num =3D 1.
> +        */

Did you run scripts/checkpatch.pl to this patch? Initial line of comment bl=
ock
for networking code should not empty, so it should be below:=20

+       /* priv->vifs[0] is NULL here, based on how this function is curren=
tly
+        * called from rtl8xxxu_add_interface().
+        * When this function will be used in the future for a different
+        * scenario, please check whether vifs[0] or vifs[1] can be NULL an=
d if
+        * necessary add code to set port_num =3D 1.
+        */