Received-SPF: pass (google.com: domain of linux-wireless+bounces-1204-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6aaae1a4-5d34-476e-b64b-2c19b7a15473@linutronix.de>
Date: Fri, 22 Dec 2023 08:49:23 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on
 port 0 transparent
Content-Language: de-DE
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>, Kalle Valo <kvalo@kernel.org>,
 Bitterblue Smith <rtl8821cerfe2@gmail.com>,
 Sebastian Andrzej Siewior <bigeasy@linutronix.de>
References: <20231221164353.603258-1-martin.kaistra@linutronix.de>
 <20231221164353.603258-21-martin.kaistra@linutronix.de>
 <7bbb0d0b803d49088957b47ad716e99b@realtek.com>
From: Martin Kaistra <martin.kaistra@linutronix.de>
In-Reply-To: <7bbb0d0b803d49088957b47ad716e99b@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Am 22.12.23 um 02:54 schrieb Ping-Ke Shih:
> 
> 
>> -----Original Message-----
>> From: Martin Kaistra <martin.kaistra@linutronix.de>
>> Sent: Friday, December 22, 2023 12:44 AM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih
>> <pkshih@realtek.com>; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Sebastian Andrzej Siewior
>> <bigeasy@linutronix.de>
>> Subject: [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on port 0 transparent
>>
> 
> [...]
> 
>> +
>> +       /*
>> +        * priv->vifs[0] is NULL here, based on how this function is currently
>> +        * called from rtl8xxxu_add_interface().
>> +        * When this function will be used in the future for a different
>> +        * scenario, please check whether vifs[0] or vifs[1] can be NULL and if
>> +        * necessary add code to set port_num = 1.
>> +        */
> 
> Did you run scripts/checkpatch.pl to this patch? Initial line of comment block
> for networking code should not empty, so it should be below:
> 
> +       /* priv->vifs[0] is NULL here, based on how this function is currently
> +        * called from rtl8xxxu_add_interface().
> +        * When this function will be used in the future for a different
> +        * scenario, please check whether vifs[0] or vifs[1] can be NULL and if
> +        * necessary add code to set port_num = 1.
> +        */
> 

I did run checkpatch.pl and chose to ignore this warning because all other 
multiline comments in the rtl8xxxu driver also have this initial empty line.

Do you still want me to change it?