Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3087303rdb; Tue, 26 Dec 2023 16:01:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9b7k2WiNmZqlDFSiQFA76+Wb7Wr+wdRNfen7u0lkrOZzXWJHPBL3dmNACdpQPmHkTAKEe X-Received: by 2002:a05:6a20:b71e:b0:196:22bb:869b with SMTP id fg30-20020a056a20b71e00b0019622bb869bmr9032pzb.0.1703635291244; Tue, 26 Dec 2023 16:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703635291; cv=none; d=google.com; s=arc-20160816; b=S6Eo2UjB8e0e5I+KIq2WcapvbtNJK8w6Uu+YtFAnLEtyH8ZKBvCP4dRWvYgCiO5b+m GOXPU7KheI7DAgu0iSCimVbKmIG6NZEMp7RUDEkA7AxR3cORCts/sizt25bWJUQg08ZY byLSr6HTxjuVzSb8ufzAk5TWKet168LMieSlkfPLBvk7ZHD3Fj1gvrXs42LbIig9UlH1 aEIwlvKYCgMLBt9ncelU3kc8vO8oq8iN5KzMfQnCOrSYs6Su1wJeMehlyxhjE5isaq/J hgRPPl1IYA9hTlXJ7Eo1H+qNE6QExDrdLtC3pmnky8K1X3wPa7WlK0eBV1PddOWU0WsH x8dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=eercs+5MI+apktoHkud7+BAdw567lN/LHMVa1WvuhiM=; fh=tslp9Obspaqe1pSCG1wLqzRJwDHM9gSIEzn4P7y1ZvY=; b=OaUnK1NvVg0/s/MmND8j7ixgM9jaYevA2Pc1dlRozkXfMp2ZARg8+TErLE9TV2mbqs HNWPpzGOOeOXhv3CqOzdKQh3e+wAYVO7r7zEAiHKs9Bsnznzte9kqBxCsjkweVW2D27b PRXMGMOkEDYuaSXVR3h+cg6hjmNI871DD0BtFHjib0n7Vq5JlzkUjwSg+k8QFvIsUgpK M2yLL7EnWpeF5mmVDkZSaZDl/6xPX93V2BsnA9Sao1QctGwNmYpW7N04XOc3+fZ/4x8n BTJKmJFLhbizrHfchbcuYO9mNYZQtLKpHTGWRcvCgPJATdQ0uvThgnBO2YbmNkT+D2kj M19A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nSiZLD5Q; spf=pass (google.com: domain of linux-wireless+bounces-1288-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1288-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a192-20020a6390c9000000b005cdfd4e80a0si7207122pge.800.2023.12.26.16.01.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 16:01:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1288-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nSiZLD5Q; spf=pass (google.com: domain of linux-wireless+bounces-1288-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1288-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A8A89283319 for ; Wed, 27 Dec 2023 00:01:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1FD3A2D; Wed, 27 Dec 2023 00:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nSiZLD5Q" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9176D5384; Wed, 27 Dec 2023 00:01:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D34E4C433C7; Wed, 27 Dec 2023 00:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703635286; bh=QD6esAQC2zUHMhdcnID2iNc0cTpprT0pIKR+PaI0cRI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nSiZLD5QD83Yy6uWll+7uVy99sjqNnEuLgMgpABkq6i3uMWNPE3XB3QOikJFnc/fh 9RuiSoI1eCn2DvOWLvslq20tdKiwOvJ45MO8ydwM6FRAM3krPe6ZQAHwPPFz5AUo3m 6kMOCWM0HYuYNqTCewW/7Ue41tgh6SjCPRw9Eyu4GcJ3TsxYZgozV4PvpJcjhb3ROz TS89+/k8ZuYRr2lWCrcYT/G3kPvn5r55BGnAFievDz7kvA/LHE30rZa/oPpMQSECy0 PPzrb+8XBEXGFzYCxkSMx1hNEt7WmWnjjtsex4+HjzxxjLQAny7ZzkbjKkR6t4Zsva mW1OYKrmCLBdQ== Date: Tue, 26 Dec 2023 18:01:24 -0600 From: Bjorn Helgaas To: Mathias Krause Cc: Bjorn Helgaas , Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH] PCI: Remove unused 'node' member from struct pci_driver Message-ID: <20231227000124.GA1484252@bhelgaas> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220133505.8798-1-minipli@grsecurity.net> On Wed, Dec 20, 2023 at 02:35:05PM +0100, Mathias Krause wrote: > Remove the unused 'node' member. It got replaced by device_driver > chaining more than 20 years ago in commit 4b4a837f2b57 ("PCI: start to > use common fields of struct device_driver more...") of the history.git > tree. > > Signed-off-by: Mathias Krause Applied with Kalle's ack to pci/misc for v6.8, thanks! > --- > There is only one "user" that makes use of the 'node' member, which is > the brcm80211 driver. However, its "use" is clearly wrong (a list head > cannot be initialized this way) and, obviously, not needed. > > If netdev folks instead want to split this off into a separate commit, I > can do that. However, I don't expect any cross-tree conflicts regarding > this change. > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 - > include/linux/pci.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > index 80220685f5e4..d7fb88bb6ae1 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > @@ -2707,7 +2707,6 @@ MODULE_DEVICE_TABLE(pci, brcmf_pcie_devid_table); > > > static struct pci_driver brcmf_pciedrvr = { > - .node = {}, > .name = KBUILD_MODNAME, > .id_table = brcmf_pcie_devid_table, > .probe = brcmf_pcie_probe, > diff --git a/include/linux/pci.h b/include/linux/pci.h > index dea043bc1e38..835a937fd233 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -885,7 +885,6 @@ struct module; > > /** > * struct pci_driver - PCI driver structure > - * @node: List of driver structures. > * @name: Driver name. > * @id_table: Pointer to table of device IDs the driver is > * interested in. Most drivers should export this > @@ -940,7 +939,6 @@ struct module; > * own I/O address space. > */ > struct pci_driver { > - struct list_head node; > const char *name; > const struct pci_device_id *id_table; /* Must be non-NULL for probe to be called */ > int (*probe)(struct pci_dev *dev, const struct pci_device_id *id); /* New device inserted */ > -- > 2.39.2 >