Received-SPF: pass (google.com: domain of linux-wireless+bounces-1380-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jes Sorensen <jes.sorensen@gmail.com>
Message-ID: <16be98c1-3b64-f8e3-9350-e61dadb7f008@gmail.com>
Date: Mon, 1 Jan 2024 08:12:50 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] wifi: rtl8xxxu: Fix off by one initial RTS rate
Content-Language: en-US
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>
References: <be0427a7-f85f-449e-a6c8-b1c8371c39b0@gmail.com>
In-Reply-To: <be0427a7-f85f-449e-a6c8-b1c8371c39b0@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 12/31/23 17:19, Bitterblue Smith wrote:
> rtl8xxxu_set_basic_rates() sets the wrong initial RTS rate. It sets the
> next higher rate than the one it should set, e.g. 36M instead of 24M.
> 
> The while loop is supposed to find the index of the most significant
> bit which is 1.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Signed-off-by: Jes Sorensen <Jes.Sorensen@gmail.com>