Received-SPF: pass (google.com: domain of linux-wireless+bounces-1466-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9636aec8-8fa3-6129-294a-69dec53276fa@quicinc.com>
Date: Thu, 4 Jan 2024 08:33:52 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 3/3] wifi: ath10k: replace ENOTSUPP with EOPNOTSUPP
To: Jeff Johnson <quic_jjohnson@quicinc.com>, <ath12k@lists.infradead.org>,
        <ath11k@lists.infradead.org>, <ath10k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240103041220.3082014-1-quic_periyasa@quicinc.com>
 <20240103041220.3082014-4-quic_periyasa@quicinc.com>
 <2269025d-d1ef-4940-a438-c67d3d94baf9@quicinc.com>
Content-Language: en-US
From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
In-Reply-To: <2269025d-d1ef-4940-a438-c67d3d94baf9@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/3/2024 10:06 PM, Jeff Johnson wrote:
> On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
>> ENOTSUPP is not a standard error code, don't use it. Replace with
>> EOPNOTSUPP instead.
>>
>> No functional changes, compile tested only.
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>> ---
>> diff --git a/drivers/net/wireless/ath/ath10k/htt.c b/drivers/net/wireless/ath/ath10k/htt.c
>> index 907e1e13871a..3835c5cc07f9 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt.c
>> @@ -2,6 +2,8 @@
>>   /*
>>    * Copyright (c) 2005-2011 Atheros Communications Inc.
>>    * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>> + * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
> You are not working on behalf of The Linux Foundation so you should not
> be adding or modifying Linux Foundation copyrights

Sure


>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> And this should only have 2024 since there were not any Qualcomm changes
> in 2021-2023

Sure


>> diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> index 0ce08e9a0a3d..9a1889599729 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> @@ -3,6 +3,7 @@
>>    * Copyright (c) 2005-2011 Atheros Communications Inc.
>>    * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>>    * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> Again this should only have 2024


Will address in the next version of the patch


Thanks,

Karthikeyan