Received-SPF: pass (google.com: domain of linux-wireless+bounces-1481-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 4 Jan 2024 11:16:10 +0100
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Mingyen Hsieh <mingyen.hsieh@mediatek.com>
Cc: nbd@nbd.name, deren.wu@mediatek.com, Sean.Wang@mediatek.com,
	Soul.Huang@mediatek.com, Leon.Yen@mediatek.com,
	Eric-SY.Chang@mediatek.com, km.lin@mediatek.com,
	robin.chiu@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com,
	Quan.Zhou@mediatek.com, Ryder.Lee@mediatek.com,
	Shayne.Chen@mediatek.com, linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan
 command
Message-ID: <ZZaFaim6nK2ZvVgi@lore-desk>
References: <20240104094845.11276-1-mingyen.hsieh@mediatek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BeFzi6ePts3aTjGP"
Content-Disposition: inline
In-Reply-To: <20240104094845.11276-1-mingyen.hsieh@mediatek.com>


--BeFzi6ePts3aTjGP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan 04, Mingyen Hsieh wrote:
> From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
>=20
> For the member of 'struct scan_req_tlv', replace data type of
> func_mask_ext from 'u8' to 'u32'.
>=20
> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/ne=
t/wireless/mediatek/mt76/mt7925/mcu.h
> index 3c41e21303b1..82b7e277397f 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> @@ -208,7 +208,7 @@ struct scan_req_tlv {
>  	__le16 channel_dwell_time; /* channel Dwell interval */
>  	__le16 timeout_value;
>  	__le16 probe_delay_time;
> -	u8 func_mask_ext;
> +	u32 func_mask_ext;

should it be __le32? (even if it is not used yet)

Regards,
Lorenzo

>  };
> =20
>  struct scan_ssid_tlv {
> --=20
> 2.18.0
>=20

--BeFzi6ePts3aTjGP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZZaFagAKCRA6cBh0uS2t
rMWXAP9dzAp5Gzih9wedLKC/AGU0SBlg0TJE6lBprCWHYoWZCQEAvtSNhH+cxsK/
dKSs8G4dOsxJdzMxmOLTJCyQy6jIyAc=
=9/B7
-----END PGP SIGNATURE-----

--BeFzi6ePts3aTjGP--