Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp62055rdb; Fri, 5 Jan 2024 02:50:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHm1I6PAOtHyei9TWe0lDDfHbXVM4QsmcMWTgM/jfDukYkpXz4qfxsF4LqkCaL8L6+wjdaZ X-Received: by 2002:a05:6a00:6816:b0:6d9:aa18:291c with SMTP id hq22-20020a056a00681600b006d9aa18291cmr1793472pfb.8.1704451837664; Fri, 05 Jan 2024 02:50:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704451837; cv=none; d=google.com; s=arc-20160816; b=p3WS0EBhEmiI1xMlqWI1qaZF9UBKDkfarbrYB98/oHDqGBYYZHTFuxUOYUetNXmT9g 1wbEaxoefuJJ82ABzbvLWXz7S6x9RIMXh70GjMiPztd74kZ0bvRFNtV0Xy6HflrNBAxP cdWHCv8qdSGMfvibKgRs2wTkKvkaCvwNCx7z8qHD2jlRIbM8EsFHCd7Nk6jt8my1xZXh K9aD6+V8PFD6AzYVV7tJezwJYdj92j5XlkkzmXTVZJpQzoLVLCJsYFWxF3WPHJ+xLQEl LSfA5BTe/+hTDdVQEC4Sm64fFG4MRtbZbYDHBq7qjp4XDy0swr56o8LH2YPzI0RYd1M5 hbEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=aHrqIVOtlCst+VZclgFwaJyl+OwinVcSYJTDBNm4otE=; fh=z1/AQD1g6G6D1jp+a06KxL/MCKYQxjwiv2AdGqgVLz0=; b=B7sJN/4U5FfkLkSW7HkvWUXgizuxzD1JV0NHrluHBJWrlV4nuepq4N+b7JIzrDHvt/ hHTRX3EOvoPsh7ttj1CGpRpXv99LWz+Y9upKBlieQehvJ/cTrdV2loLJWQ9lJmp1lTHL Vx7D8SnHF6/7frVfjP69exhxPGZVSO0BZMONMmDwRXWqLsypzkZ4LGz06vcHQLJnvMhq cJfVvBTXPGl2EMtN+Kwm7cmxRt+gD85Rarc/qsYGwcb6i8NTahxCfG2M9KuG4TqDEJDP VtXflfWEg1Wf92z69+bvkXddADUwNwHDOfH1Pk4YwHStCXSqv1qJ1x9wQFwaarbXndbZ 2SiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=fDSkjsAl; spf=pass (google.com: domain of linux-wireless+bounces-1523-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1523-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 7-20020a630007000000b005cec8e6e8dcsi1091034pga.197.2024.01.05.02.50.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 02:50:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1523-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=fDSkjsAl; spf=pass (google.com: domain of linux-wireless+bounces-1523-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1523-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 597CC282CBB for ; Fri, 5 Jan 2024 10:50:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A11528DDD; Fri, 5 Jan 2024 10:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="fDSkjsAl" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A681288B6 for ; Fri, 5 Jan 2024 10:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=aHrqIVOtlCst+VZclgFwaJyl+OwinVcSYJTDBNm4otE=; t=1704451832; x=1705661432; b=fDSkjsAlPR497yU/A1t5sqn4WG+p6NcwoXF4Q8CRSrQ/yi9 MA8Lc8OpNdO4NYpnQVYtS9jDZZigUwItbZ/NfCzrjSCD8HsDzKvtMVRQX8NkONXwxjcPAj4jSfVch dZuhedr5on+Xg0djhxxsKjWdsk8XAvR7nNyp9LA6UTW9dRgGw2D9d1Yp73v7Aw6hNPAPG8Kgq0xUP 6daB+hTAm9M9scMzdYHfVWnLUUAEAIOpkdtUNU1dHmiVMZSimehBMz4K9dit6U1jZoDRrNzIFoLmf UUmNZppiqCbLhvJC0alJurWmhEZ0X06FqsU51q9a/Er+z5YtTkkAhNhjiQzKMHpQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rLhmO-000000060RA-015J; Fri, 05 Jan 2024 11:50:20 +0100 Message-ID: Subject: Re: [PATCH] wifi: rtw89: 8852b: fix cppcheck issues From: Johannes Berg To: lilinmao , linux-wireless@vger.kernel.org Cc: pkshih@realtek.com, kvalo@kernel.org Date: Fri, 05 Jan 2024 11:50:18 +0100 In-Reply-To: <20240105104542.463834-1-lilinmao@kylinos.cn> References: <20240105104542.463834-1-lilinmao@kylinos.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Fri, 2024-01-05 at 18:45 +0800, lilinmao wrote: > cppcheck reports [snip] Look ... you really should write up an explanation of what the patch is doing, whether the tool is correct or not, etc. Please don't blindly paste some checker messages and make random changes to the code to suppress them. We get too many such patches. Convince us with a useful commit message that you've actually thought about it. > Fixes: f2abe804e823 ("wifi: rtw89: 8852b: rfk: add IQK") Really not much point in that, since it clearly doesn't actually _fix_ anything. johannes