Received-SPF: pass (google.com: domain of linux-wireless+bounces-1561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: lilinmao <lilinmao@kylinos.cn>,
        "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
CC: "kvalo@kernel.org" <kvalo@kernel.org>
Subject: RE: [PATCH] wifi: rtw89: 8852b: fix cppcheck issues
Thread-Topic: [PATCH] wifi: rtw89: 8852b: fix cppcheck issues
Thread-Index: AQHaP8RbPkhvE92icEK7ZcmuR2v5v7DPJ5RQ
Date: Mon, 8 Jan 2024 01:49:07 +0000
Message-ID: <fa53ebc977c9494496c16e311f5a3ad2@realtek.com>
References: <20240105104542.463834-1-lilinmao@kylinos.cn>
In-Reply-To: <20240105104542.463834-1-lilinmao@kylinos.cn>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: lilinmao <lilinmao@kylinos.cn>
> Sent: Friday, January 5, 2024 6:46 PM
> To: linux-wireless@vger.kernel.org
> Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; lilinmao <lilinm=
ao@kylinos.cn>
> Subject: [PATCH] wifi: rtw89: 8852b: fix cppcheck issues

The subject doesn't address the problem or describe the changes you made.=20
Maybe, you can say "fix out of bounds of iqk_mcc_ch[][] array", but actuall=
y
cppcheck reported a false alarm, doesn't it?

[...]

> Signed-off-by: lilinmao <lilinmao@kylinos.cn>

You should give your real name here as well as "From:" field.=20

> ---
>  drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c
> index 259df67836a0..03dec3f4e7ba 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c
> @@ -1388,17 +1388,15 @@ static void _iqk_get_ch_info(struct rtw89_dev *rt=
wdev, enum rtw89_phy_idx phy, u
>         u32 reg_rf18;
>         u32 reg_35c;
>         u8 idx;
> -       u8 get_empty_table =3D false;
>=20
>         for (idx =3D 0; idx < RTW89_IQK_CHS_NR; idx++) {
>                 if (iqk_info->iqk_mcc_ch[idx][path] =3D=3D 0) {
> -                       get_empty_table =3D true;
>                         break;
>                 }
>         }
>         rtw89_debug(rtwdev, RTW89_DBG_RFK, "[IQK] (1)idx =3D %x\n", idx);
>=20
> -       if (!get_empty_table) {
> +       if (idx > RTW89_IQK_CHS_NR - 1) {
>                 idx =3D iqk_info->iqk_table_idx[path] + 1;
>                 if (idx > 1)
>                         idx =3D 0;

The original logic looks like

bool found =3D false;

for (idx =3D 0; idx < RTW89_IQK_CHS_NR; idx++)
     if (expr) {
		found =3D true;
		break;
	}

if (!found) {=20
	... [A]
}

So, idx >=3D RTW89_IQK_CHS_NR must fall into branch [A]. Can you report thi=
s
pattern to cppcheck?

Ping-Ke=20