Received-SPF: pass (google.com: domain of linux-wireless+bounces-1618-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kalle Valo <kvalo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,  "David S . Miller"
 <davem@davemloft.net>,  Eric Dumazet <edumazet@google.com>,  Jakub
 Kicinski <kuba@kernel.org>,  Paolo Abeni <pabeni@redhat.com>,  Rob Herring
 <robh+dt@kernel.org>,  Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>,  Conor Dooley <conor+dt@kernel.org>,
  Bjorn Andersson <andersson@kernel.org>,  Konrad Dybcio
 <konrad.dybcio@linaro.org>,  Catalin Marinas <catalin.marinas@arm.com>,
  Will Deacon <will@kernel.org>,  Bjorn Helgaas <bhelgaas@google.com>,
  Heiko Stuebner <heiko@sntech.de>,  Jernej Skrabec
 <jernej.skrabec@gmail.com>,  Chris Morgan <macromorgan@hotmail.com>,
  Linus Walleij <linus.walleij@linaro.org>,  Geert Uytterhoeven
 <geert+renesas@glider.be>,  Arnd Bergmann <arnd@arndb.de>,  Neil Armstrong
 <neil.armstrong@linaro.org>,  =?utf-8?Q?N=C3=ADcolas?= F . R . A . Prado
 <nfraprado@collabora.com>,  Marek Szyprowski <m.szyprowski@samsung.com>,
  Peng Fan <peng.fan@nxp.com>,  Robert Richter <rrichter@amd.com>,  Dan
 Williams <dan.j.williams@intel.com>,  Jonathan Cameron
 <Jonathan.Cameron@huawei.com>,  Terry Bowman <terry.bowman@amd.com>,
  Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
  Ilpo =?utf-8?Q?J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,  Huacai
 Chen
 <chenhuacai@kernel.org>,  Alex Elder <elder@linaro.org>,  Srini Kandagatla
 <srinivas.kandagatla@linaro.org>,  Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>,  linux-wireless@vger.kernel.org,
  netdev@vger.kernel.org,  devicetree@vger.kernel.org,
  linux-kernel@vger.kernel.org,  linux-arm-msm@vger.kernel.org,
  linux-arm-kernel@lists.infradead.org,  linux-pci@vger.kernel.org,
  Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RFC 7/9] dt-bindings: wireless: ath11k: describe QCA6390
References: <20240104130123.37115-1-brgl@bgdev.pl>
	<20240104130123.37115-8-brgl@bgdev.pl>
	<82a669f5-259d-427c-b290-6fa1470fec79@linaro.org>
Date: Tue, 09 Jan 2024 11:13:54 +0200
In-Reply-To: <82a669f5-259d-427c-b290-6fa1470fec79@linaro.org> (Krzysztof
	Kozlowski's message of "Thu, 4 Jan 2024 16:57:52 +0100")
Message-ID: <87o7duzx65.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> On 04/01/2024 14:01, Bartosz Golaszewski wrote:
>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> index 817f02a8b481..f584c25f4276 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> @@ -16,6 +16,7 @@ description: |
>>  properties:
>>    compatible:
>>      enum:
>> +      - pci17cb,1101  # QCA6390
>>        - pci17cb,1103  # WCN6855
>>  
>>    reg:
>> @@ -27,6 +28,19 @@ properties:
>>        string to uniquely identify variant of the calibration data for designs
>>        with colliding bus and device ids
>>  
>> +  enable-gpios:
>> +    description: GPIO line enabling the ATH11K module when asserted.
>> +    maxItems: 1
>> +
>> +  vddpmu-supply:
>> +    description: VDD_PMU supply regulator handle
>> +
>> +  vddpcie1-supply:
>> +    description: VDD_PCIE1 supply regulator handle
>> +
>> +  vddpcie2-supply:
>> +    description: VDD_PCIE2 supply regulator handle
>
> Looks like these are valid only for specific variant, so you should have
> allOf:if:then disallowing other properties when not applicable. The same
> applies for existing properties which might not exist on qca6390.

And it would be good to provide more information in the commit log about
the platforms where this is used, otherwise the context might not be
clear. Or maybe document that in the bindings file, not sure.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches