Received-SPF: pass (google.com: domain of linux-wireless+bounces-1635-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kalle Valo <kvalo@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Chen-Yu Tsai" <wenst@chromium.org>,  "Jeff Johnson"
 <quic_jjohnson@quicinc.com>,  "Bartosz Golaszewski" <brgl@bgdev.pl>,
  "David S . Miller" <davem@davemloft.net>,  "Eric Dumazet"
 <edumazet@google.com>,  "Jakub Kicinski" <kuba@kernel.org>,  "Paolo Abeni"
 <pabeni@redhat.com>,  "Rob Herring" <robh+dt@kernel.org>,  "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,  "Conor Dooley"
 <conor+dt@kernel.org>,  "Bjorn Andersson" <andersson@kernel.org>,  "Konrad
 Dybcio" <konrad.dybcio@linaro.org>,  "Catalin Marinas"
 <catalin.marinas@arm.com>,  "Will Deacon" <will@kernel.org>,  "Bjorn
 Helgaas" <bhelgaas@google.com>,  Heiko =?utf-8?Q?St=C3=BCbner?=
 <heiko@sntech.de>,  "Jernej
 Skrabec" <jernej.skrabec@gmail.com>,  "Chris Morgan"
 <macromorgan@hotmail.com>,  "Linus Walleij" <linus.walleij@linaro.org>,
  "Geert Uytterhoeven" <geert+renesas@glider.be>,  "Neil Armstrong"
 <neil.armstrong@linaro.org>,  =?utf-8?Q?N=C3=ADcolas?= F. R. A. Prado
 <nfraprado@collabora.com>,  "Marek Szyprowski" <m.szyprowski@samsung.com>,
  "Peng Fan" <peng.fan@nxp.com>,  "Robert Richter" <rrichter@amd.com>,
  "Dan Williams" <dan.j.williams@intel.com>,  "Jonathan Cameron"
 <Jonathan.Cameron@huawei.com>,  "Terry Bowman" <terry.bowman@amd.com>,
  "Kuppuswamy Sathyanarayanan"
 <sathyanarayanan.kuppuswamy@linux.intel.com>,  Ilpo =?utf-8?Q?J=C3=A4rvin?=
 =?utf-8?Q?en?=
 <ilpo.jarvinen@linux.intel.com>,  "Huacai Chen" <chenhuacai@kernel.org>,
  "Alex Elder" <elder@linaro.org>,  "Srinivas Kandagatla"
 <srinivas.kandagatla@linaro.org>,  "Greg Kroah-Hartman"
 <gregkh@linuxfoundation.org>,  linux-wireless@vger.kernel.org,  Netdev
 <netdev@vger.kernel.org>,  devicetree@vger.kernel.org,
  linux-kernel@vger.kernel.org,  linux-arm-msm@vger.kernel.org,
  linux-arm-kernel@lists.infradead.org,  linux-pci@vger.kernel.org,
  "Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>
Subject: Re: [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390
References: <20240104130123.37115-1-brgl@bgdev.pl>
	<20240104130123.37115-9-brgl@bgdev.pl>
	<15443d5d-6544-45d0-afeb-b23e6a041ecf@quicinc.com>
	<87jzoizwz7.fsf@kernel.org>
	<CAGXv+5FhYY+qyyT8wxY5DggvWPibfM2ypHVKQbsJZ30VkZDAkQ@mail.gmail.com>
	<87bk9uzum9.fsf@kernel.org>
	<5904461c-ca3c-4eb1-a44a-876872234545@app.fastmail.com>
Date: Tue, 09 Jan 2024 18:43:38 +0200
In-Reply-To: <5904461c-ca3c-4eb1-a44a-876872234545@app.fastmail.com> (Arnd
	Bergmann's message of "Tue, 09 Jan 2024 11:14:43 +0100")
Message-ID: <87y1cycv9h.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

"Arnd Bergmann" <arnd@arndb.de> writes:

> On Tue, Jan 9, 2024, at 11:09, Kalle Valo wrote:
>
>> Chen-Yu Tsai <wenst@chromium.org> writes:
>>> On Tue, Jan 9, 2024 at 5:18=E2=80=AFPM Kalle Valo <kvalo@kernel.org> wr=
ote:
>>>> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>>>
>>>> > On 1/4/2024 5:01 AM, Bartosz Golaszewski wrote:
>>>> >> diff --git a/drivers/pci/pcie/pwrseq/Kconfig b/drivers/pci/pcie/pwr=
seq/Kconfig
>>>> >> index 010e31f432c9..f9fe555b8506 100644
>>>> >> --- a/drivers/pci/pcie/pwrseq/Kconfig
>>>> >> +++ b/drivers/pci/pcie/pwrseq/Kconfig
>>>> >> @@ -6,3 +6,14 @@ menuconfig PCIE_PWRSEQ
>>>> >>      help
>>>> >>        Say yes here to enable support for PCIe power sequencing
>>>> >>        drivers.
>>>> >> +
>>>> >> +if PCIE_PWRSEQ
>>>> >> +
>>>> >> +config PCIE_PWRSEQ_QCA6390
>>>> >> +    tristate "PCIe Power Sequencing driver for QCA6390"
>>>> >> +    depends on ARCH_QCOM || COMPILE_TEST
>>>> >> +    help
>>>> >> +      Enable support for the PCIe power sequencing driver for the
>>>> >> +      ath11k module of the QCA6390 WLAN/BT chip.
>>>> >> +
>>>> >> +endif
>>>> >
>>>> > As I mentioned in the 5/9 patch I'm concerned that the current
>>>> > definition of PCIE_PWRSEQ and PCIE_PWRSEQ_QCA6390 will effectively h=
ide
>>>> > the fact that QCA6390 may need additional configuration since the me=
nu
>>>> > item will only show up if you have already enabled PCIE_PWRSEQ.
>>>> > Yes I see that these are set in the defconfig in 9/9 but I'm concern=
ed
>>>> > about the more generic case.
>>>> >
>>>> > I'm wondering if there should be a separate config QCA6390 within at=
h11k
>>>> > which would then select PCIE_PWRSEQ and PCIE_PWRSEQ_QCA6390
>>>>
>>>> Or is it possible to provide an optional dependency in Kconfig (I guess
>>>
>>> imply PCIE_PWRSEQ
>>> imply PCIE_PWRSEQ_QCA6390
>>> ?
>>
>> Nice, I had forgotten imply altogether. Would 'imply
>> PCIE_PWRSEQ_QCA6390' in ath11k Kconfig be enough to address Jeff's
>> concern?
>
> Please don't use imply (ever), it doesn't normally do
> what you want. In this case, the only effect the
> 'imply' has is to change the default of the PCIE_PWRSEQ_QCA6390
> option when a defconfig contains QCA6390.
>
> If this is indeed what you want, it's still better to do the
> equivalent expression in PCIE_PWRSEQ_QCA6390 rather than ATH11K:
>
> config PCIE_PWRSEQ_QCA6390
>       tristate "PCIe Power Sequencing driver for QCA6390"
>       default ATH11K && ARCH_QCOM

Sounds good to me but should it be 'default ATH11K_PCI && ARCH_QCOM'? My
understanding is that we don't need PWRSEQ for ATH11K_AHB devices.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes