Received-SPF: pass (google.com: domain of linux-wireless+bounces-1644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <56282bad-b59d-4572-a6f1-1b905bf0edbd@quicinc.com>
Date: Wed, 10 Jan 2024 10:16:03 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] wifi: ath11k: add support for QCA2066
Content-Language: en-US
To: Jeff Johnson <quic_jjohnson@quicinc.com>, <ath11k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240109021336.4143-1-quic_bqiang@quicinc.com>
 <20240109021336.4143-3-quic_bqiang@quicinc.com>
 <e19baf59-c17b-4e2b-96d7-f4fc9812c99a@quicinc.com>
From: Baochen Qiang <quic_bqiang@quicinc.com>
In-Reply-To: <e19baf59-c17b-4e2b-96d7-f4fc9812c99a@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 1/10/2024 1:41 AM, Jeff Johnson wrote:
> On 1/8/2024 6:13 PM, Baochen Qiang wrote:
>> QCA2066 is a PCI based DBS device. It is very similar to WCN6855
>> overall: they share the same PCI device ID, the same major and
>> minor version numbers, the same register address, and same HAL
>> descriptors etc. The most significant difference is that QCA2066
>> supports 3-antenna configuration while WCN6855 does not. To differentiate
>> them, subversion numbers are used. Currently four numbers are used
>> by QCA2066: 0x1019A0E1, 0x1019B0E1, 0x1019C0E1 and 0x1019D0E1.
>>
>> Tested-on: QCA2066 hw2.1 PCI WLAN.HSP.1.1-03737-QCAHSPSWPL_V2_SILICONZ_CE-1
>> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>>
>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
>> ---
>> v2:
>>   - Rebased on ToT.
> 
> hmmm, fails to apply using b4 shazam
> 
> Checking attestation on all messages, may take a moment...
> ---
>    ✓ [PATCH v2 1/2] wifi: ath11k: move pci.ops registration ahead
>    ✓ [PATCH v2 2/2] wifi: ath11k: add support for QCA2066
>    ---
>    ✓ Signed: DKIM/quicinc.com
> ---
> Total patches: 2
> ---
>   Base: using specified base-commit 2cd4e3f91f264926a6b11df948417b74d52ca9b9
> Applying: wifi: ath11k: move pci.ops registration ahead
> Applying: wifi: ath11k: add support for QCA2066
> Patch failed at 0002 wifi: ath11k: add support for QCA2066
> error: patch failed: drivers/net/wireless/ath/ath11k/core.c:711
> error: drivers/net/wireless/ath/ath11k/core.c: patch does not apply
> 
> And sure enough the code at drivers/net/wireless/ath/ath11k/core.c:711
> doesn't match the code in the 2nd patch so something is amiss here.
> 
> note your patch has reference to .support_dual_stations that is not
> present in ath11k -- perhaps there are other prerequisites?
> <https://patchwork.kernel.org/project/linux-wireless/patch/20230714023801.2621802-2-quic_cjhuang@quicinc.com/>
Yes, as said in the cover letter, this patch set depends on the above patch.

> 
> /jeff