Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1034740rdd; Wed, 10 Jan 2024 06:55:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IG75gi0bkTLlzRMkOKtLZ0k3mUyehWM6RVFeE0LZSxMA7rGJTROpEVWGadBUqVdAffBvaax X-Received: by 2002:a0d:de82:0:b0:5f6:d6d8:e7b3 with SMTP id h124-20020a0dde82000000b005f6d6d8e7b3mr1201027ywe.39.1704898553386; Wed, 10 Jan 2024 06:55:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704898553; cv=none; d=google.com; s=arc-20160816; b=0hb+4vLExb2XcuOGWqd5OtfMq2iImfYDPCg0h5Uv6k6CMszAT60n+1j8d5cQpIX1p2 26QokraxHwVkqYEnyd4Pi8U84WDTdMLmiW9DjKN6C2gZko0rUCfK8mNLAWBQR+skqzlm ghXPraAxS6gArAVQOryGgystNQPIF0ItNtirIfFbl3vyPGqVM3TJazQMjsOIcZ553Qac zOYYdYMaG5zIBjBaFArITyXVvFOyGyxdGakxRsr+m1+9Ezu6mDx+bhVIFmsQ466I1kqh rCTUfq0qQ0XFNJYvR0qRERsjmURU0QVkCLXPCs2XZzNk44Kh9qrdUEIpfM1stsieD7yH 0baA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=6Q3t3LUGpq1lfNTsIw/srY0ttsozaQvsOGcFwx6XdDw=; fh=ijnblFz+9U46ohYua4fFqRFHGzfO/06OlnYW3oKf9yw=; b=UHw2YDhuE9oz4rZWM5jWhJLcFyOI7fGUj98UCh+ktQVrZHSEXM22hwwMHj5/OmQDGO +/L0uJFHhAfmN6UPeG68/4nsMYX04Ji02I/BonmHD6Hh7NqrdvJVBeSQozf38hkQ50Tu Bpnhz/NmEl7FagzJJVRh0UndOOL1WO+aTtXxzaA2BdvyQBNNLcUqKNlI6e+lkIa6J5c6 /p46Bn4j3TBBM/sgcCx3hTBTsSk6Gk8n8Q95I+i5V0Hcn0YvtrmoILAoAKPVpYs08CLN /QI+3ZF+xjXlMIN3EfKQZKs8KX2xw/cvmgjCeQxA4YIkShad720PgVxhJ8lxRe1GjVIG kBUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ns6YjtcU; spf=pass (google.com: domain of linux-wireless+bounces-1674-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id g6-20020a0ce4c6000000b0067f931f6bfcsi4553550qvm.395.2024.01.10.06.55.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 06:55:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1674-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ns6YjtcU; spf=pass (google.com: domain of linux-wireless+bounces-1674-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2A2E21C20DA3 for ; Wed, 10 Jan 2024 14:55:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B3354BA85; Wed, 10 Jan 2024 14:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ns6YjtcU" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515354BA80 for ; Wed, 10 Jan 2024 14:55:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1D8AC433C7; Wed, 10 Jan 2024 14:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704898549; bh=zk0pp87oBz7+VsnqQfuleDO3N+dplUi06CFqKXcmvYA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ns6YjtcU2ez8mfqSmEhFjoSBHGQdgZDuqw5Z2w+w2wJsDoyBJAyRDQWrzYcFOISne HCAlutoOh6rGjBBptkY67FHSfgZAxIEMTrWlsi5eL2AzeSNZ2g9vSyY1Ncd/OxLS4Z TMZBpQNBkpqjzB2DdE8Ov6qRmVmpv4jdixtpwZGI7xx0ehF3H/xtcTkyWMXqxFXkGQ lMBwPwkGiss1V/5UtLSiKfrITp0x13UeL+ZLJ4oXEFjMWsyRktd1mUxwmhFGeKUJtS Ldez5GyEOTsBjZTgeNk6xxwYanXNYotlDNvaSN9IRGYxyVYTEXiahKkEgo3uSrXdL/ ffBxp3DTfIICg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: rtl8xxxu: Fix off by one initial RTS rate From: Kalle Valo In-Reply-To: <761e6836-6cd6-4930-91b6-0446834655c5@gmail.com> References: <761e6836-6cd6-4930-91b6-0446834655c5@gmail.com> To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Jes Sorensen , Ping-Ke Shih User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170489854669.471554.16245324804512530901.kvalo@kernel.org> Date: Wed, 10 Jan 2024 14:55:48 +0000 (UTC) Bitterblue Smith wrote: > rtl8xxxu_set_basic_rates() sets the wrong initial RTS rate. It sets the > next higher rate than the one it should set, e.g. 36M instead of 24M. > > The while loop was supposed to find the index of the most significant > bit which is 1, but it was copied incorrectly from the vendor driver. > Use __fls() instead. > > Signed-off-by: Bitterblue Smith > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 80850ca041f2 wifi: rtl8xxxu: Fix off by one initial RTS rate -- https://patchwork.kernel.org/project/linux-wireless/patch/761e6836-6cd6-4930-91b6-0446834655c5@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches