Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1574264rdd; Thu, 11 Jan 2024 03:26:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAEm9uVc1NtQVKfptu0cQ72rcz5dnp0CXIcaAV+/ZgQcWlg9awMT0Vcgyl3Xx/OB2pXR7+ X-Received: by 2002:a05:6830:1052:b0:6dd:e6e2:7c05 with SMTP id b18-20020a056830105200b006dde6e27c05mr1033239otp.64.1704972380368; Thu, 11 Jan 2024 03:26:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704972380; cv=none; d=google.com; s=arc-20160816; b=QN/QAD0Usyxl5N3JVXscKa69Qh68OMd1kQwK8d5k4b66cOAPFWpl602Wg2jg3gROnp iEM137mJtCBjbtGKodloWsFaSYncsbDDm7WhBErJwlghg7YN0HVSB4+3ms9OnuN5WkwY SaW9rrQkG8V0MHF5a/ER4YNK0sQeJOShVC7Fm94/Y8oanVjPm5ApdvMUy9X1MFQmqfkv zObS/uYd7kk5Af8YJ/Gli/YfKYPcdD8MwGNNDfTmpkiwjN8DVZL1HXLAjVLAaguDY7ql akA4auwUAeME3W/cI/wZhhjB8viDiv3YXsF8/rS773o1ctpwE6ScNBDPOLBQ8/OK4vbp BBYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=cJxk/req2xq7rnTfx7MegJQK4qFqH1dtbLL+NmEs+S0=; fh=qk7Btv6c3DwTxbN0+X2wCdR0PxdXY1CRlKpXzFEvH70=; b=CiybK2s6EqRAhXT9wNIwA2pnhi3UPTVuTStBbMQ6Nu/qc1w7mLP+ppIgIvDIKMGfXB MTASv0YkfEcIy1Gam0uHsxqJG46zYMHO8g1A5JWPE/5hLNVDa5Fc3EVFZui3an7xEkH5 0mQuhlx3iRZr2QQvQe4jAbTMPSLLdGBTI6B2ubwxL00Sj92Bb9rLScmjd6vmQ+ERUr53 F241uME2qC21kOKhpUn0xoP0LiX4OaVEEzJHo3sw7l1RZLq5BajJLMSO1al+nd0wphw+ 0G7iN7+I5cSfuCPO55ZbCJLZyb4sezsfxj/IsK9B4qNssznzjYcERNEEyAkgTcjPs5v1 EdWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZr061gA; spf=pass (google.com: domain of linux-wireless+bounces-1711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d34-20020a631d62000000b005cdf992367csi902018pgm.691.2024.01.11.03.26.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 03:26:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZr061gA; spf=pass (google.com: domain of linux-wireless+bounces-1711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A3793B21445 for ; Thu, 11 Jan 2024 11:19:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6573156C3; Thu, 11 Jan 2024 11:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oZr061gA" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACFE0156C1 for ; Thu, 11 Jan 2024 11:19:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69410C433C7; Thu, 11 Jan 2024 11:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704971979; bh=Q9/z0JTCs5oAXPg2oz0DSid0D9U8xfCZj5Fj8lNgZhw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=oZr061gAEfGm9VIgIl6pViy+elfHvPvzJVMWcEkkC8QahThUmWL2xUaXBMEV0tR55 o9CfW4SyAgZSjHD/kAHgZQb+VcuBXlx5PT/sfenWfxngYu8BEvtyK8CtItVjFKRuGA 3XEOwg9O6gHTBEoHysXhd9m4rkvCpH21dIhwpxLQFC6da0bJwRdvfEtE8KcrdZqYTL yO2f4on0yzwymFtCGtXUWJ3rfp22X7fWPOb7D95KW4PU6gHKImQQG/H+TS6Cp/Lzn5 nEp3/fRidpDTLh3eSgQO6B/KiHgapSL7dwcov7X/pD3Uxt913eEMZE3+fh3Tkj2sqH /M5lInkddlRSg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: refactor ath12k_wmi_tlv_parse_alloc() From: Kalle Valo In-Reply-To: <20231219091022.70861-1-dmantipov@yandex.ru> References: <20231219091022.70861-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Jeff Johnson , ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170497197672.659902.926273640514593696.kvalo@kernel.org> Date: Thu, 11 Jan 2024 11:19:38 +0000 (UTC) Dmitry Antipov wrote: > Since 'ath12k_wmi_tlv_parse_alloc()' always operates on 'skb->data, > skb->len' tuple, it may be simplified to pass the only 'skb' argument > instead (which implies refactoring of 'ath12k_pull_bcn_tx_status_ev()', > 'ath12k_pull_chan_info_ev()' and 'ath12k_pull_pdev_temp_ev()' in the > same way). This is an ath12k counterpart of the recently submitted > ath11k patch and compile tested only as well. > > Signed-off-by: Dmitry Antipov > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. fba97a777dcb wifi: ath12k: refactor ath12k_wmi_tlv_parse_alloc() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231219091022.70861-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches