Received-SPF: pass (google.com: domain of linux-wireless+bounces-1719-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <26984f36-2f62-4b28-a332-da62a1ea2d3c@gmail.com>
Date: Thu, 11 Jan 2024 16:52:02 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] wifi: rtlwifi: rtl_usb: Use sync register writes
Content-Language: en-US
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
References: <400ec3ff-2ab7-469f-b32f-43dfd62621f9@gmail.com>
 <d3468d464cab444f93a347e1b612ebca@realtek.com>
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <d3468d464cab444f93a347e1b612ebca@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 11/01/2024 03:59, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> Sent: Wednesday, January 10, 2024 9:47 PM
>> To: linux-wireless@vger.kernel.org
>> Cc: Ping-Ke Shih <pkshih@realtek.com>; Larry Finger <Larry.Finger@lwfinger.net>
>> Subject: [PATCH v2] wifi: rtlwifi: rtl_usb: Use sync register writes
>>
>> Currently rtl_usb performs register writes using the async
>> usb_submit_urb() function. This appears to work fine for the RTL8192CU,
>> but the RTL8192DU (soon to be supported by rtlwifi) has a problem:
>> it transmits everything at the 1M rate in the 2.4 GHz band. (The 5 GHz
>> band is still untested.)
>>
>> With this patch, rtl_usb performs the register writes using the
>> synchronous usb_control_msg() function, and the RTL8192DU works
>> normally. The RTL8192CU still works.
>>
>> The vendor drivers use the async writes in only one function,
>> rtl8192du_trigger_gpio_0 / rtl8192cu_trigger_gpio_0, which probably
>> doesn't even run in real life. They use sync writes everywhere else.
>>
>> Also, remove "sync" and "async" from the names of the members of
>> struct rtl_io to avoid confusion:
>>
>> write{8,16,32}_async -> write{8,16,32}
>>  read{8,16,32}_sync  ->  read{8,16,32}
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> 
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
>> ---
>> v2:
>>  - Rename the members of struct rtl_io.
>> ---
>>  drivers/net/wireless/realtek/rtlwifi/pci.c  |  12 +-
>>  drivers/net/wireless/realtek/rtlwifi/usb.c  | 163 ++++++--------------
>>  drivers/net/wireless/realtek/rtlwifi/wifi.h |  30 ++--
>>  3 files changed, 66 insertions(+), 139 deletions(-)
>>
> 
> [...]
> 
>> @@ -114,18 +51,15 @@ static int _usbctrl_vendorreq_sync_read(struct usb_device *udev, u8 request,
>>         } while (++vendorreq_times < MAX_USBCTRL_VENDORREQ_TIMES);
>>
>>         if (status < 0 && count++ < 4)
>> -               pr_err("reg 0x%x, usbctrl_vendorreq TimeOut! status:0x%x value=0x%x\n",
>> -                      value, status, *(u32 *)pdata);
>> -       return status;
>> +               pr_err("reg 0x%x, usbctrl_vendorreq TimeOut! status:0x%x value=0x%x reqtype=0x%x\n",
> 
> nit: Since you touch this, would you like to use dev_err() instead?
> 
Sure, I can do that.

>> +                      value, status, *(u32 *)pdata, reqtype);
>>  }
>>
> 
> [...]
>