Received-SPF: pass (google.com: domain of linux-wireless+bounces-1744-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <93c178cd-8a16-48e5-b352-f14afab07498@quicinc.com>
Date: Thu, 11 Jan 2024 09:13:19 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v10 07/12] wifi: ath11k: add parse of transmit power
 envelope element
Content-Language: en-US
To: Baochen Qiang <quic_bqiang@quicinc.com>, <ath11k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20231218085844.2658-1-quic_bqiang@quicinc.com>
 <20231218085844.2658-8-quic_bqiang@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20231218085844.2658-8-quic_bqiang@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 12/18/2023 12:58 AM, Baochen Qiang wrote:
> +/**
> + * struct reg_tpc_power_info - regulatory TPC power info

Kalle,

just spotted this kernel-doc issue in the pending branch

s/reg_tpc_power_info/ath11k_reg_tpc_power_info/

can you update?

> + * @is_psd_power: is PSD power or not
> + * @eirp_power: Maximum EIRP power (dBm), valid only if power is PSD
> + * @ap_power_type: type of power (SP/LPI/VLP)
> + * @num_pwr_levels: number of power levels
> + * @reg_max: Array of maximum TX power (dBm) per PSD value
> + * @ap_constraint_power: AP constraint power (dBm)
> + * @tpe: TPE values processed from TPE IE
> + * @chan_power_info: power info to send to firmware
> + */
> +struct ath11k_reg_tpc_power_info {
> +	bool is_psd_power;
> +	u8 eirp_power;
> +	enum wmi_reg_6ghz_ap_type ap_power_type;
> +	u8 num_pwr_levels;
> +	u8 reg_max[IEEE80211_MAX_NUM_PWR_LEVEL];
> +	u8 ap_constraint_power;
> +	s8 tpe[IEEE80211_MAX_NUM_PWR_LEVEL];
> +	struct chan_power_info chan_power_info[IEEE80211_MAX_NUM_PWR_LEVEL];
> +};