Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1989914rdd; Thu, 11 Jan 2024 16:16:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfZ/RzYX9GlTWbUutLyXPDvXPEPw9eJuFjv7yJ7bzHnBH8MAFWFH9TlCRkiz1KiWv6vFtq X-Received: by 2002:a05:6a20:1442:b0:19a:3d00:cec8 with SMTP id a2-20020a056a20144200b0019a3d00cec8mr179015pzi.95.1705018564610; Thu, 11 Jan 2024 16:16:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705018564; cv=none; d=google.com; s=arc-20160816; b=SsGpSHWfu/Zyef976m1WeFEzuPWm1o9QGacR7irpGGuMCwtlEjQxR2OKH0OnoJ0y1s C+q4TGQ7ht0FPiecJ9EfiVCTwAgCee9ZhZXCPiLRark8byS5mfc9r5BFx8gzHWhVyRSH GUjaMXLnqW59lstCWxPhsTy4KVXoFmSroBm8QRfalHLj32yGNrpBDHSJFmFPvTvylgRP DIGJXAdzH4OMOL5MRGNQCE35FYjJYFxqdTycLOeiayYMjr+Xu2IHsixPF1uPiP/vDpxv TJAQ73+tP6ZydA22IVlEvpgfa9ttBtSG1Bg+eHoxaOt0sQBFcxOYIl8YJVRiDgYO7z+d C8vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :content-transfer-encoding:content-language:accept-language :in-reply-to:references:message-id:date:thread-index:thread-topic :subject:cc:to:from; bh=D9O8AzR5eqXudN9Dr4s3fIYW0DmmU6tQYKUnLzXohns=; fh=LQGtYe9vP0onFiP/6l3tkQw/DADLCp+GjsQcHD3gn8k=; b=RVj6W2YqOHoz4Dq+id3OpdTWJhUyvm2E+K97u012lPLyfjBOT32mOwTiHxKvPR03L+ An7PrMPeM2tchgl6d7hErq7uP0aB//beFkF1vypYJeyJkdQpxFBrlMnaaKTKxSSs1RtZ jnLfM7w42HkuMVXEAxhdUVGbee/lov/R9V6qQh2gxDxgfDsJD6PfTshQFYdO23BOTn5C AU72TENy5pMv/rWEOM13Rd9Ux44EksDvRtqUJbWQwZMYuSewlmE7yEyg4ws7CZR0Qgbd BrotW3tbzpHrh9NAmE0VZFTkidGW/HbBsE/9I7WybQgdc2JDOSVHBUAkhnZGpJPxygQu oxuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless+bounces-1757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1757-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id a3-20020a17090a854300b0028deefb1a46si1564815pjw.120.2024.01.11.16.16.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 16:16:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless+bounces-1757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1757-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 910CDB21DBE for ; Fri, 12 Jan 2024 00:14:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 553FB1379; Fri, 12 Jan 2024 00:14:43 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6675F136B for ; Fri, 12 Jan 2024 00:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 40C0EOMs81985039, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 40C0EOMs81985039 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jan 2024 08:14:24 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 12 Jan 2024 08:14:24 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 12 Jan 2024 08:14:23 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e4c4:c4f:4e4c:d23c]) by RTEXMBS04.realtek.com.tw ([fe80::e4c4:c4f:4e4c:d23c%5]) with mapi id 15.01.2507.035; Fri, 12 Jan 2024 08:14:23 +0800 From: Ping-Ke Shih To: Martin Kaistra , "linux-wireless@vger.kernel.org" CC: Jes Sorensen , Kalle Valo , Bitterblue Smith , Sebastian Andrzej Siewior Subject: RE: [PATCH v3 1/2] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work Thread-Topic: [PATCH v3 1/2] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work Thread-Index: AQHaRKxg7hfds5acFkOg9DGQNk8bXLDVTxDw Date: Fri, 12 Jan 2024 00:14:23 +0000 Message-ID: References: <20240111163628.320697-1-martin.kaistra@linutronix.de> <20240111163628.320697-2-martin.kaistra@linutronix.de> In-Reply-To: <20240111163628.320697-2-martin.kaistra@linutronix.de> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-kse-serverinfo: RTEXDAG01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback > -----Original Message----- > From: Martin Kaistra > Sent: Friday, January 12, 2024 12:36 AM > To: linux-wireless@vger.kernel.org > Cc: Jes Sorensen ; Kalle Valo ;= Ping-Ke Shih > ; Bitterblue Smith ; Sebasti= an Andrzej Siewior > > Subject: [PATCH v3 1/2] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd= _work >=20 > The workqueue might still be running, when the driver is stopped. To > avoid a use-after-free, call cancel_work_sync() in rtl8xxxu_stop(). >=20 > Fixes: e542e66b7c2e ("rtl8xxxu: add bluetooth co-existence support for si= ngle antenna") > Signed-off-by: Martin Kaistra Reviewed-by: Ping-Ke Shih