Received-SPF: pass (google.com: domain of linux-wireless+bounces-1763-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <285b84d0-229c-4c83-a7d6-4c3c23139597@quicinc.com>
Date: Fri, 12 Jan 2024 10:04:24 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: ath11k and vfio-pci support
Content-Language: en-US
To: James Prestwood <prestwoj@gmail.com>, Kalle Valo <kvalo@kernel.org>
CC: <linux-wireless@vger.kernel.org>, <ath11k@lists.infradead.org>
References: <adcb785e-4dc7-4c4a-b341-d53b72e13467@gmail.com>
 <8734v5zhol.fsf@kernel.org> <87fa5220-6fd9-433d-879b-c55ac67a0748@gmail.com>
 <87r0ipcn7j.fsf@kernel.org> <356e0b05-f396-4ad7-9b29-c492b54af834@gmail.com>
 <26119c3f-9012-47bb-948e-7e976d4773a7@quicinc.com>
 <87mstccmk6.fsf@kernel.org> <df9fd970-5af3-468c-b1f1-18f91215cf44@gmail.com>
 <8734v4auc4.fsf@kernel.org> <e8878979-1f3f-4635-a716-9ac381c617d9@gmail.com>
From: Baochen Qiang <quic_bqiang@quicinc.com>
In-Reply-To: <e8878979-1f3f-4635-a716-9ac381c617d9@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 1/11/2024 9:38 PM, James Prestwood wrote:
> 
> On 1/11/24 5:11 AM, Kalle Valo wrote:
>> James Prestwood <prestwoj@gmail.com> writes:
>>
>>> Hi Kalle, Baochen,
>>>
>>> On 1/11/24 12:16 AM, Kalle Valo wrote:
>>>> Baochen Qiang <quic_bqiang@quicinc.com> writes:
>>>>
>>>>> On 1/10/2024 10:55 PM, James Prestwood wrote:
>>>>>> Hi Kalle,
>>>>>> On 1/10/24 5:49 AM, Kalle Valo wrote:
>>>>>>> James Prestwood <prestwoj@gmail.com> writes:
>>>>>>>
>>>>>>>>> But I have also no idea what is causing this, I guess we are doing
>>>>>>>>> something wrong with the PCI communication? That reminds me, 
>>>>>>>>> you could
>>>>>>>>> try this in case that helps:
>>>>>>>>>
>>>>>>>>> https://patchwork.kernel.org/project/linux-wireless/patch/20231212031914.47339-1-imguzh@gmail.com/
>>>>>>>> Heh, I saw this pop up a day after I sent this and was 
>>>>>>>> wondering. Is
>>>>>>>> this something I'd need on the host kernel, guest, or both?
>>>>>>> On the guest where ath11k is running. I'm not optimistic that 
>>>>>>> this would
>>>>>>> solve your issue, I suspect there can be also other bugs, but 
>>>>>>> good to
>>>>>>> know if the patch changes anything.
>>>>>> Looks the same here, didn't seem to change anything based on the
>>>>>> kernel logs.
>>>>>>
>>>>> Could you try this?
>>>>>
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/ath/ath11k/pci.c?id=39564b475ac5a589e6c22c43a08cbd283c295d2c
>>>> This reminds me, I assumed James was testing with ath.git master branch
>>>> (which has that commit) but I never checked that. So for testing please
>>>> always use the master branch to get the latest and greatest ath11k:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/
>>>>
>>>> There's a quite long delay from ath.git to official releases.
>>> Good to know, and I was not in fact using that branch. Rebuilt from
>>> ath.git/master but still roughly the same behavior. There does appear
>>> to be more output now though, specifically a firmware crash:
>>>
>>> [    2.281721] ath11k_pci 0000:00:06.0: failed to receive control
>>> response completion, polling..
>>> [    2.282101] ip (65) used greatest stack depth: 12464 bytes left
>>> [    3.306039] ath11k_pci 0000:00:06.0: Service connect timeout
>>> [    3.307588] ath11k_pci 0000:00:06.0: failed to connect to HTT: -110
>>> [    3.309286] ath11k_pci 0000:00:06.0: failed to start core: -110
>>> [    3.519637] ath11k_pci 0000:00:06.0: firmware crashed: MHI_CB_EE_RDDM
>>> [    3.519678] ath11k_pci 0000:00:06.0: ignore reset dev flags 0x4000
>>> [    3.627087] ath11k_pci 0000:00:06.0: firmware crashed: MHI_CB_EE_RDDM
>>> [    3.627129] ath11k_pci 0000:00:06.0: ignore reset dev flags 0x4000
>>> [   13.802105] ath11k_pci 0000:00:06.0: failed to wait wlan mode
>>> request (mode 4): -110
>>> [   13.802175] ath11k_pci 0000:00:06.0: qmi failed to send wlan mode
>>> off: -110
>> Ok, that's progress now. Can you try next try the iommu patch[1] we
>> talked about earlier? It's already in master-pending branch (along with
>> other pending patches) so you can use that branch if you want.
>>
>> [1] 
>> https://patchwork.kernel.org/project/linux-wireless/patch/20231212031914.47339-1-imguzh@gmail.com/
> 
> Same result unfortunately, tried both with just [1] applied to ath.git 
> and at HEAD of master-pending.
> 
> Thanks,
> 
> James
Strange that still fails. Are you now seeing this error in your host or 
your Qemu? or both?
Could you share your test steps? And if you can share please be as 
detailed as possible since I'm not familiar with passing WLAN hardware 
to a VM using vfio-pci.
> 
>