Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2432547rdd; Fri, 12 Jan 2024 09:11:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCxIIPnmEwy3jcd1qR3SiZQ7xYObBnJF+Y2ptt/G/DYjMuah4j12LFQe4NVDEdtE3MwJqj X-Received: by 2002:ad4:5bef:0:b0:680:d2e7:e2dd with SMTP id k15-20020ad45bef000000b00680d2e7e2ddmr2004391qvc.28.1705079490002; Fri, 12 Jan 2024 09:11:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705079489; cv=none; d=google.com; s=arc-20160816; b=WaXG/VMc5gMbao9aPfnWK+aUv/RBo4hAvyXOi/rh0a6UEhWO6M+BsMu83zLXniRhR8 bbyMXOE8Yau+v49ynU3ullyXa+aiTk68PA6k7Uttwl7OaTMxMdprRv51otrctQ6mBmPq B+ics1Jt8hqdY71q0V8scgmqozfqquycOJgnVGq9GGWlMMmm/vIaOuK4NnBQKW+1ZALP STTCET4zHBVKCVJaaAc20/zvjsBRZUUwdRDd0hgrGs17qQ6XakVfp7s8vvaL9DOiYLfb m4NIfLJTTCCJw+a3WH4whX9c5zbEq22KOrptHKabC4BFYIrr6xODYH0Z518jE36Dk5ws CH1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=aRp49dbiwgqfyIXpIKtoWePS7EFkwbo1kejuMz6RTWA=; fh=GCRpT/7dbLSsQAWbCa8UoWpPButACfBkfM7tAyJ3xhE=; b=EfSoI0clX1k6LGhWRyqevuVHfZQzcJFiPNbEFxdBwoKs2dRKxXdnHzR1c0DIb8gAl4 nXupkPQw+dJjhW68JeXU2xBBbClp0JL9PwVnxoG0Cm3plDM6L5a3ovrjzGUJzYkoIUym Wryrp+pMr6ZHJmCQJriw6D01nzR4dVlfVALiNVOGl3pWkC6ZRjxUu6zcjJnID/v2IcCk JpPTy4xscDh9HMnMtaAhoGcqvdhvy/INS0AyyBPOnbTFKk5tL6CPtVBW/Zl4eHCtQnIB 1R/5/UhxuTVcSHBIjT0HiJx2isI+F59TIwQPb8ALczOHtXE/w1VxS9rVvyU43j7PJZrl BkjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XKzIv6Td; spf=pass (google.com: domain of linux-wireless+bounces-1829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t10-20020a0cb70a000000b0068028d46496si3254626qvd.409.2024.01.12.09.11.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 09:11:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XKzIv6Td; spf=pass (google.com: domain of linux-wireless+bounces-1829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B8A8D1C21DAD for ; Fri, 12 Jan 2024 17:11:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE36F1AACC; Fri, 12 Jan 2024 17:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="XKzIv6Td" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403B31AABE for ; Fri, 12 Jan 2024 17:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40CFJnJY023887; Fri, 12 Jan 2024 17:10:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=aRp49dbiwgqfyIXpIKtoWePS7EFkwbo1kejuMz6RTWA=; b=XK zIv6Td41T9eIwIhzAmFaRvz7k/aaaVRCJq43a7b/teaDjK6lEKffmLj4n1WHT2Kb klwoY9xf0bASYB9WfZKbOGJu8MobmSb5PralS3JBnIGoALnrSXr1FIdW2ujYTrBv mcKhWS6lqmHYag2Sd0dB34JmKbSO+tBrx2531rJCLeYGnU7uRYZRfXQBWGXkZ0Hj 6OP+LuQIxwpVqd/6NdiT1FrUhPQcKEs9G+0ieFreENSI/1/3SRd+pbpleKkhyTo0 XeWB5hLjP82xu0ADKU4PN5iBTPwriSpgO2bWjXFMWS5vHuFUCm8h1GZEnLM9CJ/E FWSZdJe0P3X4PnkSi/Wg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vk43xgrhy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 17:10:52 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40CHApHu007161 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 17:10:51 GMT Received: from [10.110.16.29] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 12 Jan 2024 09:10:50 -0800 Message-ID: Date: Fri, 12 Jan 2024 09:10:50 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/12] wifi: ath12k: vdev statemachine changes for single wiphy Content-Language: en-US To: Sriram R , CC: References: <20240111045045.28377-1-quic_srirrama@quicinc.com> <20240111045045.28377-5-quic_srirrama@quicinc.com> From: Jeff Johnson In-Reply-To: <20240111045045.28377-5-quic_srirrama@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: PxVIorMHZUTC2GAiw9vysveQBFUM0vFq X-Proofpoint-GUID: PxVIorMHZUTC2GAiw9vysveQBFUM0vFq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=656 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401120135 On 1/10/2024 8:50 PM, Sriram R wrote: > With single wiphy, multiple radios are combined into a single wiphy. > Since any channel can be assigned to a vif being brought up, > the vdev cannot be created during add_interface(). Hence defer the > vdev creation till channel assignment. > > If only one radio is part of the wiphy, then the existing logic > is maintained, i.e vdevs are created during add interface and > started during channel assignment. This ensures no functional changes > to single pdev devices which has only one radio in the SoC. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Sriram R Acked-by: Jeff Johnson