Received-SPF: pass (google.com: domain of linux-wireless+bounces-1832-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v3] wifi: rtlwifi: rtl_usb: Use sync register writes
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <fb71bae6-8b19-4b6e-b4a6-0d260f2139e1@gmail.com>
References: <fb71bae6-8b19-4b6e-b4a6-0d260f2139e1@gmail.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
 Ping-Ke Shih <pkshih@realtek.com>, Larry Finger <Larry.Finger@lwfinger.net>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <170507953842.1153005.9541258288523966124.kvalo@kernel.org>
Date: Fri, 12 Jan 2024 17:12:20 +0000 (UTC)

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Currently rtl_usb performs register writes using the async
> usb_submit_urb() function. This appears to work fine for the RTL8192CU,
> but the RTL8192DU (soon to be supported by rtlwifi) has a problem:
> it transmits everything at the 1M rate in the 2.4 GHz band. (The 5 GHz
> band is still untested.)
> 
> With this patch, rtl_usb performs the register writes using the
> synchronous usb_control_msg() function, and the RTL8192DU works
> normally. The RTL8192CU still works.
> 
> The vendor drivers use the async writes in only one function,
> rtl8192du_trigger_gpio_0 / rtl8192cu_trigger_gpio_0, which probably
> doesn't even run in real life. They use sync writes everywhere else.
> 
> Also, remove "sync" and "async" from the names of the members of
> struct rtl_io to avoid confusion:
> 
> write{8,16,32}_async -> write{8,16,32}
>  read{8,16,32}_sync  ->  read{8,16,32}
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

178cc55d5129 wifi: rtlwifi: rtl_usb: Use sync register writes

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/fb71bae6-8b19-4b6e-b4a6-0d260f2139e1@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches