Received-SPF: pass (google.com: domain of linux-wireless+bounces-1865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <25e2a46e-51a3-4bae-836e-6ceb2b5c4ebe@quicinc.com>
Date: Fri, 12 Jan 2024 18:05:47 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 03/10] wifi: ath12k: implement handling of P2P NoA
 event
Content-Language: en-US
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
        Kang Yang
	<quic_kangyang@quicinc.com>, <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240112092824.7664-1-quic_kangyang@quicinc.com>
 <20240112092824.7664-4-quic_kangyang@quicinc.com>
 <b1cb2130-ca6c-525e-4370-ea0acbd73138@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <b1cb2130-ca6c-525e-4370-ea0acbd73138@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 1/12/2024 5:35 PM, Karthikeyan Periyasamy wrote:
> 
> On 1/12/2024 2:58 PM, Kang Yang wrote:
>> +	ieee80211_iterate_active_interfaces_atomic(ar->hw,
>> +						   IEEE80211_IFACE_ITER_NORMAL,
>> +						   ath12k_p2p_noa_update_vdev_iter,
>> +						   &arg);
> 
> 
> ath12k_ar_to_hw(ar) is introduced to avoid direct access of hw from radio (ie, ar->hw).
> 
> This new helper function introduced by the patchset "[PATCH v2 1/2] wifi: ath12k: Refactor the mac80211 hw access from link/radio"
> 
> 
> @jeff
> 
> Any comments ?

you are correct, we should use the helper function
Please rebase on hw abstraction series

/jeff