Received-SPF: pass (google.com: domain of linux-wireless+bounces-1877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
  Ping-Ke Shih <pkshih@realtek.com>,  Larry Finger
 <Larry.Finger@lwfinger.net>
Subject: Re: wifi: rtlwifi: Speed up firmware loading for USB
References: <6351ca3f-6b06-4fe1-ace7-6e9d67497dce@gmail.com>
	<87o7dphha3.fsf@kernel.org>
	<e72fdcf0-2d2c-496e-a9be-8b554dec9fd4@gmail.com>
Date: Sat, 13 Jan 2024 14:52:22 +0200
In-Reply-To: <e72fdcf0-2d2c-496e-a9be-8b554dec9fd4@gmail.com> (Bitterblue
	Smith's message of "Sat, 13 Jan 2024 14:08:45 +0200")
Message-ID: <87v87x8kft.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:

> On 13/01/2024 08:35, Kalle Valo wrote:
>
>> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
>> 
>>> Currently it takes almost 6 seconds to upload the firmware for RTL8192CU
>>> (and 11 seconds for RTL8192DU). That's because the firmware is uploaded
>>> one byte at a time.
>>>
>>> Also, after plugging the device, the firmware gets uploaded three times
>>> before a connection to the AP is established.
>>>
>>> Maybe this is fine for most users, but when testing changes to the
>>> driver it's really annoying to wait so long.
>>>
>>> Speed up the firmware upload by writing chunks of 64 bytes at a time.
>>> This way it takes about 110 ms for RTL8192CU (and about 210 ms for
>>> RTL8192DU).
>>>
>>> PCI devices could upload it in chunks of 4 bytes, but I don't have any
>>> to test and commit 89d32c9071aa ("rtlwifi: Download firmware as bytes
>>> rather than as dwords") decided otherwise anyway.
>>>
>>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> 
>> There's another version so I assume I can drop this one:
>> 
>> https://patchwork.kernel.org/project/linux-wireless/patch/0d262acd-4f94-41c2-8d15-83486aeb976b@gmail.com/
>> 
>
> Yes, you can drop this one. Sorry about that. I forgot to write
> "[PATCH]" in the subject. I thought you wouldn't even notice this
> one because of that.

I think patchwork assumes that any mail with a diff is a patch, like
this one:

https://patchwork.kernel.org/project/linux-wireless/patch/c7b331edd65b66521a6605177d654e55051568a3.camel@toradex.com/

So "[PATCH]" is more like a visual clue. BTW usually it's a good idea to
mark the next mail as v2 and explain in changelog what happened/changed,
that way everyone are on the same page. But no big deal, just trying to
make this smooth for everyone :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches