Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp77752rdb; Sun, 14 Jan 2024 07:17:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMUwKABgvoOlOeanaGh5RJoB0O5v20TWu8s/4uZGb1pAODOBxuTJhmdMV+ncElEgTRZn3A X-Received: by 2002:a17:902:b68e:b0:1d4:2c5e:c3cc with SMTP id c14-20020a170902b68e00b001d42c5ec3ccmr1696816pls.132.1705245467250; Sun, 14 Jan 2024 07:17:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705245467; cv=none; d=google.com; s=arc-20160816; b=vTL8AbHaPrVbZT/IjJKkXpMiLU38togQk+A6tM7zA4PSj/GEAv3exBsYhH2QQIQikY ZoHU+Ei1iG6jW8ZKoUApmPunOj8Hj5Ji6jifAPyOHYUo3xeF1yCWDWZLLs/vVyRPC3DS lzU/le/UI3l2j10uhgiKekykCigUbwV+9hclganqcLKRD/NrwTD0jA5KWdiciIDbEiKQ Vv7MbKDpV3GVQ3GjFoqJAULpcGqd/2IWL9ePIiBUhiq5OtxyA+p9ONqoK2kvlKv0OE5z nAruRsHcXl3A1MH3jmY56g5TnQb298Y+k/K14CSigZ+ppycfpqE4b3EpTNA6erhkE6YD 9xRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=A3OxrwZkSZ9o4JFB/NbcUhILJqAlcRTT4aveTTQC094=; fh=XCkkmjWGGB7zflcV0Gvz+husypqgD8nHKgDHZdFwWko=; b=FmtG6sCrqioK7UjChYKWQG4DHBm1NteG9LYytk5TkgeyyysgrWiW3clKMlTGrsmefv p9iuu/xceJ0rBPhoScifJ4i1X5ExYeZOlFFKgLiScWZLPJ/kWaasA4lnx0EOjT5Grwy0 6NWxOd6bECJbOd2FiGYWuNVKVJ3J+hvagjEuoJBo0jshm4CXJGbeH/LyazoY7klQMq3g 5M64Re3YN3f8CSApwX5SNX++OEkEGbIsOdlH09DlZX96imauUZpW4CUFGakUvwFreIVa pL1HdT/BPMtJBCTy96Q5JbRZoudndPz4S9Q97hSeDyjSDITlvlmYz0afOOpXFjdUExkH VJFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfudFVxB; spf=pass (google.com: domain of linux-wireless+bounces-1891-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t22-20020a170902b21600b001d4396bec33si6936519plr.469.2024.01.14.07.17.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jan 2024 07:17:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-1891-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfudFVxB; spf=pass (google.com: domain of linux-wireless+bounces-1891-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-1891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B6F8C2821F3 for ; Sun, 14 Jan 2024 15:17:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DC4523C6; Sun, 14 Jan 2024 15:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jfudFVxB" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CE3E7E; Sun, 14 Jan 2024 15:17:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4871C433C7; Sun, 14 Jan 2024 15:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705245462; bh=jollSml2+OM4Sa0F+IOmTJVXk53FpYSt8/GqaTL4RT0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jfudFVxBK71G0oW06zEROGpzorXRfUYL12QXEEG4r3NWje6A6JYor4oR7Mj5YhuOx BmZvb5epwfyNICraTP/4Fdmxtw5gyMOdbie4ehD50UPQXfZpwsIyOASzqDM482qMgo 3x4a/zMwxSGHmKlJggrPo0lw5l3IaE80WNw64Rujj6oJQAaEpqw9G4HxIxlrF0GRop /FUM5IXWoKICk8QBy+8xOjbOZxSG3BT70cllLbHBGefA/Gi2qloa6bKji1mrKRqswu ZEjhO0QzBtaHjVHUa8YOW+mwDDmq3Y2eI1iNcd3AQhvTeNsNsXknMf3ExQPUvIr+jO dVLGn00aVkIiQ== From: Kalle Valo To: Jeff Johnson Cc: , , Subject: Re: [PATCH] wifi: ath11k: document HAL_RX_BUF_RBM_SW4_BM References: <20240111-document-hal_rx_buf_rbm_sw4_bm-v1-1-ad277e8ab3cc@quicinc.com> Date: Sun, 14 Jan 2024 17:17:39 +0200 In-Reply-To: <20240111-document-hal_rx_buf_rbm_sw4_bm-v1-1-ad277e8ab3cc@quicinc.com> (Jeff Johnson's message of "Thu, 11 Jan 2024 11:24:23 -0800") Message-ID: <874jfg7xm4.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jeff Johnson writes: > Commit 7636c9a6e7d7 ("wifi: ath11k: Add multi TX ring support for WCN6750") > added HAL_RX_BUF_RBM_SW4_BM to enum hal_rx_buf_return_buf_manager. However, > as flagged by the kernel-doc script, the documentation was not updated: > > drivers/net/wireless/ath/ath11k/hal.h:689: warning: Enum value 'HAL_RX_BUF_RBM_SW4_BM' not described in enum 'hal_rx_buf_return_buf_manager' > > So update the documentation. No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson I'm not really a fan of kernel-doc in wireless drivers, it feels more unnecessary work. Should we remove the kernel-doc markings from ath11k altogether? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches